Skip to content

fixes emitter beams causing the SM to play supermatter.ogg (dust sound) #4760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

SirNightKnight
Copy link
Collaborator

@SirNightKnight SirNightKnight commented Jan 3, 2025

About The Pull Request

fixes emitter beams causing the SM to play supermatter.ogg (dust sound)
fix: #4697

Why It's Good For The Game

bug fix

Changelog

🆑
fix: Fixed emitter beams causing the SM to play the dusting sound.
/:cl:

@Addust
Copy link
Contributor

Addust commented Jan 3, 2025

THIS WAS A BUG?

@DexeeXI
Copy link
Collaborator

DexeeXI commented Jan 7, 2025

@Addust Yes and it wasn't properly reported or documented for quite some time, despite the common perception that the SM shouldn't be dusting at all when its being powered by pewpews.

@DexeeXI
Copy link
Collaborator

DexeeXI commented Jan 7, 2025

Looks good to me. Course, what I think doesn't matter as much as the others. But at least I can say that I did review it.

@ThePooba ThePooba merged commit d9212b0 into Monkestation:master Jan 7, 2025
27 checks passed
github-actions bot added a commit that referenced this pull request Jan 7, 2025
notghosti pushed a commit to notghosti/Monkestation2.0 that referenced this pull request Jan 9, 2025
notghosti pushed a commit to notghosti/Monkestation2.0 that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SM plays a dusting sound when hit by an emitter laser.
5 participants