Glide size is now determined by cpu usage. #4146
Conversation
|
imo it is somewhat user facing, if the effect is making movement feel smoother, even if it's a minor one. |
| var/error = max((last_cpu - 100) / 100 * world.tick_lag, 0) | ||
|
|
||
| for(var/atom/movable/trouble as anything in GLOB.gliding_atoms) | ||
| if(world.time >= trouble.glide_stopping_time || QDELETED(trouble)) |
There was a problem hiding this comment.
| if(world.time >= trouble.glide_stopping_time || QDELETED(trouble)) | |
| if(world.time >= trouble.glide_stopping_time || QDELING(trouble)) |
QDELETED(trouble) is just (isnull(trouble) || QDELING(trouble)) - and we'd runtime here anyways if trouble is null.
| // cache for sonic speed | ||
| cpu_values[cpu_index] = real_cpu | ||
| GLOB.avg_cpu_values[cpu_index] = avg_cpu | ||
| GLOB.cpu_index = WRAP(cpu_index + 1, 1, CPU_SIZE + 1) |
There was a problem hiding this comment.
| GLOB.cpu_index = WRAP(cpu_index + 1, 1, CPU_SIZE + 1) | |
| WRAP_UP(GLOB.cpu_index, CPU_SIZE + 1) |
double check that it's the same tho, just to be 100% sure
There was a problem hiding this comment.
Would need to run a few number tests but I think WRAP_UP would be different
Co-authored-by: Lucy <[email protected]>
|
really shouldn't have merged this as is, it contains a bunch of debug shit that is now cluttering your codebase |
|
also idk if active correction is actually a good idea, just ftr |
yea after seeing it in action for multiple runs it works for small deviations but lag spikes fucks with it hrder |
About The Pull Request
Non player facing change so no CL
tgstation/tgstation#85971
Why It's Good For The Game
Makes movement feel smoother
Changelog
🆑
/:cl: