Skip to content

[PORT] Soapbox component fixes #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Sep 11, 2024

About The Pull Request

Ports the following /tg/ PRs:

Changelog

🆑 Absolucy, vinylspiders, SmArtKar
fix: (vinylspiders) Fixed a hard delete with soapboxes.
fix: (SmArtKar) Fixed soapbox component sometimes runtiming roundstart.
/:cl:

vinylspiders and others added 2 commits September 10, 2024 23:10
## About The Pull Request


![firefox_P8rmiESgN1](https://github.com/user-attachments/assets/1c8b565f-3b3d-4264-b35a-79d1d056deaf)

Fixes this recently introduced hard del.

## Why It's Good For The Game

Spurious runtimes bgone.

## Changelog

:cl:
fix: fixed a hard del with soapboxes
/:cl:
…egistering signals (#85937)

## About The Pull Request

sometimes runtimed due to reassigning signals and it has been driving me
insane

## Changelog
:cl:
fix: Fixed soapbox component sometimes runtiming roundstart
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants