Moves the stamina subsystem and stun effect processing into the ticker priority bracket (#3798)

* Moves the stamina subsystem into the ticker priority bracket

* temp workaround for testmerge

Author: Absolucy

code/__DEFINES/status_effects.dm

@@ -12,6 +12,8 @@
 #define STATUS_EFFECT_FAST_PROCESS 0
 ///This is slower and better for more intensive status effects - 1s between ticks
 #define STATUS_EFFECT_NORMAL_PROCESS 1
+/// (monkestation addition) Similar speed to STATUS_EFFECT_FAST_PROCESS, but uses a high priority subsystem (SSpriority_effects).
+#define STATUS_EFFECT_PRIORITY 2
 
 //several flags for the Necropolis curse status effect
 ///makes the edges of the target's screen obscured

code/datums/status_effects/_status_effect.dm

@@ -65,6 +65,10 @@
 				START_PROCESSING(SSfastprocess, src)
 			if(STATUS_EFFECT_NORMAL_PROCESS)
 				START_PROCESSING(SSprocessing, src)
+			// monkestation start: SSpriority_effects
+			if(STATUS_EFFECT_PRIORITY)
+				START_PROCESSING(SSpriority_effects, src)
+			// monkestation end
 
 	update_particles()
 
@@ -76,6 +80,10 @@
 			STOP_PROCESSING(SSfastprocess, src)
 		if(STATUS_EFFECT_NORMAL_PROCESS)
 			STOP_PROCESSING(SSprocessing, src)
+		// monkestation start: SSpriority_effects
+		if(STATUS_EFFECT_PRIORITY)
+			STOP_PROCESSING(SSpriority_effects, src)
+		// monkestation end
 	if(owner)
 		linked_alert = null
 		owner.clear_alert(id)

code/datums/status_effects/buffs/stop_drop_roll.dm

@@ -1,8 +1,8 @@
 /datum/status_effect/stop_drop_roll
 	id = "stop_drop_roll"
 	alert_type = null
-
 	tick_interval = 0.8 SECONDS
+	processing_speed = STATUS_EFFECT_PRIORITY // monkestation edit: high-priority status effect processing
 
 /datum/status_effect/stop_drop_roll/on_apply()
 	if(!iscarbon(owner))

code/datums/status_effects/debuffs/debuffs.dm

@@ -6,6 +6,7 @@
 	alert_type = null
 	remove_on_fullheal = TRUE
 	heal_flag_necessary = HEAL_CC_STATUS
+	processing_speed = STATUS_EFFECT_PRIORITY // monkestation edit: high-priority status effect processing
 	var/needs_update_stat = FALSE
 
 /datum/status_effect/incapacitating/on_creation(mob/living/new_owner, set_duration)

monkestation/code/controllers/subsystem/z_priority_effects.dm

@@ -0,0 +1,5 @@
+PROCESSING_SUBSYSTEM_DEF(priority_effects)
+	name = "Priority Status Effects"
+	flags = SS_TICKER | SS_KEEP_TIMING | SS_NO_INIT
+	wait = 2 // Not seconds - we're running on SS_TICKER, so this is ticks.
+	stat_tag = "PEFF"

code/controllers/subsystem/processing/stamina.dm renamed to monkestation/code/controllers/subsystem/z_stamina.dm

@@ -2,8 +2,8 @@ SUBSYSTEM_DEF(stamina)
 	name = "Stamina"
 
 	priority = FIRE_PRIORITY_STAMINA
-	flags = SS_BACKGROUND|SS_POST_FIRE_TIMING|SS_NO_INIT
-	wait = 1 SECONDS
+	flags = SS_TICKER | SS_KEEP_TIMING | SS_NO_INIT
+	wait = 10 // Not seconds - we're running on SS_TICKER, so this is ticks.
 
 	var/list/processing = list()
 	var/list/currentrun = list()
@@ -21,6 +21,6 @@ SUBSYSTEM_DEF(stamina)
 	while(current_run.len)
 		var/datum/stamina_container/thing = current_run[current_run.len]
 		current_run.len--
-		thing.update(wait * 0.1)
+		thing.update(world.tick_lag * wait * 0.1)
 		if (MC_TICK_CHECK)
 			return

tgstation.dme

@@ -826,7 +826,6 @@
 #include "code\controllers\subsystem\processing\quirks.dm"
 #include "code\controllers\subsystem\processing\reagents.dm"
 #include "code\controllers\subsystem\processing\singulo.dm"
-#include "code\controllers\subsystem\processing\stamina.dm"
 #include "code\controllers\subsystem\processing\station.dm"
 #include "code\controllers\subsystem\processing\supermatter_cascade.dm"
 #include "code\controllers\subsystem\processing\tramprocess.dm"
@@ -5819,6 +5818,8 @@
 #include "monkestation\code\controllers\subsystem\init_profiler.dm"
 #include "monkestation\code\controllers\subsystem\job.dm"
 #include "monkestation\code\controllers\subsystem\profiler.dm"
+#include "monkestation\code\controllers\subsystem\z_priority_effects.dm"
+#include "monkestation\code\controllers\subsystem\z_stamina.dm"
 #include "monkestation\code\datums\action.dm"
 #include "monkestation\code\datums\dna.dm"
 #include "monkestation\code\datums\emotes.dm"