Local catgirl fixes a variety of random minor issues (#3823)

* Fix trying to add movable_physics to qdeleting bodyparts

* Fix some quirk runtimes

* Fix using `RegisterSignal` instead of `RegisterSignals`

* Fix pick() from empty list with empty surgery trays.

* Fix runtime error with the soft IC filter

* Fix "Cannot read null.fire_state" runtime error

* Fix runtime with credits passing "undefined" to `GLOB.start_state.score`

* Add a check to `/datum/wound/pierce/bleed/receive_damage` to try to track down source of runtime

* Fix "undefined variable /datum/status_effect/tased/var/do_afters" runtime error

* Fix "Cannot execute null.adjust()" runtime error.

Author: Absolucy

code/__HELPERS/roundend.dm

@@ -103,8 +103,8 @@ GLOBAL_LIST_INIT(round_end_images, world.file2list("data/image_urls.txt")) // MO
 
 	var/datum/station_state/end_state = new /datum/station_state()
 	end_state.count()
-	var/station_integrity = min(PERCENT(GLOB.start_state.score(end_state)), 100)
-	file_data["additional data"]["station integrity"] = station_integrity
+	roundend_station_integrity = min(PERCENT(GLOB.start_state.score(end_state)), 100)
+	file_data["additional data"]["station integrity"] = roundend_station_integrity
 	WRITE_FILE(json_file, json_encode(file_data))
 
 	SSblackbox.record_feedback("nested tally", "round_end_stats", num_survivors, list("survivors", "total"))
@@ -118,7 +118,7 @@ GLOBAL_LIST_INIT(round_end_images, world.file2list("data/image_urls.txt")) // MO
 	.[POPCOUNT_SHUTTLE_ESCAPEES] = num_shuttle_escapees
 	.["all_mobs_on_shuttle"] = list_of_mobs_on_shuttle
 	.["human_escapees_list"] = list_of_human_escapees
-	.["station_integrity"] = station_integrity
+	.["station_integrity"] = roundend_station_integrity
 
 /datum/controller/subsystem/ticker/proc/gather_antag_data()
 	var/team_gid = 1
@@ -225,6 +225,8 @@ GLOBAL_LIST_INIT(round_end_images, world.file2list("data/image_urls.txt")) // MO
 
 	var/speed_round = (STATION_TIME_PASSED() <= 10 MINUTES)
 
+	popcount = gather_roundend_feedback()
+
 	for(var/client/C in GLOB.clients)
 		if(!C?.credits)
 			C?.RollCredits()
@@ -233,7 +235,6 @@ GLOBAL_LIST_INIT(round_end_images, world.file2list("data/image_urls.txt")) // MO
 			C?.give_award(/datum/award/achievement/misc/speed_round, C?.mob)
 		HandleRandomHardcoreScore(C)
 
-	popcount = gather_roundend_feedback()
 	display_report(popcount)
 
 	CHECK_TICK

code/controllers/subsystem/ticker.dm

@@ -63,6 +63,8 @@ SUBSYSTEM_DEF(ticker)
 	var/mode_result = "undefined"
 	var/end_state = "undefined"
 
+	var/end_station_state
+
 	/// People who have been commended and will receive a heart
 	var/list/hearts
 
@@ -76,6 +78,9 @@ SUBSYSTEM_DEF(ticker)
 
 	var/list/popcount
 
+	/// (monkestation addition) The station integrity at roundend.
+	var/roundend_station_integrity
+
 /datum/controller/subsystem/ticker/Initialize()
 	// monkestation start: fix-lobby-music
 	var/old_login_music = trim(file2text("data/last_round_lobby_music.txt"))

code/datums/quirks/neutral_quirks.dm

@@ -180,7 +180,7 @@
 // to allow all inserted replacement eyes to become heterochromatic or for it to transfer between mobs"
 // Then just change this to [proc/add] I really don't care
 /datum/quirk/heterochromatic/add_unique(client/client_source)
-	var/color = client_source?.prefs.read_preference(/datum/preference/color/heterochromatic)
+	var/color = client_source?.prefs?.read_preference(/datum/preference/color/heterochromatic)
 	if(!color)
 		return
 
@@ -256,7 +256,7 @@
 
 // Phobia will follow you between transfers
 /datum/quirk/phobia/add(client/client_source)
-	var/phobia = client_source?.prefs.read_preference(/datum/preference/choiced/phobia)
+	var/phobia = client_source?.prefs?.read_preference(/datum/preference/choiced/phobia)
 	if(!phobia)
 		return
 

code/datums/wounds/pierce.dm

@@ -42,6 +42,8 @@
 	return ..()
 
 /datum/wound/pierce/bleed/receive_damage(wounding_type, wounding_dmg, wound_bonus, attack_direction, damage_source)
+	if(QDELETED(victim))
+		CRASH("Wound tried to receive damage with null/qdeling victim!")
 	if(victim.stat == DEAD || (wounding_dmg < WOUND_MINIMUM_DAMAGE) || wounding_type == WOUND_BURN)
 		return
 	if(!limb.can_bleed() || !prob(internal_bleeding_chance))

code/game/objects/items/surgery_tray.dm

@@ -146,7 +146,7 @@
 	return
 
 /obj/item/surgery_tray/attack_hand(mob/living/user)
-	if(!user.can_perform_action(src, NEED_HANDS))
+	if(!user.can_perform_action(src, NEED_HANDS) || !length(contents))
 		return ..()
 	var/obj/item/grabbies = pick(contents)
 	if(grabbies)

code/modules/mob/living/damage_procs.dm

@@ -96,7 +96,7 @@
 		if(CLONE)
 			damage_dealt = -1 *  adjustCloneLoss(damage_amount, forced = forced)
 		if(STAMINA)
-			damage_dealt = -1 * stamina.adjust(-damage)
+			damage_dealt = -1 * stamina?.adjust(-damage)
 		if(PAIN)
 			if(pain_controller)
 				var/pre_pain = pain_controller.get_average_pain()

code/modules/mob/mob_say.dm

@@ -73,14 +73,14 @@
 		return FALSE
 
 	if(soft_filter_result && !filterproof)
-		if(tgui_alert(usr,"Your message contains \"[soft_filter_result[CHAT_FILTER_INDEX_WORD]]\". \"[soft_filter_result[CHAT_FILTER_INDEX_REASON]]\", Are you sure you want to say it?", "Soft Blocked Word", list("Yes", "No")) != "Yes")
+		if(tgui_alert(usr, "Your message contains \"[soft_filter_result[CHAT_FILTER_INDEX_WORD]]\". \"[soft_filter_result[CHAT_FILTER_INDEX_REASON]]\", Are you sure you want to say it?", "Soft Blocked Word", list("Yes", "No")) != "Yes")
 			SSblackbox.record_feedback("tally", "soft_ic_blocked_words", 1, lowertext(config.soft_ic_filter_regex.match))
-			log_filter("Soft IC", message, filter_result)
+			log_filter("Soft IC", message, soft_filter_result)
 			return FALSE
 		message_admins("[ADMIN_LOOKUPFLW(usr)] has passed the soft filter for \"[soft_filter_result[CHAT_FILTER_INDEX_WORD]]\" they may be using a disallowed term. Message: \"[message]\"")
 		log_admin_private("[key_name(usr)] has passed the soft filter for \"[soft_filter_result[CHAT_FILTER_INDEX_WORD]]\" they may be using a disallowed term. Message: \"[message]\"")
 		SSblackbox.record_feedback("tally", "passed_soft_ic_blocked_words", 1, lowertext(config.soft_ic_filter_regex.match))
-		log_filter("Soft IC (Passed)", message, filter_result)
+		log_filter("Soft IC (Passed)", message, soft_filter_result)
 
 	if(client && !(ignore_spam || forced))
 		if(client.prefs.muted & MUTE_IC)

monkestation/code/modules/and_roll_credits/episode_names.dm

@@ -43,19 +43,19 @@
 	"THE CURIOUS CASE OF [uppr_name]", "ONE HELL OF A PARTY", "FOR YOUR CONSIDERATION", "PRESS YOUR LUCK", "A STATION CALLED [uppr_name]", "CRIME AND PUNISHMENT", "MY DINNER WITH [uppr_name]", "UNFINISHED BUSINESS", "THE ONLY STATION THAT'S NOT ON FIRE (YET)", "SOMEONE'S GOTTA DO IT", "THE [uppr_name] MIX-UP", "PILOT", "PROLOGUE", "FINALE", "UNTITLED", "THE END")]")
 	episode_names += new /datum/episode_name("[pick("SPACE", "SEXY", "DRAGON", "WARLOCK", "LAUNDRY", "GUN", "ADVERTISING", "DOG", "CARBON MONOXIDE", "NINJA", "WIZARD", "SOCRATIC", "JUVENILE DELIQUENCY", "POLITICALLY MOTIVATED", "RADTACULAR SICKNASTY", "CORPORATE", "MEGA")] [pick("QUEST", "FORCE", "ADVENTURE")]", weight=25)
 
-	switch(GLOB.start_state.score(SSticker.end_state))
+	switch(SSticker.roundend_station_integrity)
 		if(-INFINITY to -2000)
-			episode_names += new /datum/episode_name("[pick("THE CREW'S PUNISHMENT", "A PUBLIC RELATIONS NIGHTMARE", "[uppr_name]: A NATIONAL CONCERN", "WITH APOLOGIES TO THE CREW", "THE CREW BITES THE DUST", "THE CREW BLOWS IT", "THE CREW GIVES UP THE DREAM", "THE CREW IS DONE FOR", "THE CREW SHOULD NOT BE ALLOWED ON TV", "THE END OF [uppr_name] AS WE KNOW IT")]", "Extremely low score of [GLOB.start_state.score(SSticker.end_state)].", 250)
+			episode_names += new /datum/episode_name("[pick("THE CREW'S PUNISHMENT", "A PUBLIC RELATIONS NIGHTMARE", "[uppr_name]: A NATIONAL CONCERN", "WITH APOLOGIES TO THE CREW", "THE CREW BITES THE DUST", "THE CREW BLOWS IT", "THE CREW GIVES UP THE DREAM", "THE CREW IS DONE FOR", "THE CREW SHOULD NOT BE ALLOWED ON TV", "THE END OF [uppr_name] AS WE KNOW IT")]", "Extremely low score of [SSticker.roundend_station_integrity].", 250)
 		if(4500 to INFINITY)
-			episode_names += new /datum/episode_name("[pick("THE CREW'S DAY OUT", "THIS SIDE OF PARADISE", "[uppr_name]: A SITUATION COMEDY", "THE CREW'S LUNCH BREAK", "THE CREW'S BACK IN BUSINESS", "THE CREW'S BIG BREAK", "THE CREW SAVES THE DAY", "THE CREW RULES THE WORLD", "THE ONE WITH ALL THE SCIENCE AND PROGRESS AND PROMOTIONS AND ALL THE COOL AND GOOD THINGS", "THE TURNING POINT")]", "High score of [GLOB.start_state.score(SSticker.end_state)].", 250)
+			episode_names += new /datum/episode_name("[pick("THE CREW'S DAY OUT", "THIS SIDE OF PARADISE", "[uppr_name]: A SITUATION COMEDY", "THE CREW'S LUNCH BREAK", "THE CREW'S BACK IN BUSINESS", "THE CREW'S BIG BREAK", "THE CREW SAVES THE DAY", "THE CREW RULES THE WORLD", "THE ONE WITH ALL THE SCIENCE AND PROGRESS AND PROMOTIONS AND ALL THE COOL AND GOOD THINGS", "THE TURNING POINT")]", "High score of [SSticker.roundend_station_integrity].", 250)
 
 	if(istype(SSticker.mode, /datum/game_mode/dynamic))
 		var/list/ran_events = SSgamemode.triggered_round_events.Copy()
 		switch(rand(1, 100))
 			if(0 to 35)
 				episode_names += new /datum/episode_name("[pick("THE DAY [uppr_name] STOOD STILL", "MUCH ADO ABOUT NOTHING", "WHERE SILENCE HAS LEASE", "RED HERRING", "HOME ALONE", "GO BIG OR GO [uppr_name]", "PLACEBO EFFECT", "ECHOES", "SILENT PARTNERS", "WITH FRIENDS LIKE THESE...", "EYE OF THE STORM", "BORN TO BE MILD", "STILL WATERS")]", "Low threat level.", 150)
-				if(GLOB.start_state.score(SSticker.end_state) < -1000)
-					episode_names += new /datum/episode_name/rare("[pick("HOW OH HOW DID IT ALL GO SO WRONG?!", "EXPLAIN THIS ONE TO THE EXECUTIVES", "THE CREW GOES ON SAFARI", "OUR GREATEST ENEMY", "THE INSIDE JOB", "MURDER BY PROXY")]", "Low threat levels... but the crew still had a very low score.", GLOB.start_state.score(SSticker.end_state)/150*-2)
+				if(SSticker.roundend_station_integrity && SSticker.roundend_station_integrity < -1000)
+					episode_names += new /datum/episode_name/rare("[pick("HOW OH HOW DID IT ALL GO SO WRONG?!", "EXPLAIN THIS ONE TO THE EXECUTIVES", "THE CREW GOES ON SAFARI", "OUR GREATEST ENEMY", "THE INSIDE JOB", "MURDER BY PROXY")]", "Low threat levels... but the crew still had a very low score.", SSticker.roundend_station_integrity/150*-2)
 			if(35 to 60)
 				episode_names += new /datum/episode_name("[pick("THERE MIGHT BE BLOOD", "IT CAME FROM [uppr_name]!", "THE [uppr_name] INCIDENT", "THE ENEMY WITHIN", "MIDDAY MADNESS", "AS THE CLOCK STRIKES TWELVE", "CONFIDENCE AND PARANOIA", "THE PRANK THAT WENT WAY TOO FAR", "A HOUSE DIVIDED", "[uppr_name] TO THE RESCUE!", "ESCAPE FROM [uppr_name]", \
 				"HIT AND RUN", "THE AWAKENING", "THE GREAT ESCAPE", "THE LAST TEMPTATION OF [uppr_name]", "[uppr_name]'S FALL FROM GRACE", "BETTER THE [uppr_name] YOU KNOW...", "PLAYING WITH FIRE", "UNDER PRESSURE", "THE DAY BEFORE THE DEADLINE", "[uppr_name]'S MOST WANTED", "THE BALLAD OF [uppr_name]")]", "Moderate threat level", 150)

monkestation/code/modules/blood_datum/stunning.dm

@@ -210,7 +210,7 @@
 		span_notice("You try to remove the electrodes!"),
 	)
 	// If embedding was less... difficult to work with, I would make tasers rely on an embedded object to handle this
-	if(!do_after(src, 5 SECONDS, src, extra_checks = CALLBACK(src, PROC_REF(try_remove_taser_checks)), interaction_key = "tazed"))
+	if(!do_after(owner, 5 SECONDS, extra_checks = CALLBACK(src, PROC_REF(try_remove_taser_checks)), interaction_key = "tazed"))
 		return
 	owner.visible_message(
 		span_warning("[owner] removes the electrodes from [owner.p_their()] body!"),

monkestation/code/modules/blood_for_the_blood_gods/fly_away.dm

@@ -1,6 +1,6 @@
 /// Called on drop_organs for the organ to "fly away" using movable physics
 /obj/item/organ/proc/fly_away(turf/open/owner_location, fly_angle = rand(0, 360), horizontal_multiplier = 1, vertical_multiplier = 1)
-	if(!istype(owner_location))
+	if(QDELETED(src) || !istype(owner_location) || QDELING(owner_location))
 		return
 	return AddComponent(/datum/component/movable_physics, \
 		physics_flags = MPHYSICS_QDEL_WHEN_NO_MOVEMENT, \
@@ -16,7 +16,7 @@
 
 /// Proc called to initialize movable physics when a bodypart gets dismembered
 /obj/item/bodypart/proc/fly_away(turf/open/owner_location, fly_angle = rand(0, 360), horizontal_multiplier = 1, vertical_multiplier = 1)
-	if(!istype(owner_location))
+	if(QDELETED(src) || !istype(owner_location) || QDELING(owner_location))
 		return
 	pixel_x = -px_x
 	pixel_y = -px_y
@@ -34,7 +34,7 @@
 	)
 
 /obj/item/proc/launch_item(turf/open/owner_location, fly_angle = rand(0, 360), horizontal_multiplier = 1, vertical_multiplier = 1)
-	if(!istype(owner_location))
+	if(QDELETED(src) || !istype(owner_location) || QDELING(owner_location))
 		return
 	forceMove(owner_location)
 	return AddComponent(/datum/component/movable_physics, \

monkestation/code/modules/can_spessmen_feel_pain/pain/pain_assistance_tools.dm

@@ -372,8 +372,8 @@
 		return
 
 	if(slot_flags & slot)
-		RegisterSignal(user, list(COMSIG_LIVING_SET_BODY_POSITION, COMSIG_LIVING_SET_BUCKLED), PROC_REF(check_protection))
-		RegisterSignal(user, list(COMSIG_QDELETING, COMSIG_MOVABLE_PRE_MOVE), PROC_REF(disable_protection))
+		RegisterSignals(user, list(COMSIG_LIVING_SET_BODY_POSITION, COMSIG_LIVING_SET_BUCKLED), PROC_REF(check_protection))
+		RegisterSignals(user, list(COMSIG_QDELETING, COMSIG_MOVABLE_PRE_MOVE), PROC_REF(disable_protection))
 		try_enable(user)
 
 /obj/item/shock_blanket/dropped(mob/user, silent)

monkestation/code/modules/can_spessmen_feel_pain/pain/traits.dm

@@ -57,7 +57,7 @@
 	var/mob/living/carbon/carbon_holder = quirk_holder
 	if(istype(carbon_holder))
 		carbon_holder.set_pain_mod(PAIN_MOD_QUIRK, 1.2)
-	RegisterSignal(quirk_holder, list(COMSIG_LIVING_GET_PULLED, COMSIG_CARBON_HELP_ACT), PROC_REF(cause_body_pain))
+	RegisterSignals(quirk_holder, list(COMSIG_LIVING_GET_PULLED, COMSIG_CARBON_HELP_ACT), PROC_REF(cause_body_pain))
 
 /datum/quirk/allodynia/remove()
 	var/mob/living/carbon/carbon_holder = quirk_holder

monkestation/code/modules/liquids/liquid_groups.dm

@@ -639,6 +639,8 @@ GLOBAL_VAR_INIT(liquid_debug_colors, FALSE)
 	cached_fire_spreads[burning_member] = spreading_turfs
 
 /datum/liquid_group/proc/process_spread(turf/member)
+	if(QDELETED(src) || QDELETED(member) || QDELETED(member.liquids))
+		return
 	if(member.liquids.fire_state <= LIQUID_FIRE_STATE_MEDIUM) // fires to small to worth spreading
 		return