Skip to content

Fix connector import #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Fix connector import #20

merged 1 commit into from
Mar 18, 2020

Conversation

tzzh
Copy link
Contributor

@tzzh tzzh commented Dec 10, 2019

I think that should fix #13 but I am not a go or a terraform expert and there a couple things I noticed that might be problems:

  • if the actual config and the one in the the local terraform don't match it's going to succeed and then suggest the changes on the next apply which I am not sure is the behaviour we want
  • It's also going to ignore config_sensitive which I think is fine as this is not something provided by kafka-connect
  • I have also changed the signature of some of the functions to match what I saw in https://www.terraform.io/docs/extend/writing-custom-providers.html#defining-resources as it seemed reasonable and gave more meaningful errors when it was crashing initially

@Samlinxia
Copy link

@tzzh , I have the same error when importing existing resources. Will this patch solve this error? When are you planning to merge this? Thanks!

@Mongey Mongey merged commit e6c8ea3 into Mongey:master Mar 18, 2020
@Samlinxia
Copy link

@Mongey , thank you for responsive reply and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on importing resource
3 participants