Skip to content

Add ESLint checks #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 4, 2021
Merged

Add ESLint checks #10

merged 8 commits into from
Nov 4, 2021

Conversation

pirelenito
Copy link
Member

@pirelenito pirelenito commented Nov 3, 2021

I based the configuration from our internal repository and adapted it a bit to fit this open-source repository.

Mount

There was one bug found in the Mount component that it would still render components for facets without any value.

@pirelenito pirelenito requested review from dderg and xaviervia November 3, 2021 17:03
@pirelenito pirelenito marked this pull request as ready for review November 4, 2021 09:28
@pirelenito pirelenito merged commit 09f2730 into main Nov 4, 2021
@pirelenito pirelenito deleted the eslint branch November 4, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants