Skip to content

fix: make get_colors return wrt to color_overrides #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

agronskiy
Copy link

The issue

As a user of the theme, I want color_overrides, which I have passed during the setup, to have effect on get_colors elsewhere. Currently, they only have effect during the initialization of the theme.

The fix

Add deep table merge into get_colors.

Tests

Tested locally by importing colors in different other places of my setup.

@agronskiy
Copy link
Author

Hey @Mofiqul, thanks for a great plugin. While playing with it and wanting to extend couple of other highlight groups in a consistent way (== by using local c = require("vscode.colors").get_colors()) I realized that it returned unchanged table, despite me having color_overrides in init. This fixes it.

I hope this is the desired behavior.

Copy link
Owner

@Mofiqul Mofiqul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Mofiqul Mofiqul merged commit 0597386 into Mofiqul:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants