Support index-import on all Xcode 16.x versions #3162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
luis/update-index-import
branch
2 times, most recently
from
b3ce998 to
c182181
Compare
2 tasks
luispadron
force-pushed
the
luis/update-index-import
branch
from
c182181 to
7cfde82
Compare
3 tasks
luispadron
force-pushed
the
luis/update-index-import
branch
3 times, most recently
from
31dbb15 to
b65ce61
Compare
luispadron
changed the title
index-import for Xcode 16.3+
luispadron
force-pushed
the
luis/update-index-import
branch
from
efdb014 to
91ac284
Compare
|
|
Fix for rules_ios: bazel-ios/rules_ios#942, ill actually make a release soon and re-enable rules_ios CI here |
luispadron
added a commit
to bazel-ios/rules_ios
that referenced
this pull request
Apr 4, 2025
In bazelbuild/rules_swift#1504 the index-import repository name was changed. rules_ios depends on the old name and thus breaks builds. It looks like these deps are unused (probably after we got rid of xcodeproj rules). This fixes builds in rules_xcodeproj: MobileNativeFoundation/rules_xcodeproj#3162
luispadron
force-pushed
the
luis/update-index-import
branch
4 times, most recently
from
2590343 to
ea693fe
Compare
luispadron
force-pushed
the
luis/update-index-import
branch
from
ea693fe to
97c5c3c
Compare
luispadron
force-pushed
the
luis/bazel-head-fixes
branch
from
c3883f6 to
02a9914
Compare
luispadron
force-pushed
the
luis/update-index-import
branch
from
97c5c3c to
89decdb
Compare
luispadron
force-pushed
the
luis/update-index-import
branch
5 times, most recently
from
dc87ee7 to
f676c07
Compare
aaronsky
approved these changes
Apr 5, 2025
tools/generators/pbxproj_prefix/test/PBXProjectBuildSettingsTests.swift
Outdated
Show resolved
Hide resolved
tools/generators/pbxproj_prefix/test/PBXProjectBuildSettingsTests.swift
Outdated
Show resolved
Hide resolved
luispadron
force-pushed
the
luis/update-index-import
branch
from
00d9fa4 to
4fb5c19
Compare
brentleyjones
approved these changes
Apr 7, 2025
Similar to: bazelbuild/rules_swift#1504 Part of #3160 This PR updates the index-import dependency to include both version 5.8 and 6.1 as the hash algorithm changed in Swift 6.1. To make this change backwards compatible we switch to the 5.8 version on Xcode 16.2 and under. Signed-off-by: Luis Padron <[email protected]>
luispadron
force-pushed
the
luis/update-index-import
branch
from
4fb5c19 to
683fb75
Compare
thiagohmcruz
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to: bazelbuild/rules_swift#1504
Part of #3160
This PR updates the index-import dependency to include both version 5.8 and 6.1 as the hash algorithm changed in Swift 6.1.
To make this change backwards compatible we switch to the 5.8 version on Xcode 16.2 and under.