Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README with new installation instructions and lens install link #239

Closed
1 of 2 tasks
stefcameron opened this issue Apr 6, 2021 · 4 comments · Fixed by #286
Closed
1 of 2 tasks

Update README with new installation instructions and lens install link #239

stefcameron opened this issue Apr 6, 2021 · 4 comments · Fixed by #286
Labels
documentation Improvements or additions to documentation tracking Tracking an issue in a remote repo

Comments

@stefcameron
Copy link
Contributor

stefcameron commented Apr 6, 2021 •
edited
Loading

This Lens issue lensapp/lens#2422 is fixed in lensapp/lens#2394 and adds ability to specify npmjs.com link in install box, as well as use lens://app/extensions/install/@mirantis/lens-extension-cc?version=2.1.2 (version optional; without it, latest is installed) link to trigger installation.
@stefcameron stefcameron added documentation Improvements or additions to documentation tracking Tracking an issue in a remote repo labels Apr 6, 2021
@Nokel81
Copy link

Nokel81 commented Apr 6, 2021

lensapp/lens#2435 is the actual fix PR

@stefcameron
Copy link
Contributor Author

lensapp/lens#2435 is the actual fix PR

Thank you! 😄

@stefcameron stefcameron added this to the v2.2.0 milestone Apr 30, 2021
@stefcameron
Copy link
Contributor Author

None of this works right now in Lens 4.2.3, tracking: lensapp/lens#2688

@stefcameron stefcameron removed this from the v2.2.0 milestone Apr 30, 2021
@stefcameron
Copy link
Contributor Author

Note that the actual fix to lensapp/lens#1707 and lensapp/lens#1708 was to support simply entering @mirantis/lens-extension-cc (or any other extension name as published to NPM) into the "Install Extension" box and clicking the Install button.

Verified this works on Lens 4.2.4.

stefcameron added a commit that referenced this issue May 4, 2021
@stefcameron
Updated and simplied installation instructions
17366fb 
Fixes #239
@stefcameron stefcameron mentioned this issue May 4, 2021
Merged
stefcameron added a commit that referenced this issue May 4, 2021
@stefcameron
Updated and simplied installation instructions (#286)
affd34a 
Fixes #239

Updates Lens package to 4.2.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation tracking Tracking an issue in a remote repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated and simplied installation instructions Mirantis/lens-extension-cc
2 participants
@stefcameron @Nokel81