-
Notifications
You must be signed in to change notification settings - Fork 27
feat(provider)!: positioned wildcard matching #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for positioned wildcard matching to the key filtering functionality, allowing flexible filtering patterns for sensitive data. Key changes include:
- Splitting a generic wildcard test into dedicated tests for keys starting with, ending with, containing, or exactly matching the filter string.
- Updating the filter_keys function to support different wildcard positions.
- Enhancing the README documentation with clear examples of the new wildcard matching behavior.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
python3/tests/test_utilities.py | Added dedicated tests for each wildcard matching pattern |
python3/raygun4py/utilities.py | Revised filter_keys implementation to handle positioned wildcard expressions |
README.rst | Updated documentation to explain the new wildcard matching patterns and examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, nice one 👍
Description 📝
Purpose:
Adds support to positioned wildcard matching.
Approach:
Use the
*
position to match the keys.foo*
matchesfoobar
but notbarfoobar
*foo
matchesbarfoo
but notbarfoobar
*foo*
matchesfoobar
,barfoo
andbarfoobar
foo
matchesfoo
and nothing elseType of change
fix:
Bug fix (non-breaking change which fixes an issue)feat:
New feature (non-breaking change which adds functionality)chore:
Chore task, release or small impact changeci:
CI configuration changeUpdates
filter_keys
Related issues
RaygunMessage
object inon_grouping_key
method #118Test plan 🧪
Author to check 👓
Reviewer to check ✔️