fix: changes for FFI API in Deno 1.44

[Milly]

Prior to Deno 1.44, -1n was returned as the error handle.
See: denoland/deno#23981

Summary by CodeRabbit

• Bug Fixes
  • Improved compatibility with Deno 1.44 by updating handle validation logic.
• Refactor
  • Updated condition checks for handle validity across the application to use a more robust approach.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (28fd93d) to head (7dd6139).

Additional details and impacted files

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   86.65%   86.78%   +0.12%     
==========================================
  Files           8        8              
  Lines         727      734       +7     
  Branches       65       65              
==========================================
+ Hits          630      637       +7     
  Misses         93       93              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Milly]

@coderabbitai review

[coderabbitai]

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Walkthrough

The recent changes focus on improving compatibility with Deno 1.44 by updating how handle values are checked in client.ts and server.ts. The INVALID_HANDLE_VALUE constant in constants.ts has been modified to an array containing specific invalid values. This ensures more robust and future-proof validation of handle values across the application.

Changes

Files	Change Summary
client.ts	Modified the assertion condition in the connect function to use a different approach for handle value validation.
constants.ts	Changed INVALID_HANDLE_VALUE from a single value to an array of values for better compatibility with Deno 1.44.
server.ts	Updated the createNamedPipe function to check handle validity against an array of invalid values.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant Client
    participant Constants
    participant Server

    Client->>Constants: Check INVALID_HANDLE_VALUE
    Constants-->>Client: Return array of invalid values
    Client->>Server: Request to create named pipe
    Server->>Constants: Validate handle value
    Constants-->>Server: Return array of invalid values
    Server-->>Client: Confirm handle validity

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

server.ts (1)

Line range hint 164-164: Please specify a type for the variable to avoid the implicit any type issue flagged by the static analysis tool.

// Example fix:
let someVariable: number; // Adjust the type as necessary

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 28fd93d and 7dd6139.

Files selected for processing (3)

• client.ts (1 hunks)
• constants.ts (1 hunks)
• server.ts (1 hunks)

Additional context used

Biome

server.ts

[error] 164-164: This variable implicitly has the any type.

Variable declarations without type annotation and initialization implicitly have the any type. Declare a type or initialize the variable with some value.

Additional comments not posted (3)

constants.ts (1)

1-6: The update to INVALID_HANDLE_VALUE to support an array of values is well-implemented and aligns with the changes in Deno 1.44. The inclusion of detailed comments with references enhances maintainability and clarity.

client.ts (1)

84-86: The updated assertion in the connect function correctly utilizes the new array format of INVALID_HANDLE_VALUE to check for invalid handles. This change ensures compatibility with Deno 1.44 and improves error handling.

server.ts (1)

218-220: The updated assertion in the createNamedPipe function correctly utilizes the new array format of INVALID_HANDLE_VALUE to check for invalid handles. This change ensures compatibility with Deno 1.44 and improves error handling.