Add setting to disable ControlNet in highres fix pass #1832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
approved these changes
Jul 26, 2023
|
Tests in #1826 (comment) also seem to show that it's working accordingly, so I'd say this is ready. |
tiangles
pushed a commit
to diffus-me/sd-webui-controlnet
that referenced
this pull request
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1826
Adds an option in settings to disable ControlNet in highres fix. I'm not 100% sure if this breaks anything so I'm setting this as a draft for now. I also cannot produce anything that causes a "big negative impact" as mentioned in the issue, as in my tests images look nearly the same with or without this setting enabled, but that does mean it can cut down generation times in half with minimal change to the final output, so I figure it's a nice QoL feature to have.