Skip to content

[✨ Triage] dotnet/aspire#10345 by eerhardt - Inputs dialog shows dismiss button even when ShowDismiss = false #1217

Open
@MihuBot

Description

@MihuBot

Triage for dotnet/aspire#10345.
Repo filter: area-dashboard issues.
MihuBot version: 4431de.
Ping MihaZupan for any issues.

This is a test triage report generated by AI, aimed at helping the triage team quickly identify past issues/PRs that may be related.
Take any conclusions with a large grain of salt.

dotnet/aspire#10345: Inputs dialog shows dismiss button even when ShowDismiss = false by eerhardt
[Tool] Searching for ShowDismiss, PromptInputsAsync dismiss button, InputsDialogInteractionOptions dismiss, PromptInputsAsync ShowDismiss false (IncludeOpen=True, IncludeClosed=True, IncludeIssues=True, IncludePullRequests=True, Repository=dotnet/aspire)
[Tool] Found 20 issues, 47 comments, 20 returned results (10845 ms)

Here are the most relevant related issues and discussions for issue #10345 ("Inputs dialog shows dismiss button even when ShowDismiss = false"):


1. PR #10038 (June 2025) - Add Azure provisioning command handling and settings configuration

  • Discussion:

    • On July 10, 2025, @davidfowl commented:
      "It should be possible to dismiss, allowing users to interact with the dashboard and other resources still."
    • On July 11, 2025, @JamesNK responded:
      "You've set ShowDismiss = false but the dismiss button (top right cross) is still visible? That would be a bug."

    Summary:
    This PR and its comments directly acknowledge the issue: setting ShowDismiss = false should hide the dismiss button, and if it does not, it's considered a bug. This matches the report in #10345.


2. PR #10235 (July 2025) - Added support for prompting for parameter values in run mode

  • Discussion:

    • On July 3, 2025, @davidfowl said:
      "Yep that's why I didn't do it. You can still dismiss the whole thing though."

    Summary:
    This PR discusses prompting for parameters and mentions dialog dismissal, but does not directly address the ShowDismiss property. It does, however, indicate that dismissing dialogs is a known and considered behavior.


3. Issue #6021 (September 2024) - Click Help on the Aspire Dashboard page, and the "Close" button prompt will automatically appear.

  • Discussion:

    • This issue is about the appearance of a "Close" button and its tooltip, not specifically about the ShowDismiss property.
    • It was identified as a regression in the underlying FluentUI Blazor library and was fixed in Aspire 9.1.0-preview.1.24578.4.

    Summary:
    Related to dialog close button behavior, but not specifically about the ShowDismiss property or input dialogs.


4. PR #10056 (June 2025) - Rename interaction inputs, improve input dialog UX

  • Summary:
    This PR improves input dialog UX but does not mention the ShowDismiss property or dialog dismissal logic.

5. PR #9943 (June 2025) - Interaction service

  • Summary:
    This PR introduces the InteractionService and related dialog APIs, but the comments do not discuss the ShowDismiss property or dismiss button visibility.

6. Issue #9807 (June 2025) - Prompt for values

  • Summary:
    This issue and its comments discuss prompting for values and the interaction service, but do not mention dialog dismissal or the ShowDismiss property.

Conclusion

The most directly relevant discussion is in PR #10038, where @JamesNK confirms that if ShowDismiss = false does not hide the dismiss button, it is a bug. This matches the behavior reported in issue #10345 and confirms that the issue is valid and not yet resolved.

No other issues or PRs found discuss a fix or workaround for this specific problem. There is no indication that this has been addressed in recent merged PRs or closed issues.


Recommendation

  • Triaging: Mark issue #10345 as a confirmed bug, referencing the discussion in PR #10038.
  • Next steps: Await assignment or further investigation by the maintainers, as there is consensus that the current behavior is not as intended.

References

If you need a summary for issue comments or further details, let me know!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions