Skip to content

Not enough space in warning popup to fit full file name #4661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
paboum opened this issue Mar 4, 2025 · 7 comments
Open
2 tasks done

Not enough space in warning popup to fit full file name #4661

paboum opened this issue Mar 4, 2025 · 7 comments
Assignees
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around state: approved If not using PRs: associated branch has been approved ver: 4.8.32 Reproducible in version 4.8.32
Milestone

Comments

@paboum
Copy link

paboum commented Mar 4, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Midnight Commander version

GNU Midnight Commander 4.8.32
Built with GLib 2.78.6
Built with S-Lang 2.3.3 with terminfo database
With builtin editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
With ext2fs attributes support
Virtual File Systems:
 cpiofs, tarfs, sfs, extfs, ext2undelfs, ftpfs, shell
Data types:
 char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

Operating system

Linux ????? 6.12.16-gentoo-x86_64 #3 SMP PREEMPT_DYNAMIC Mon Mar  3 13:20:28 CET 2025 x86_64 12th Gen Intel(R) Core(TM) i9-12900K GenuineIntel GNU/Linux

Is this issue reproducible using the latest version of Midnight Commander?

  • I confirm the issue is still reproducible with the latest version of Midnight Commander

Current behavior

Image
What file cannot be replaced? 🤨

Expected behavior

I would expect either the popup window be bigger, perhaps proportional to modern terminal size. Or the file name should be scrolling in the current tiny window so that it can be discovered.

Additional context

No response

@paboum paboum added needs triage Needs triage by maintainers prio: medium Has the potential to affect progress labels Mar 4, 2025
@github-actions github-actions bot added this to the Future Releases milestone Mar 4, 2025
@mc-worker mc-worker added area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around and removed prio: medium Has the potential to affect progress needs triage Needs triage by maintainers labels Mar 4, 2025
@zyv zyv added the ver: 4.8.32 Reproducible in version 4.8.32 label Mar 4, 2025
@zyv zyv changed the title Not enough space in popup to fit full file name Not enough space in warning popup to fit full file name Mar 4, 2025
aborodin added a commit that referenced this issue Apr 27, 2025
  * (path_trunc): improve: constify and rename the 2nd argument,
    add possibility to return non-truncated path by passing -1 as
    truncation width, update Doxygen comment.

Signed-off-by: Andrew Borodin <[email protected]>
@mc-worker mc-worker modified the milestones: Future Releases, 4.8.34 Apr 27, 2025
@mc-worker mc-worker self-assigned this Apr 27, 2025
@mc-worker mc-worker added the state: in review If not using PRs: associated branch is being reviewed label Apr 27, 2025
aborodin added a commit that referenced this issue Apr 28, 2025
  * (path_trunc): improve: constify and rename the 2nd argument,
    add possibility to return non-truncated path by passing -1 as
    truncation width, update Doxygen comment.

Signed-off-by: Andrew Borodin <[email protected]>
@zyv zyv added state: in review If not using PRs: associated branch is being reviewed and removed state: in review If not using PRs: associated branch is being reviewed labels Apr 29, 2025
Copy link

The changes in the branch associated with this issue are ready for review.

@zyv
Copy link
Member

zyv commented Apr 29, 2025

@aborodin my problem is that when you set labels, I don't get an email, so there is no way to learn about it other than checking some filters every day like issues that move to in review or approved states.

However, I hope to have finally found a new solution that works. You can set the labels however you like. When you set the label, GitHub will automatically comment on the issue, so an email will be sent. Forget about the /approve and /review commands. I removed them. How about this?

@zyv zyv added the state: approved If not using PRs: associated branch has been approved label Apr 29, 2025
@github-actions github-actions bot removed the state: in review If not using PRs: associated branch is being reviewed label Apr 29, 2025
Copy link

The changes in the branch associated with this issue have been approved.

@zyv
Copy link
Member

zyv commented Apr 29, 2025

My understanding is that the new behavior is that the filenames are only truncated to terminal width (or not truncated at all). I think this is a good solution. Thank you very much!

@paboum
Copy link
Author

paboum commented Apr 29, 2025

Seems this change resolves my issue.
Image

@mc-worker
Copy link

However, I hope to have finally found a new solution that works. You can set the labels however you like. When you set the label, GitHub will automatically comment on the issue, so an email will be sent. Forget about the /approve and /review commands. I removed them. How about this?

Got it.

aborodin added a commit that referenced this issue May 18, 2025
  * (path_trunc): improve: constify and rename the 2nd argument.
    Add possibility to return non-truncated path by passing a negative
    value as truncation width. Update Doxygen comment.

Signed-off-by: Andrew Borodin <[email protected]>
@mc-worker
Copy link

If approved state is still actual I propose to merge this branch and then change a message box layout in #4692.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around state: approved If not using PRs: associated branch has been approved ver: 4.8.32 Reproducible in version 4.8.32
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants