Skip to content

PTC Conformity for Misalignment #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 1, 2023

Conversation

jgray-19
Copy link
Contributor

I would highly recommend not accepting this pull request just yet, as I would like to discuss the changes.

  • Entry translation is rotated first before performing the translation, with edir weighting occurring first, as we translate a rotated frame.
  • edir is a bit of a mess at the moment, as I found that for the rotation multiplications, edir needs to be taken into consideration beforehand due to the independence of edir on ds. This leads to too many and ugly uses of edir.
  • translate weights everything, so we only need to provide lw.
  • PTC uses path length for the calculation of rtbar.
  • Translation needs to occur on exit independent of algn.trn as rtbar can create a translation.
  • mang needs to be used for all rbends and sbends (most likely anything with an angle)
  • Comparison w/ ptc is difficult as the order of rotations used is x, y, s, not y, -x, s (rotating y and x simultaneously causes relatively high errors.)

Add comments and reasoning for changes

Revert "Add comments and reasoning for changes"

This reverts commit acf6faa.

Revert "Make misalignment agree with ptc + improve (e/s)dir"

This reverts commit 81c15cb.
@ldeniau ldeniau marked this pull request as ready for review September 1, 2023 14:14
@ldeniau ldeniau merged commit 3c6ac5c into MethodicalAcceleratorDesign:dev Sep 1, 2023
@jgray-19 jgray-19 deleted the misalign_ptc branch October 22, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants