Fix charge dependancy of qsad_fringe #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldeniau
approved these changes
Aug 1, 2023
ldeniau
approved these changes
Aug 1, 2023
|
Let's fix it to be compatible with PTC. A cross-check with the SAD manual could confirm or not the problem... |
|
Reviewing the SAD manual, it seems that compared to entry and exit, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performing an ng vs ng test reveals that for the map to be fully reversed when chg is reversed, f2 must also be multiplied
HOWEVER I am not sure if f2 should also be multiplied by lw. It is not in PTC (but it's also not multiplied by charge), so this needs to be reviewed.