Skip to content

Add a flag to force the plots to close on exit #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 22, 2023
Merged

Add a flag to force the plots to close on exit #306

merged 7 commits into from
May 22, 2023

Conversation

jgray-19
Copy link
Contributor

  • Names are not perfect, but it works

@jgray-19 jgray-19 force-pushed the plot_improvements branch from 10e0911 to 376911d Compare May 16, 2023 09:37
@jgray-19 jgray-19 force-pushed the plot_improvements branch from 376911d to 86e10a7 Compare May 16, 2023 09:38
ldeniau
ldeniau requested changes May 21, 2023
View reviewed changes
Copy link
Contributor

@ldeniau ldeniau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atexit will record a new kill_plots function at each call to plot with close_plots=true, not good.

ldeniau
ldeniau requested changes May 21, 2023
View reviewed changes
Copy link
Contributor

@ldeniau ldeniau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atexit will record a new kill_plots function at each call to plot with close_plots=true, not good. This atexit should be combined/recorded with the other atexit of plot if possible.

jgray-19 added 4 commits May 22, 2023 09:59
Update kill_plots to perform fewer functions atexit by killing plots …
961517f 
…based on sid rather than every call of the plot command!
Fix typo
d122224
Force only one atexit to be run once
d6de17c 
Also simplify the nil and number output so that less is repeated
cleanup
d1e47e8
@ldeniau ldeniau merged commit a5eeb46 into MethodicalAcceleratorDesign:dev May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldeniau ldeniau ldeniau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgray-19 @ldeniau