Skip to content

change codeMirror to ACE #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

change codeMirror to ACE #992

wants to merge 1 commit into from

Conversation

zonky2
Copy link
Contributor

@zonky2 zonky2 commented Mar 15, 2016

Description

change codeMirror to ACE

dependent on DCG PR contao-community-alliance/dc-general#206

Checklist

  • Read and understood the CONTRIBUTING guidelines
  • Created tests, if possible
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself to the @authors in touched PHP files
  • Checked the changes with phpcq and introduced no new issues

shot162

@zonky2 zonky2 added the enhancement This issue is about an enhancement (aka new feature) label Jun 3, 2016
@zonky2 zonky2 added this to the 2.0.0 milestone Jun 3, 2016
@zonky2
Copy link
Contributor Author

zonky2 commented Jul 15, 2016

what ist the problem? why dont you merge this small PR...?

discordier added a commit that referenced this pull request Jul 19, 2016
Change code editor from "codeMirror" to "ACE" in filter setting.
@discordier
Copy link
Member

Merged in dcea4d5

@discordier discordier closed this Jul 19, 2016
discordier added a commit that referenced this pull request Aug 11, 2016
Alpha release

The system requirements have been raised in this release.
We now require:
- PHP >=5.4
- Contao >=3.5.5 (but no Contao 4 support yet, sorry).

This fixes:
- We now use codeMirror instead of ACE (#992)
- An "ORDER BY" was missing in a query (#1020)
- Centralized the "add all" for render settings and input screens into a common
  class.
- ToolboxFile is now completely using the Dbafs. This should provide massive
  speed improvements for file attributes holding a lot of files.
- Page picker did not show the selected value (#1026).
- Various fixes in code style, comments and the like.
discordier added a commit that referenced this pull request Aug 11, 2016
Alpha release

The system requirements have been raised in this release.
We now require:
- PHP >=5.4
- Contao >=3.5.5 (but no Contao 4 support yet, sorry).

This fixes:
- We now use codeMirror instead of ACE (#992)
- An "ORDER BY" was missing in a query (#1020)
- Centralized the "add all" for render settings and input screens into a common
  class.
- ToolboxFile is now completely using the Dbafs. This should provide massive
  speed improvements for file attributes holding a lot of files.
- Page picker did not show the selected value (#1026).
- Various fixes in code style, comments and the like.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is about an enhancement (aka new feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants