Skip to content

[RTM] hotfix hide popup widget hint #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2018
Merged

[RTM] hotfix hide popup widget hint #1257

merged 1 commit into from
Dec 17, 2018

Conversation

zonky2
Copy link
Contributor

@zonky2 zonky2 commented Dec 17, 2018

hotfix hide popup widget hint

hide hint until new picker is created

@zonky2 zonky2 added the enhancement This issue is about an enhancement (aka new feature) label Dec 17, 2018
@zonky2 zonky2 added this to the 2.0.6 milestone Dec 17, 2018
@zonky2 zonky2 requested a review from baumannsven December 17, 2018 16:40
@zonky2 zonky2 modified the milestones: 2.0.6, 2.0.7 Dec 17, 2018
@zonky2 zonky2 mentioned this pull request Dec 17, 2018
Closed
@discordier discordier changed the base branch from master to hotfix/2.0.7 December 17, 2018 18:30
@zonky2 zonky2 changed the title hotfix hide popup widget hint [RTM] hotfix hide popup widget hint Dec 17, 2018
discordier
discordier approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@discordier discordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a solution that implements the sorting, the hint however makes no sense currently.

@discordier discordier merged commit 278fde5 into MetaModels:hotfix/2.0.7 Dec 17, 2018
discordier added a commit that referenced this pull request Dec 17, 2018
@discordier
Merge pull request #1257 from @zonky2
94f466f 
This hides the sorting hint in popup widgets.
discordier added a commit that referenced this pull request Dec 19, 2018
@discordier
Merge tag '2.0.7'
c066860 
Maintenance release.

Fixes:
- #1256 - Fix warning of undefined constants TL_ASSETS_URL and TL_FILES_URL.
- #1257 - Hide sorting hint in popup widgets.
- #1258, #1234 Frontend filter widgets for simple lookup can now be enabled
  and disabled via a checkbox.
- #1259 - Changed the default behavior of the `getFilterOptions` to `usedOnly`
  if no id list is given.
discordier added a commit that referenced this pull request Dec 19, 2018
@discordier
Merge tag '2.0.7'
8a2f88d 
Maintenance release.

Fixes:
- #1256 - Fix warning of undefined constants TL_ASSETS_URL and TL_FILES_URL.
- #1257 - Hide sorting hint in popup widgets.
- #1258, #1234 Frontend filter widgets for simple lookup can now be enabled
  and disabled via a checkbox.
- #1259 - Changed the default behavior of the `getFilterOptions` to `usedOnly`
  if no id list is given.
discordier added a commit that referenced this pull request Dec 19, 2018
@discordier
Merge tag '2.0.7'
e8bd3a3 
Maintenance release.

Fixes:
- #1256 - Fix warning of undefined constants TL_ASSETS_URL and
  TL_FILES_URL.
- #1257 - Hide sorting hint in popup widgets.
- #1258, #1234 Frontend filter widgets for simple lookup can now be
  enabled and disabled via a checkbox.
- #1259 - Changed the default behavior of the `getFilterOptions` to
  `usedOnly` if no id list is given.

Conflicts:
  src/Attribute/BaseSimple.php
@zonky2 zonky2 deleted the hotfix_hide_popup_widget_sort_hint branch January 10, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discordier discordier discordier approved these changes

@baumannsven baumannsven baumannsven approved these changes

Assignees
No one assigned
Labels
enhancement This issue is about an enhancement (aka new feature)
Projects
None yet
Milestone
2.0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@zonky2 @discordier @baumannsven