Skip to content

feat: Unblock wallet_switchEthereumChain #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 15, 2025
Merged

feat: Unblock wallet_switchEthereumChain #2634

merged 16 commits into from
May 15, 2025
+571 −14

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Aug 13, 2024 •
edited
Loading

This removes wallet_switchEthereumChain from the BLOCKED_RPC_METHODS list.

Closes MetaMask/MetaMask-planning#2938.
Closes #2654.

Blocked by:

@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (2dcaecd) to head (03a3b7e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2634   +/-   ##
=======================================
  Coverage   98.07%   98.08%           
=======================================
  Files         398      399    +1     
  Lines       10976    10991   +15     
  Branches     1728     1731    +3     
=======================================
+ Hits        10765    10780   +15     
  Misses        211      211

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz marked this pull request as ready for review August 13, 2024 07:27
@Mrtenz Mrtenz requested a review from a team as a code owner August 13, 2024 07:27
@Mrtenz Mrtenz mentioned this pull request Aug 13, 2024
Draft
7 tasks
@Mrtenz Mrtenz force-pushed the mrtenz/unblock-wallet_switchEthereumChain branch from 2a66d50 to fd11f16 Compare August 21, 2024 11:01
@Mrtenz
Copy link
Member Author

Mrtenz commented Aug 21, 2024

@metamaskbot update-pr

@socket-security Socket Security
Copy link

socket-security bot commented Aug 21, 2024 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@Mrtenz
Copy link
Member Author

Mrtenz commented Aug 21, 2024

@SocketSecurity ignore npm/@metamask/[email protected]

This is ours.

@Mrtenz Mrtenz marked this pull request as draft August 21, 2024 11:36
Mrtenz
Mrtenz commented Aug 21, 2024
View reviewed changes
...ges/snaps-jest/src/internals/simulation/middleware/internal-methods/switch-ethereum-chain.ts Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we could consider full support for wallet_switchEthereumChain, and actually updating the provider configuration etc., but for now this simply makes the wallet_switchEthereumChain method always return null.

@Mrtenz Mrtenz mentioned this pull request Oct 8, 2024
Merged
Mrtenz added a commit that referenced this pull request Oct 8, 2024
@Mrtenz
Add isSnapId utility function (#2808)
a80db22 
This adds a `isSnapId` function which accepts any value, and returns a
boolean if the input is a valid Snap ID or not.

This is extracted from #2634.
@Mrtenz Mrtenz force-pushed the mrtenz/unblock-wallet_switchEthereumChain branch from f2aa83e to 1dcbeda Compare January 15, 2025 11:46
@Mrtenz
Copy link
Member Author

Mrtenz commented Jan 15, 2025

@SocketSecurity ignore npm/[email protected]

Only used for development / testing, and pending update in another PR.

@SocketSecurity ignore npm/@metamask/[email protected]

This is ours.

jiexi
jiexi reviewed Jan 21, 2025
View reviewed changes
packages/examples/packages/ethereum-provider/src/index.ts
@@ -207,6 +223,9 @@ async function signTypedData(message: string, from: string) {
* @see https://docs.metamask.io/snaps/reference/rpc-api/#wallet_invokesnap
*/
export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
const { chainId = '0x1' } = (request.params as BaseParams) ?? {};
await switchChain(chainId);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not a problem, but i think always using mainnet makes it possible in the extension e2e tests that use this snap to try to hit the mainnet infura endpoint, but I think that's probably only the case if something triggers getGasPrice and i'm not certain there is an extension e2e test that does that. Just pointing this out in case I am wrong

@jiexi
Copy link

jiexi commented Jan 21, 2025

sorry, I realize this PR is still marked as draft, so sorry for the early nit comments

@Mrtenz Mrtenz force-pushed the mrtenz/unblock-wallet_switchEthereumChain branch from 736f8f1 to afa3bc5 Compare February 12, 2025 10:49
@Mrtenz Mrtenz force-pushed the mrtenz/unblock-wallet_switchEthereumChain branch from 607162c to 5e27ac2 Compare February 12, 2025 12:54
@Mrtenz Mrtenz marked this pull request as ready for review February 13, 2025 09:34
@Mrtenz Mrtenz force-pushed the mrtenz/unblock-wallet_switchEthereumChain branch from 3612252 to ff78991 Compare February 21, 2025 09:37
@Mrtenz Mrtenz requested a review from FrederikBolding May 14, 2025 15:35
@Mrtenz Mrtenz added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2025
@Mrtenz Mrtenz force-pushed the mrtenz/unblock-wallet_switchEthereumChain branch from 838ce80 to 31ffcbf Compare May 15, 2025 14:16
@Mrtenz Mrtenz requested a review from FrederikBolding May 15, 2025 17:56
@FrederikBolding FrederikBolding added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit da0d581 May 15, 2025
115 checks passed
@FrederikBolding FrederikBolding deleted the mrtenz/unblock-wallet_switchEthereumChain branch May 15, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiexi jiexi jiexi left review comments

@FrederikBolding FrederikBolding FrederikBolding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add wallet_switchEthereumChain support to snaps-jest
3 participants
@Mrtenz @jiexi @FrederikBolding