feat: ledger erc721 e2e tests #34003

dawnseeker8 · 2025-07-01T07:44:35Z

Description

Adds ledger e2e test for ERC-721 flow on test-dapp

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/950

Manual testing steps

Locally:

yarn start:test
# wait for end of build
yarn test:e2e:single test/e2e/tests/hardware-wallets/ledger-erc721.spec.ts

On CI, check e2e tests job

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-07-01T07:44:44Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-07-01T08:07:57Z

Builds ready [3473681]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1219 ± 70 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1219	1095	1563	70	1256	1351
			load	1042	942	1381	65	1072	1152
			domContentLoaded	1034	934	1376	65	1064	1147
			domInteractive	19	14	79	10	17	40
			firstPaint	728	143	1228	396	1051	1136
			backgroundConnect	9	4	51	6	9	27
			firstReactRender	23	18	40	5	24	34
			getState	16	6	34	8	21	29
			initialActions	0	0	1	0	0	1
			loadScripts	825	728	1168	64	849	934
			setupStore	9	5	35	4	9	15
	Webpack	Home	uiStartup	2198	1702	2666	219	2315	2585
			load	1654	1259	2049	187	1764	2002
			domContentLoaded	1648	1254	2037	186	1759	1988
			domInteractive	17	12	64	12	14	51
			firstPaint	165	65	597	81	184	318
			backgroundConnect	27	9	349	46	24	40
			firstReactRender	254	88	417	117	379	404
			getState	12	5	43	6	15	28
			initialActions	2	1	7	1	3	5
			loadScripts	1645	1253	2027	184	1756	1977
			setupStore	16	7	60	8	19	33
Firefox	Browserify	Home	uiStartup	1398	1231	1849	105	1441	1588
			load	1222	1068	1395	77	1272	1358
			domContentLoaded	1222	1068	1394	77	1271	1358
			domInteractive	115	36	346	48	130	183
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	81	12	24	57
			firstReactRender	25	22	51	4	26	36
			getState	12	5	110	16	9	55
			initialActions	0	0	1	0	0	1
			loadScripts	1203	1049	1379	78	1255	1338
			setupStore	14	4	216	33	7	52
	Webpack	Home	uiStartup	1751	1438	3651	309	1835	2302
			load	1495	1249	2938	210	1589	1711
			domContentLoaded	1495	1248	2937	210	1589	1710
			domInteractive	109	59	589	78	98	301
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	53	7	25	38
			firstReactRender	43	35	59	4	45	50
			getState	33	5	1657	165	13	49
			initialActions	1	0	1	1	1	1
			loadScripts	1475	1230	2919	210	1572	1686
			setupStore	16	5	255	35	9	80

Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 27 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 2198 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 255 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2586 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 404 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1978 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 55 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 52 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1751 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1496 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1495 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 33 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1476 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2302 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1711 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1710 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 301 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 49 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1686 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 80 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 560ms | Sum of p95 exceeds: 977ms
Sum of all benchmark exceeds: 1537ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 714 Bytes (0.01%)
ui: 37.27 KiB (0.51%)
common: 830 Bytes (0.01%)

metamaskbot · 2025-07-02T08:16:16Z

Builds ready [6fa66ac]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1189 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1189	1075	1375	62	1231	1295
			load	1015	925	1172	53	1049	1107
			domContentLoaded	1009	919	1167	53	1044	1101
			domInteractive	18	14	55	8	17	39
			firstPaint	702	137	1182	395	1033	1098
			backgroundConnect	8	4	27	3	8	12
			firstReactRender	24	17	53	7	25	39
			getState	15	6	37	8	22	31
			initialActions	0	0	1	0	0	1
			loadScripts	800	710	949	52	834	893
			setupStore	9	5	21	4	9	19
	Webpack	Home	uiStartup	2272	1692	3001	194	2343	2657
			load	1752	1231	2154	163	1827	2048
			domContentLoaded	1746	1227	2143	162	1820	2035
			domInteractive	19	12	112	17	14	64
			firstPaint	161	61	374	65	202	283
			backgroundConnect	21	10	83	10	26	35
			firstReactRender	230	89	417	110	368	401
			getState	16	4	306	31	16	36
			initialActions	2	1	6	1	3	4
			loadScripts	1741	1225	2132	160	1811	2024
			setupStore	19	7	326	32	20	34
Firefox	Browserify	Home	uiStartup	1448	1259	1960	134	1496	1753
			load	1261	1090	1560	96	1318	1459
			domContentLoaded	1260	1090	1560	96	1318	1459
			domInteractive	120	37	395	68	128	343
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	13	159	23	27	94
			firstReactRender	27	23	54	5	29	42
			getState	15	6	199	24	10	54
			initialActions	0	0	1	0	0	1
			loadScripts	1237	1073	1545	95	1304	1407
			setupStore	10	4	157	17	8	26
	Webpack	Home	uiStartup	1791	1476	2484	223	1874	2300
			load	1540	1277	2203	181	1645	1941
			domContentLoaded	1539	1277	2202	181	1645	1941
			domInteractive	119	41	716	101	100	334
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	17	139	16	29	53
			firstReactRender	45	32	62	5	47	54
			getState	12	5	50	9	11	35
			initialActions	0	0	2	1	1	1
			loadScripts	1514	1247	2174	180	1620	1899
			setupStore	13	5	202	23	10	35

Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2272 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1753 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1747 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1742 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2658 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2048 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2036 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 65 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2025 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1449 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1261 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1261 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 121 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1238 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1753 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 343 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 94 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 54 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1791 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1540 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1540 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 119 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1515 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2300 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1941 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1941 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 334 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 53 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 54 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 35 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1899 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 35 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 1003ms | Sum of p95 exceeds: 2036ms
Sum of all benchmark exceeds: 3039ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -101.98 KiB (-1.85%)
ui: 85.78 KiB (1.18%)
common: 151.09 KiB (1.79%)

…are wallet

metamaskbot · 2025-07-03T09:15:49Z

Builds ready [cdbf1a6]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1205 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1205	1070	1394	71	1250	1340
			load	1028	915	1202	66	1064	1170
			domContentLoaded	1020	896	1196	66	1056	1162
			domInteractive	18	13	150	14	17	33
			firstPaint	651	80	1208	414	1046	1156
			backgroundConnect	10	4	36	6	9	25
			firstReactRender	24	17	47	7	24	41
			getState	15	6	31	7	21	28
			initialActions	0	0	1	0	0	1
			loadScripts	814	698	975	64	850	939
			setupStore	9	6	40	5	9	18
	Webpack	Home	uiStartup	2228	1735	2777	209	2361	2666
			load	1688	1276	2062	185	1810	2009
			domContentLoaded	1678	1271	2049	181	1801	1974
			domInteractive	19	12	109	16	15	62
			firstPaint	161	64	321	62	201	284
			backgroundConnect	33	10	365	56	26	52
			firstReactRender	233	91	418	122	380	404
			getState	18	4	324	41	15	34
			initialActions	2	1	14	1	2	4
			loadScripts	1674	1270	2037	180	1798	1962
			setupStore	20	7	275	35	18	28
Firefox	Browserify	Home	uiStartup	1425	1204	1925	135	1487	1729
			load	1250	1076	1583	99	1324	1409
			domContentLoaded	1250	1076	1583	99	1324	1408
			domInteractive	117	35	448	71	119	321
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	151	19	23	46
			firstReactRender	25	21	51	4	26	32
			getState	13	4	191	21	9	46
			initialActions	0	0	1	0	0	1
			loadScripts	1230	1061	1559	96	1306	1392
			setupStore	12	4	212	25	9	52
	Webpack	Home	uiStartup	1690	1447	2468	201	1794	2132
			load	1451	1242	1933	155	1557	1740
			domContentLoaded	1450	1242	1933	155	1556	1740
			domInteractive	107	64	415	68	98	295
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	15	263	25	26	46
			firstReactRender	45	33	66	5	48	53
			getState	14	6	178	21	11	33
			initialActions	1	0	1	0	1	1
			loadScripts	1428	1216	1910	155	1534	1719
			setupStore	11	5	103	12	9	31

Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2229 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2666 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 404 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1426 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1251 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1250 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 118 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1231 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1729 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 321 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 46 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 52 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1691 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1451 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1451 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1429 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2132 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1740 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1740 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 295 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 53 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1719 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 394ms | Sum of p95 exceeds: 1094ms
Sum of all benchmark exceeds: 1488ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 33 Bytes (0%)
ui: 0 Bytes (0%)
common: 15 Bytes (0%)

dawnseeker8 added the team-hardware-wallets label Jul 1, 2025

Akaryatrh and others added 4 commits July 3, 2025 10:49

feat: add ledger e2e tests for ERC-721 deployment

6ca4026

feat: add balance validation

b51e7eb

feat: add end-to-end test for minting ERC-721 token with Ledger hardw…

ed15261

…are wallet

Migrate to one test.

cdbf1a6

Akaryatrh force-pushed the feat/ledger-erc721-mint-2etest branch from 6fa66ac to cdbf1a6 Compare July 3, 2025 08:49

Akaryatrh changed the title ~~feat: ledger erc721 mint e2e tests~~ feat: ledger erc721 e2e tests Jul 3, 2025

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 3, 2025

Akaryatrh mentioned this pull request Jul 3, 2025

feat: add ledger e2e tests for ERC-721 deployment #33972

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: ledger erc721 e2e tests #34003

feat: ledger erc721 e2e tests #34003

dawnseeker8 commented Jul 1, 2025 •

edited by Akaryatrh

Loading

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

metamaskbot commented Jul 1, 2025

Uh oh!

metamaskbot commented Jul 2, 2025

Uh oh!

metamaskbot commented Jul 3, 2025

Uh oh!

Uh oh!

feat: ledger erc721 e2e tests #34003

Are you sure you want to change the base?

feat: ledger erc721 e2e tests #34003

Conversation

dawnseeker8 commented Jul 1, 2025 • edited by Akaryatrh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

metamaskbot commented Jul 1, 2025

Uh oh!

metamaskbot commented Jul 2, 2025

Uh oh!

metamaskbot commented Jul 3, 2025

Uh oh!

Uh oh!

dawnseeker8 commented Jul 1, 2025 •

edited by Akaryatrh

Loading