feat: hide accounts #33790

gantunesr · 2025-06-20T02:18:59Z

Description

Adds support for "hidden account" in the new multichain accounts menu

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-249

Manual testing steps

Enable multichain accounts state 1
Go to the accounts menu
Hide/show accounts

Screenshots/Recordings

Before

Not applicable

After

Screen.Recording.2025-06-19.at.11.44.46.PM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Add some UI updates Update account list menu UI Fix import issue Remove old account selector files Add small refactoring changes Add MultichainAccountsTree component Add use of MultichainAccountsTree inside MultichainAccountListMenu Refactor location for multichain accounts components Add some refactoring for Multichain Accounts Tree Refactor some things in Multichain Accounts Menu after moving files Add some refactoring for the menu Add some preparations for connections

…k/metamask-extension into MUL-248/gar/pin-account

github-actions · 2025-06-20T02:19:06Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…into MUL-249/gar/hide-accounts

metamaskbot · 2025-06-20T02:22:58Z

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (3 files, +81 -48)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 account-list-menu/
      - 📄 hidden-account-list.js +1 -1
  - 📁 multichain-accounts/
    - 📁 multichain-accounts-tree/
      - 📄 multichain-accounts-tree.tsx +50 -31
- 📁 selectors/
  - 📁 multichain-accounts/
    - 📄 account-tree.ts +30 -16

🖥️ @MetaMask/wallet-ux (1 files, +1 -1)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 account-list-menu/
      - 📄 hidden-account-list.js +1 -1

metamaskbot · 2025-06-20T02:35:27Z

❌ test-e2e-chrome-api-specs failed. View the html report here.

metamaskbot · 2025-06-20T02:44:39Z

Builds ready [67d6732]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1214 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1214	1093	1460	59	1243	1320
			load	1052	938	1269	57	1084	1146
			domContentLoaded	1045	932	1265	57	1076	1139
			domInteractive	17	13	42	6	16	38
			firstPaint	695	82	1188	419	1062	1127
			backgroundConnect	7	4	29	3	8	9
			firstReactRender	22	16	41	5	23	35
			getState	13	6	30	7	18	26
			initialActions	0	0	1	0	0	1
			loadScripts	800	696	1007	55	828	885
			setupStore	9	5	31	4	8	16
	Webpack	Home	uiStartup	2172	1698	2697	219	2297	2616
			load	1662	1256	2071	200	1772	1988
			domContentLoaded	1654	1252	2065	198	1764	1984
			domInteractive	17	11	70	12	14	54
			firstPaint	187	63	1981	198	187	333
			backgroundConnect	25	10	295	38	23	36
			firstReactRender	213	88	413	115	362	405
			getState	14	4	319	31	12	28
			initialActions	2	1	7	1	3	4
			loadScripts	1651	1250	2055	197	1761	1975
			setupStore	23	7	323	51	18	31
Firefox	Browserify	Home	uiStartup	1324	1172	1743	109	1356	1580
			load	1161	1037	1492	78	1208	1297
			domContentLoaded	1160	1037	1491	78	1207	1297
			domInteractive	106	34	330	57	106	277
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	88	13	21	52
			firstReactRender	24	21	55	4	24	28
			getState	10	4	121	15	8	29
			initialActions	0	0	2	0	0	1
			loadScripts	1143	1024	1449	76	1187	1277
			setupStore	9	4	75	10	10	26
	Webpack	Home	uiStartup	1563	1329	2139	183	1642	2066
			load	1354	1142	1847	157	1449	1747
			domContentLoaded	1354	1142	1847	157	1448	1747
			domInteractive	97	30	456	68	90	273
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	51	6	22	36
			firstReactRender	40	32	52	4	42	45
			getState	11	6	55	9	10	30
			initialActions	1	0	2	1	1	1
			loadScripts	1336	1125	1827	156	1432	1728
			setupStore	9	5	103	11	8	26

Benchmark value 2617 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 405 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1975 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 277 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 2066 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1747 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1747 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 273 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1728 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 2ms | Sum of p95 exceeds: 810ms
Sum of all benchmark exceeds: 812ms

Bundle size diffs

background: 0 Bytes (0%)
ui: 1.16 KiB (0.02%)
common: 0 Bytes (0%)

metamaskbot · 2025-06-20T04:12:00Z

Builds ready [2b14a9f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1205 ± 51 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1205	1117	1356	51	1240	1295
			load	1042	954	1186	47	1066	1126
			domContentLoaded	1036	946	1157	46	1060	1119
			domInteractive	17	14	57	7	16	37
			firstPaint	722	89	1202	414	1060	1127
			backgroundConnect	7	4	34	4	7	13
			firstReactRender	20	16	47	3	21	23
			getState	13	6	31	7	19	29
			initialActions	0	0	1	0	0	1
			loadScripts	790	695	914	45	813	873
			setupStore	8	4	18	2	8	14
	Webpack	Home	uiStartup	2212	1697	2933	216	2304	2650
			load	1683	1292	2097	169	1759	1979
			domContentLoaded	1674	1289	2085	167	1752	1966
			domInteractive	17	12	72	13	14	55
			firstPaint	168	66	583	81	203	290
			backgroundConnect	26	10	303	38	23	37
			firstReactRender	235	89	485	116	364	412
			getState	11	4	33	6	13	25
			initialActions	9	1	305	42	3	5
			loadScripts	1671	1287	2076	166	1750	1964
			setupStore	21	7	316	42	19	29
Firefox	Browserify	Home	uiStartup	1349	1204	1691	105	1395	1599
			load	1187	1043	1468	83	1235	1344
			domContentLoaded	1187	1042	1468	83	1235	1343
			domInteractive	111	35	370	52	120	208
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	83	9	21	37
			firstReactRender	24	21	57	5	24	29
			getState	10	4	82	11	9	26
			initialActions	0	0	1	0	0	1
			loadScripts	1169	1027	1441	83	1212	1329
			setupStore	8	4	77	9	7	20
	Webpack	Home	uiStartup	1581	1391	2304	178	1660	2031
			load	1361	1194	2062	153	1461	1651
			domContentLoaded	1360	1194	2062	152	1461	1651
			domInteractive	96	31	491	74	89	296
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	45	5	23	32
			firstReactRender	42	32	52	4	44	48
			getState	12	6	114	13	10	34
			initialActions	0	0	2	1	1	1
			loadScripts	1341	1178	2038	152	1445	1629
			setupStore	11	5	103	15	8	34

Benchmark value 2213 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 236 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2650 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 412 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 208 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 2031 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 296 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 30ms | Sum of p95 exceeds: 497ms
Sum of all benchmark exceeds: 527ms

Bundle size diffs

background: 0 Bytes (0%)
ui: 413 Bytes (0.01%)
common: 0 Bytes (0%)

…into MUL-249/gar/hide-accounts

…sk/metamask-extension into MUL-249/gar/hide-accounts

metamaskbot · 2025-06-20T22:29:29Z

Builds ready [b5c3ad8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1233 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1233	1110	1396	60	1273	1336
			load	1066	960	1227	57	1109	1147
			domContentLoaded	1059	954	1215	56	1102	1140
			domInteractive	18	14	44	7	17	40
			firstPaint	744	165	1190	405	1077	1137
			backgroundConnect	7	4	15	2	8	10
			firstReactRender	20	16	50	4	21	24
			getState	14	6	31	7	20	26
			initialActions	0	0	1	0	0	1
			loadScripts	810	704	959	55	852	889
			setupStore	8	5	20	3	8	14
	Webpack	Home	uiStartup	2228	1706	2927	225	2343	2660
			load	1695	1259	2266	190	1791	1985
			domContentLoaded	1689	1255	2255	188	1783	1973
			domInteractive	19	11	179	22	14	69
			firstPaint	171	66	602	80	185	323
			backgroundConnect	21	10	41	6	24	34
			firstReactRender	248	92	425	116	380	406
			getState	12	4	41	7	14	30
			initialActions	3	1	6	1	3	4
			loadScripts	1686	1254	2243	187	1782	1962
			setupStore	23	7	282	45	19	29
Firefox	Browserify	Home	uiStartup	1349	1195	1827	111	1394	1617
			load	1183	1049	1560	79	1238	1310
			domContentLoaded	1183	1049	1560	79	1238	1310
			domInteractive	114	35	389	61	121	306
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	55	7	21	33
			firstReactRender	24	21	50	3	24	28
			getState	10	5	69	11	9	38
			initialActions	0	0	1	0	0	1
			loadScripts	1165	1035	1545	78	1221	1295
			setupStore	9	4	81	12	7	28
	Webpack	Home	uiStartup	1579	1380	2127	167	1660	1976
			load	1364	1189	1832	137	1455	1640
			domContentLoaded	1364	1189	1832	137	1455	1640
			domInteractive	95	32	317	59	91	283
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	50	6	22	36
			firstReactRender	40	31	50	3	43	46
			getState	12	6	42	8	10	33
			initialActions	0	0	2	1	1	1
			loadScripts	1345	1168	1812	138	1437	1623
			setupStore	9	5	62	8	8	28

Benchmark value 2229 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 248 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2660 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 69 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 406 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 306 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 38 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1976 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 283 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState
Sum of mean exceeds: 58ms | Sum of p95 exceeds: 549ms
Sum of all benchmark exceeds: 607ms

Bundle size diffs

background: 0 Bytes (0%)
ui: 430 Bytes (0.01%)
common: 0 Bytes (0%)

david0xd and others added 20 commits June 13, 2025 16:26

Add implementation for connection indicator

ad8e808

chore: lint

839bc90

test: fix mock paths

0f38c15

feat: pin accounts

b562fcb

Merge branch 'main' into dd/add-account-groups-ui

53635c9

refactor: use new AccountMenu wrapper

7062801

test: re-adapt tests

d8d822f

fix: fix code fences

1b176c3

fix: fix storybook

e1fb79d

Merge branch 'main' into dd/add-account-groups-ui

1b6d0df

chore: rename selectors

89e147e

chore: rename list -> tree

60c95f8

refactor: re-use existing selector + flip expression

4bd2266

fix: fix invalid import

1c9e69a

chore: lint

4130032

Merge branch 'main' into dd/add-account-groups-ui

2463d29

Merge branch 'dd/add-account-groups-ui' of https://github.com/MetaMas…

90c4c4e

…k/metamask-extension into MUL-248/gar/pin-account

refactor: MultichainAccountsTree

0e89fde

feat: hide accounts

ded49a9

Merge branch 'main' of https://github.com/MetaMask/metamask-extension …

67d6732

…into MUL-249/gar/hide-accounts

metamaskbot added the team-accounts label Jun 20, 2025

gantunesr added 2 commits June 19, 2025 23:44

feat: add hidden account section

b0bb6f0

Merge branch 'main' into MUL-249/gar/hide-accounts

2b14a9f

gantunesr marked this pull request as ready for review June 20, 2025 03:48

gantunesr requested a review from a team as a code owner June 20, 2025 03:48

gantunesr self-assigned this Jun 20, 2025

gantunesr added 6 commits June 20, 2025 17:54

Merge branch 'main' of https://github.com/MetaMask/metamask-extension …

a56d220

…into MUL-249/gar/hide-accounts

chore: revert changes to HiddenAccountList

d56cd3c

Merge branch 'MUL-249/gar/hide-accounts' of https://github.com/MetaMa…

cbf611f

…sk/metamask-extension into MUL-249/gar/hide-accounts

chore: revert changes to HiddenAccountList

eb66bf3

chore: revert changes to HiddenAccountList

65a516b

chore: set hidden to true

b5c3ad8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: hide accounts #33790

feat: hide accounts #33790

gantunesr commented Jun 20, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 20, 2025

Uh oh!

metamaskbot commented Jun 20, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Jun 20, 2025

Uh oh!

metamaskbot commented Jun 20, 2025

Uh oh!

metamaskbot commented Jun 20, 2025

Uh oh!

metamaskbot commented Jun 20, 2025

Uh oh!

Uh oh!

feat: hide accounts #33790

Are you sure you want to change the base?

feat: hide accounts #33790

Conversation

gantunesr commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 20, 2025

Uh oh!

metamaskbot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Jun 20, 2025

Uh oh!

metamaskbot commented Jun 20, 2025

Uh oh!

metamaskbot commented Jun 20, 2025

Uh oh!

metamaskbot commented Jun 20, 2025

Uh oh!

Uh oh!

gantunesr commented Jun 20, 2025 •

edited

Loading

metamaskbot commented Jun 20, 2025 •

edited

Loading