feat: poll incoming transactions only when viewing transaction list #33783

matthewwalsh0 · 2025-06-19T19:56:22Z

Description

Poll incoming transactions from the accounts API only when viewing the transaction list.

Continue to stop polling when closing all popups as a safety measure.

Related issues

Fixes: #5190

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-06-19T19:58:26Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (1 files, +4 -0)

📁 app/
- 📁 scripts/
  - 📁 controller-init/
    - 📁 confirmations/
      - 📄 transaction-controller-init.ts +4 -0

metamaskbot · 2025-06-19T20:19:27Z

Builds ready [7c760eb]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1231 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1231	1076	1424	60	1280	1320
			load	1064	945	1176	56	1106	1159
			domContentLoaded	1058	940	1165	56	1099	1154
			domInteractive	18	13	61	7	17	37
			firstPaint	753	98	1163	415	1092	1140
			backgroundConnect	7	4	31	4	7	11
			firstReactRender	23	17	46	6	24	39
			getState	14	6	31	7	20	26
			initialActions	0	0	1	0	0	1
			loadScripts	812	700	916	54	853	903
			setupStore	8	5	21	3	8	15
	Webpack	Home	uiStartup	2157	1654	2643	216	2285	2567
			load	1654	1236	2052	183	1772	1943
			domContentLoaded	1649	1232	2048	182	1768	1932
			domInteractive	17	11	74	12	14	53
			firstPaint	172	69	480	79	208	355
			backgroundConnect	19	10	42	6	23	32
			firstReactRender	218	90	409	115	360	399
			getState	14	4	308	30	12	26
			initialActions	2	1	5	1	3	4
			loadScripts	1646	1230	2038	181	1767	1921
			setupStore	20	7	296	39	16	26
Firefox	Browserify	Home	uiStartup	1334	1151	1928	114	1372	1550
			load	1171	1018	1558	80	1213	1325
			domContentLoaded	1171	1018	1558	80	1213	1324
			domInteractive	112	36	512	77	107	203
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	139	14	20	40
			firstReactRender	24	20	54	5	24	28
			getState	10	5	66	10	8	39
			initialActions	0	0	1	0	0	1
			loadScripts	1154	1004	1542	79	1195	1304
			setupStore	9	4	83	13	6	35
	Webpack	Home	uiStartup	1629	1428	2213	178	1728	2038
			load	1405	1224	1902	157	1523	1674
			domContentLoaded	1405	1224	1902	157	1523	1674
			domInteractive	98	32	332	65	94	306
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	77	7	23	33
			firstReactRender	43	32	54	4	46	50
			getState	11	6	49	7	10	29
			initialActions	1	0	2	1	1	1
			loadScripts	1385	1204	1872	157	1503	1657
			setupStore	11	6	43	7	11	30

Benchmark value 2568 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 355 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 399 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 203 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1629 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1406 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1405 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1385 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2038 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1674 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1674 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 306 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1657 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 99ms | Sum of p95 exceeds: 505ms
Sum of all benchmark exceeds: 604ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 69.34 KiB (1.31%)
ui: 19.46 KiB (0.27%)
common: 43.84 KiB (0.53%)

socket-security · 2025-06-19T21:46:37Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/transaction-controller@57.4.0 ⏵ 58.0.0-preview-08a4995	⁺⁴		⁺²²	⁺¹

View full report

metamaskbot · 2025-06-19T22:09:09Z

Builds ready [ef5293a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1262 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1262	1158	1578	66	1305	1364
			load	1090	967	1375	65	1134	1194
			domContentLoaded	1083	962	1354	64	1128	1188
			domInteractive	18	14	84	8	17	31
			firstPaint	849	167	1366	404	1109	1183
			backgroundConnect	8	4	29	4	7	20
			firstReactRender	21	17	38	3	22	25
			getState	14	6	34	7	20	26
			initialActions	0	0	1	0	0	1
			loadScripts	833	712	1092	63	875	937
			setupStore	9	5	24	4	8	18
	Webpack	Home	uiStartup	2087	1649	2579	219	2205	2517
			load	1587	1247	1993	184	1692	1895
			domContentLoaded	1581	1243	1988	183	1688	1885
			domInteractive	16	11	61	11	13	50
			firstPaint	172	63	374	66	218	313
			backgroundConnect	19	12	38	5	21	29
			firstReactRender	231	87	431	117	378	397
			getState	10	4	31	5	11	21
			initialActions	2	1	5	1	3	4
			loadScripts	1579	1242	1978	182	1687	1875
			setupStore	14	7	33	4	15	22
Firefox	Browserify	Home	uiStartup	1424	1250	1934	115	1469	1667
			load	1249	1084	1596	87	1309	1404
			domContentLoaded	1249	1084	1596	87	1309	1404
			domInteractive	121	37	535	71	130	191
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	15	124	16	25	50
			firstReactRender	25	22	36	3	25	30
			getState	12	4	98	15	9	33
			initialActions	0	0	1	0	0	1
			loadScripts	1227	1062	1575	88	1284	1383
			setupStore	9	4	80	13	7	22
	Webpack	Home	uiStartup	1536	1352	2229	183	1613	2013
			load	1327	1172	1949	156	1416	1665
			domContentLoaded	1327	1172	1948	156	1416	1664
			domInteractive	92	32	480	67	84	274
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	126	12	23	31
			firstReactRender	40	31	49	3	42	45
			getState	10	5	31	6	10	29
			initialActions	0	0	2	1	1	1
			loadScripts	1307	1148	1927	154	1399	1646
			setupStore	10	5	47	7	9	31

Benchmark value 1262 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1091 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1084 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 850 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 833 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1195 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1189 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2517 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 397 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1424 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1249 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1249 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 122 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1667 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 33 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 2013 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1665 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1664 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 274 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1646 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 175ms | Sum of p95 exceeds: 352ms
Sum of all benchmark exceeds: 527ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -490 Bytes (-0.01%)
ui: 549 Bytes (0.01%)
common: -1.49 KiB (-0.02%)

metamaskbot · 2025-06-19T23:46:55Z

Builds ready [68f9be4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1236 ± 74 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1236	1113	1490	74	1270	1372
			load	1064	921	1314	72	1097	1205
			domContentLoaded	1057	913	1308	71	1090	1199
			domInteractive	18	14	47	7	17	38
			firstPaint	748	141	1315	413	1075	1150
			backgroundConnect	7	4	46	5	8	13
			firstReactRender	24	16	147	14	23	46
			getState	13	6	38	7	19	26
			initialActions	0	0	1	0	0	1
			loadScripts	808	670	1064	72	836	950
			setupStore	9	5	29	5	9	21
	Webpack	Home	uiStartup	2126	1660	2641	217	2249	2537
			load	1608	1236	1970	183	1716	1943
			domContentLoaded	1602	1232	1959	182	1712	1935
			domInteractive	17	11	76	13	13	52
			firstPaint	172	62	609	76	205	313
			backgroundConnect	22	12	234	22	25	35
			firstReactRender	243	89	557	129	384	423
			getState	11	4	46	7	12	24
			initialActions	3	1	6	1	3	5
			loadScripts	1599	1230	1949	180	1709	1925
			setupStore	23	7	309	50	17	27
Firefox	Browserify	Home	uiStartup	1365	1170	1765	116	1400	1661
			load	1198	1041	1504	84	1254	1363
			domContentLoaded	1198	1040	1503	84	1254	1363
			domInteractive	116	35	425	63	132	266
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	13	151	21	23	69
			firstReactRender	24	20	41	3	25	31
			getState	10	5	76	10	9	24
			initialActions	0	0	1	0	0	1
			loadScripts	1178	1027	1486	81	1229	1324
			setupStore	8	4	66	9	7	18
	Webpack	Home	uiStartup	1568	1367	2164	175	1658	1944
			load	1357	1164	1824	145	1458	1597
			domContentLoaded	1356	1163	1823	145	1457	1597
			domInteractive	91	32	523	58	88	189
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	42	5	22	34
			firstReactRender	40	31	47	3	43	46
			getState	10	5	42	7	10	30
			initialActions	0	0	2	1	1	1
			loadScripts	1338	1148	1797	144	1441	1579
			setupStore	10	5	105	13	8	40

Benchmark value 1236 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 1372 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1205 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1199 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 46 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 950 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 21 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 243 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2538 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 423 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 1661 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 266 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1944 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 189 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 40 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 20ms | Sum of p95 exceeds: 319ms
Sum of all benchmark exceeds: 339ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -415 Bytes (-0.01%)
ui: 1.29 KiB (0.02%)
common: 35.99 KiB (0.43%)

metamaskbot · 2025-06-20T11:00:40Z

Builds ready [90a93ed]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1252 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1252	1120	1476	65	1293	1365
			load	1079	972	1313	63	1112	1191
			domContentLoaded	1072	967	1306	63	1106	1182
			domInteractive	18	14	45	6	17	30
			firstPaint	755	73	1194	424	1096	1148
			backgroundConnect	7	4	28	4	7	19
			firstReactRender	22	17	38	5	22	35
			getState	15	6	33	7	20	27
			initialActions	0	0	1	0	0	1
			loadScripts	822	717	1051	61	860	937
			setupStore	8	5	22	3	8	18
	Webpack	Home	uiStartup	2153	1643	2675	208	2253	2579
			load	1649	1229	2067	179	1731	1989
			domContentLoaded	1640	1226	2062	174	1728	1972
			domInteractive	17	12	62	12	13	54
			firstPaint	169	64	471	70	191	325
			backgroundConnect	22	11	291	28	23	33
			firstReactRender	230	91	413	117	380	401
			getState	10	4	34	5	11	19
			initialActions	3	1	6	1	3	4
			loadScripts	1638	1224	2052	172	1726	1962
			setupStore	19	7	315	41	16	24
Firefox	Browserify	Home	uiStartup	1372	1174	1791	117	1419	1685
			load	1205	1042	1596	94	1260	1380
			domContentLoaded	1205	1041	1595	94	1260	1380
			domInteractive	112	35	411	56	117	252
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	100	13	22	45
			firstReactRender	24	21	53	4	25	30
			getState	10	5	86	13	8	32
			initialActions	0	0	1	0	0	1
			loadScripts	1186	1029	1510	89	1242	1354
			setupStore	10	4	72	12	7	34
	Webpack	Home	uiStartup	1545	1338	2158	181	1619	2030
			load	1333	1150	1847	157	1418	1779
			domContentLoaded	1333	1150	1847	157	1418	1779
			domInteractive	89	31	351	60	81	273
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	71	8	23	35
			firstReactRender	40	31	47	3	43	46
			getState	13	5	106	13	10	32
			initialActions	0	0	2	1	1	1
			loadScripts	1314	1132	1827	155	1403	1747
			setupStore	9	5	36	5	8	19

Benchmark value 1252 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1080 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1073 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1191 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1183 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 19 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2579 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1685 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 252 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 2030 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1779 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1779 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 273 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1747 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 46ms | Sum of p95 exceeds: 826ms
Sum of all benchmark exceeds: 872ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.82 KiB (-0.03%)
ui: 9.9 KiB (0.14%)
common: 36.9 KiB (0.44%)

metamaskbot · 2025-06-20T12:35:09Z

Builds ready [da08ee9]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1220 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1220	1097	1421	66	1257	1368
			load	1052	923	1240	65	1095	1179
			domContentLoaded	1044	907	1235	66	1083	1174
			domInteractive	17	14	59	6	17	30
			firstPaint	676	138	1242	424	1066	1134
			backgroundConnect	10	4	37	7	8	29
			firstReactRender	21	16	60	5	22	27
			getState	14	5	37	7	19	26
			initialActions	0	0	1	0	0	1
			loadScripts	798	653	981	65	836	921
			setupStore	8	5	27	4	8	19
	Webpack	Home	uiStartup	2301	1788	2949	216	2405	2696
			load	1764	1329	2198	181	1863	2035
			domContentLoaded	1757	1325	2181	180	1858	2030
			domInteractive	17	12	83	13	14	48
			firstPaint	178	64	649	95	197	386
			backgroundConnect	23	11	78	10	25	40
			firstReactRender	240	90	424	107	364	403
			getState	13	5	56	9	16	28
			initialActions	3	1	7	1	3	5
			loadScripts	1754	1323	2169	178	1857	2028
			setupStore	19	7	183	18	23	35
Firefox	Browserify	Home	uiStartup	1344	1199	1755	108	1381	1627
			load	1180	1063	1401	72	1231	1303
			domContentLoaded	1180	1063	1401	72	1230	1303
			domInteractive	111	34	473	66	111	178
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	107	13	21	46
			firstReactRender	23	21	34	2	23	27
			getState	10	5	93	13	9	28
			initialActions	0	0	1	0	0	1
			loadScripts	1162	1051	1384	72	1217	1287
			setupStore	10	4	118	15	9	33
	Webpack	Home	uiStartup	1558	1370	2053	176	1638	2013
			load	1350	1162	1821	151	1436	1676
			domContentLoaded	1350	1162	1820	151	1435	1675
			domInteractive	95	30	373	65	89	287
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	71	8	22	40
			firstReactRender	40	30	52	4	43	47
			getState	10	5	33	5	10	22
			initialActions	0	0	2	1	1	1
			loadScripts	1331	1147	1800	150	1417	1659
			setupStore	9	5	105	11	8	21

Benchmark value 1368 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 29 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2302 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1764 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1758 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 240 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 1755 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2696 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2035 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2031 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 387 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2029 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 2013 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1676 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1675 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 287 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1659 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 283ms | Sum of p95 exceeds: 713ms
Sum of all benchmark exceeds: 996ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -4.22 KiB (-0.08%)
ui: 13.29 KiB (0.18%)
common: 38.35 KiB (0.46%)

metamaskbot added the team-confirmations Push issues to confirmations team label Jun 19, 2025

matthewwalsh0 added 3 commits June 19, 2025 22:43

Poll incoming transactions only when transaction list visible

6bec0e6

Add unit tests

bb2b460

Use preview build

ef5293a

matthewwalsh0 force-pushed the feat/incoming-transaction-polling-activity-only branch from f119b59 to ef5293a Compare June 19, 2025 21:45

Fix unit tests

68f9be4

Fix unit tests

90a93ed

Fix E2E tests

da08ee9

matthewwalsh0 marked this pull request as ready for review June 20, 2025 15:10

matthewwalsh0 requested a review from a team as a code owner June 20, 2025 15:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: poll incoming transactions only when viewing transaction list #33783

feat: poll incoming transactions only when viewing transaction list #33783

matthewwalsh0 commented Jun 19, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Jun 19, 2025

Uh oh!

metamaskbot commented Jun 19, 2025

Uh oh!

socket-security bot commented Jun 19, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Jun 19, 2025

Uh oh!

metamaskbot commented Jun 19, 2025

Uh oh!

metamaskbot commented Jun 20, 2025

Uh oh!

metamaskbot commented Jun 20, 2025

Uh oh!

Uh oh!

feat: poll incoming transactions only when viewing transaction list #33783

Are you sure you want to change the base?

feat: poll incoming transactions only when viewing transaction list #33783

Conversation

matthewwalsh0 commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Jun 19, 2025

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Jun 19, 2025

Uh oh!

socket-security bot commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Jun 19, 2025

Uh oh!

metamaskbot commented Jun 19, 2025

Uh oh!

metamaskbot commented Jun 20, 2025

Uh oh!

metamaskbot commented Jun 20, 2025

Uh oh!

Uh oh!

matthewwalsh0 commented Jun 19, 2025 •

edited

Loading

socket-security bot commented Jun 19, 2025 •

edited

Loading