-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: snap confirmation queue #33040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: snap confirmation queue #33040
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations
🫰 @MetaMask/snaps-devs
🖥️ @MetaMask/wallet-ux
|
@@ -128,8 +121,30 @@ export function navigateToConfirmation( | |||
return; | |||
} | |||
|
|||
if (CONNECT_APPROVAL_TYPES.includes(type)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an extra render for no reason, since we know the approval type, we can navigate directly to the appropriate snap page.
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
Nav
component. State was added to track the current snap approval that's being viewed. The last current snap in approval flow will be the snap who's next approval we will want to navigate to. State was also added to track a snap's connect times to reorder navigations in the confirmation queue (we want to maintain the position in the queue as we go from snap-connect -> snap-install -> snap-install-result or from snap-update -> snap-install-result).NOTE: This requires an update in the approval controller & controller-utils side, so the new packages will have to be cut and integrated before this PR can be merged.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist