-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat(INFRA-2571): add max pr line checker #33020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
makemesteaks
wants to merge
6
commits into
main
Choose a base branch
from
infra-2571-max-pr-lines
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6c4927
to
492697c
Compare
492697c
to
5a84724
Compare
jluque0101
previously approved these changes
May 16, 2025
jluque0101
approved these changes
May 16, 2025
alucardzom
approved these changes
May 16, 2025
Builds ready [9ce9462]
UI Startup Metrics (1205 ± 55 ms)
Benchmark value 1948 exceeds gate value 1935 for firefox webpack home p95 uiStartup Sum of mean exceeds: 0ms | Sum of p95 exceeds: 22ms Sum of all benchmark exceeds: 22ms Bundle size diffs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/MetaMask/MetaMask-planning/issues/3739
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist