Skip to content

feat(INFRA-2571): add max pr line checker #33020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

makemesteaks
Copy link
Member

@makemesteaks makemesteaks commented May 16, 2025

Description

https://github.com/MetaMask/MetaMask-planning/issues/3739

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-dev-ops DevOps team label May 16, 2025
@makemesteaks makemesteaks force-pushed the infra-2571-max-pr-lines branch from f6c4927 to 492697c Compare May 16, 2025 13:38
@makemesteaks makemesteaks force-pushed the infra-2571-max-pr-lines branch from 492697c to 5a84724 Compare May 16, 2025 13:39
jluque0101
jluque0101 previously approved these changes May 16, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [9ce9462]
UI Startup Metrics (1205 ± 55 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1205110213955512361324
load104396212025110721156
domContentLoaded103693911925210661149
domInteractive16132631624
firstPaint67092116742210591141
backgroundConnect84496826
firstReactRender20154352034
getState1463882130
initialActions001001
loadScripts79770793850827908
setupStore85263811
WebpackHomeuiStartup21401713250919222872373
load16611291211715417621862
domContentLoaded16531287211215317541852
domInteractive161182111341
firstPaint1766565282208302
backgroundConnect359358443664
firstReactRender1264241892135333
getState144159161728
initialActions317135
loadScripts16481286211015317501846
setupStore186253252034
FirefoxBrowserifyHomeuiStartup13431164192212713951620
load11861017157411112491405
domContentLoaded11861017157411112481404
domInteractive943920225101140
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2414544522028
firstReactRender25205882454
getState10522822912
initialActions001001
loadScripts11681002155311012281390
setupStore7438569
WebpackHomeuiStartup15281337203915615951948
load13061155173913213901599
domContentLoaded13061155173913213901599
domInteractive78511351682119
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20144452128
firstReactRender34274943544
getState12422226921
initialActions001011
loadScripts12891140172613213711584
setupStore85626811
Benchmark value 27 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 1948 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 22ms
Sum of all benchmark exceeds: 22ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-dev-ops DevOps team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants