chore: Bump Snaps packages #33018
Draft
chore: Bump Snaps packages #33018
+97
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs
📜 @MetaMask/policy-reviewers Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.
🫰 @MetaMask/snaps-devs
🔗 @MetaMask/supply-chain
|
|
@SocketSecurity ignore npm/@metamask/[email protected] This is ours. |
|
@metamaskbot update-policies |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
| @@ -324,14 +324,14 @@ | |||
| "@metamask/rpc-errors": "^7.0.0", | |||
| "@metamask/safe-event-emitter": "^3.1.1", | |||
| "@metamask/scure-bip39": "^2.0.3", | |||
| "@metamask/selected-network-controller": "^19.0.0", | |||
| "@metamask/selected-network-controller": "^22.1.0", | |||
There was a problem hiding this comment.
Do we need to handle any of these breaking changes?
There was a problem hiding this comment.
Doesn't seem like it. 20.0.0 has breaking changes which were reverted in 21.0.0, and the other breaking changes are bumps to @metamask/network-controller.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR adds E2E coverage for `initialConnections` by using the preinstalled example Snap which has had `initialConnections` functionality added and fixes some older E2Es. [](https://codespaces.new/MetaMask/metamask-extension/pull/32954?quickstart=1) ## **Related issues** Fixes: #24718
…32967) ## **Description** (Waiting for a Snap platform release) This PR binds the preference controller `showTestNetworks` property to the `snap_getPreferences` hook. [](https://codespaces.new/MetaMask/metamask-extension/pull/32967?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to test-snaps 2. Use the preferences snap 3. Verify that `showTestnets` is passed along. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/32954?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/32967?quickstart=1){kind=link}
|
@metamaskbot update-policies |
|
No policy changes |
Builds ready [52de4da]
UI Startup Metrics (1230 ± 63 ms)
Benchmark value 2207 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2482 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 1992 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Sum of mean exceeds: 17ms | Sum of p95 exceeds: 57ms Sum of all benchmark exceeds: 74ms Bundle size diffs [🚀 Bundle size reduced!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bumps Snaps packages to the latest versions. Notable changes are:
wallet_switchEthereumChaininside Snaps.onClientRequesthandler.showTestnetsproperty insnap_getPreferences.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist