Skip to content

fix: reject upgrade error code #32957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2025
Merged

fix: reject upgrade error code #32957

merged 3 commits into from
May 16, 2025
+8 −8

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented May 15, 2025 •
edited by github-actions bot
Loading

Description

Bump @metamask/transaction-controller to fix incorrect upgrade rejection error code.

Open in GitHub Codespaces

Related issues

Fixes: #32956

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label May 15, 2025
@matthewwalsh0 matthewwalsh0 marked this pull request as draft May 15, 2025 10:49
@socket-security Socket Security
Copy link

socket-security bot commented May 15, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updated@​metamask/​transaction-controller@​55.0.2 ⏵ 56.1.092 +110079 +1100 +1100

View full report

@matthewwalsh0 matthewwalsh0 mentioned this pull request May 15, 2025
Merged
7 tasks
@metamaskbot
Copy link
Collaborator

Builds ready [f114573]
UI Startup Metrics (1188 ± 57 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1188108613975712121303
load104194812005510631152
domContentLoaded103492611965610541144
domInteractive16132531623
firstPaint69282119641810431135
backgroundConnect84315821
firstReactRender19154351927
getState1363471928
initialActions001001
loadScripts79669794853817909
setupStore85464712
WebpackHomeuiStartup21801735249716422992379
load16871331194713017731879
domContentLoaded16801328193613017651872
domInteractive15125191341
firstPaint1616336458187286
backgroundConnect38132844937180
firstReactRender17954360107295344
getState1345281529
initialActions315145
loadScripts16751326191213117611867
setupStore216295322237
FirefoxBrowserifyHomeuiStartup13551153184611514131577
load12071033164010812631402
domContentLoaded12061032163910812621401
domInteractive1043725739120194
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2413157212151
firstReactRender23205762330
getState11519921928
initialActions002001
loadScripts11861019160610712461387
setupStore74375616
WebpackHomeuiStartup15241338190112015871783
load13051162164810313751503
domContentLoaded13051162164710313751503
domInteractive78351462079134
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22155972240
firstReactRender34285043642
getState85304914
initialActions102111
loadScripts12861146162710313551481
setupStore85737812
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 180 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 98ms
Sum of all benchmark exceeds: 98ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 559 Bytes (0.01%)

DDDDDanica pushed a commit that referenced this pull request May 15, 2025
@matthewwalsh0
fix: cp-12.18.0 reject upgrade error code (#32957) (#32958)
c8c5145 
## **Description**

Manual cherry-pick of #32957 as controller patch required.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32958?quickstart=1)

## **Related issues**

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@matthewwalsh0 matthewwalsh0 force-pushed the fix/reject-upgrade-error-code branch from 04e06f9 to 12c580a Compare May 16, 2025 08:31
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review May 16, 2025 08:32
@matthewwalsh0 matthewwalsh0 enabled auto-merge May 16, 2025 08:55
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue May 16, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [bb35cb1]
UI Startup Metrics (1240 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1240112614826212851339
load107596012215611231156
domContentLoaded106995312155611171149
domInteractive16142531723
firstPaint68891115842910761135
backgroundConnect74253811
firstReactRender20155462034
getState1453681929
initialActions003001
loadScripts82871696555874906
setupStore85182812
WebpackHomeuiStartup22661859265918224062542
load17861404227017418552212
domContentLoaded17791401226417418462208
domInteractive171279121452
firstPaint1796671292192307
backgroundConnect3410389434166
firstReactRender15044352113287330
getState165322321632
initialActions318145
loadScripts17741398226217418432206
setupStore3063175126186
FirefoxBrowserifyHomeuiStartup13421149183513014071627
load11941017156611812561465
domContentLoaded11931016156611812561465
domInteractive983930136105159
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2313199222148
firstReactRender23196062227
getState84577818
initialActions001001
loadScripts11731005154511212291399
setupStore8410412617
WebpackHomeuiStartup16091436205514016741967
load13701221183812914251660
domContentLoaded13701221183712914251660
domInteractive79341431989112
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22165462432
firstReactRender35294843744
getState125255251027
initialActions002111
loadScripts13511199182012914021641
setupStore95838916
cc: @HowardBraham
Benchmark value 1241 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1076 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1070 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 2266 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1786 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1779 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1774 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2543 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2212 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2208 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 2207 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 186 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1967 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1641 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 321ms | Sum of p95 exceeds: 875ms
Sum of all benchmark exceeds: 1196ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 1.56 KiB (0.02%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2025
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue May 16, 2025
@pedronfigueiredo pedronfigueiredo mentioned this pull request May 16, 2025
Closed
7 tasks
Merged via the queue into main with commit 727dd05 May 16, 2025
156 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/reject-upgrade-error-code branch May 16, 2025 11:22
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@cryptotavares cryptotavares cryptotavares approved these changes

Assignees
No one assigned
Labels
release-12.19.0 team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: SendCalls 5792 returns wrong error code for user upgrade rejections
4 participants
@matthewwalsh0 @metamaskbot @pedronfigueiredo @cryptotavares