chore: disable Solana Testnet and Devnet cp-12.18.0 #32678
Merged
+90
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zone-live
previously approved these changes
May 8, 2025
aganglada
previously approved these changes
May 8, 2025
montelaidev
previously approved these changes
May 8, 2025
This reverts commit e1a07e1.
Builds ready [d171ac6]
UI Startup Metrics (1203 ± 65 ms)
Benchmark value 20 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 1475 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1313 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1313 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 1290 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 1769 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1591 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1591 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 60 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 1564 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 1981 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1682 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1682 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 1646 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 278ms | Sum of p95 exceeds: 503ms Sum of all benchmark exceeds: 781ms Bundle size diffs [🚀 Bundle size reduced!]
|
gantunesr
dismissed stale reviews from montelaidev, aganglada, and zone-live
via
102d1ca
Builds ready [289a745]
UI Startup Metrics (1264 ± 80 ms)
Benchmark value 1265 exceeds gate value 1234 for chrome browserify home mean uiStartup Benchmark value 1106 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1099 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 848 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1434 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1253 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1247 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1230 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 35 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 982 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 1963 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1725 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1724 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 57 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 1708 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 127ms | Sum of p95 exceeds: 542ms Sum of all benchmark exceeds: 669ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
zone-live
approved these changes
May 9, 2025
javiergarciavera
approved these changes
May 9, 2025
montelaidev
approved these changes
May 9, 2025
gantunesr
changed the title
runway-github bot
added a commit
that referenced
this pull request
May 9, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/32678?quickstart=1) Disable Solana Testnet and Devnet, this should be enabled back for version 12.20 on stable. Flask can still use this networks ## **Related issues** Fixes: None ## **Manual testing steps** 1. The network list should NOT display Solana Testnet nor Solana Devnet ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img src="https://github.com/user-attachments/assets/7accf7a0-7254-48bd-8eab-2d26526fa57e" width=250 /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
runway-github bot
added a commit
that referenced
this pull request
May 9, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/32678?quickstart=1) Disable Solana Testnet and Devnet, this should be enabled back for version 12.20 on stable. Flask can still use this networks ## **Related issues** Fixes: None ## **Manual testing steps** 1. The network list should NOT display Solana Testnet nor Solana Devnet ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img src="https://github.com/user-attachments/assets/7accf7a0-7254-48bd-8eab-2d26526fa57e" width=250 /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
runway-github bot
pushed a commit
that referenced
this pull request
May 9, 2025
…p-12.18.0 (#32678) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/32678?quickstart=1) Disable Solana Testnet and Devnet, this should be enabled back for version 12.20 on stable. Flask can still use this networks ## **Related issues** Fixes: None ## **Manual testing steps** 1. The network list should NOT display Solana Testnet nor Solana Devnet ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img src="https://github.com/user-attachments/assets/7accf7a0-7254-48bd-8eab-2d26526fa57e" width=250 /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
7 tasks
DDDDDanica
added a commit
that referenced
this pull request
May 11, 2025
](https://codespaces.new/MetaMask/metamask-extension/pull/32678?quickstart=1){kind=link}
…p-12.18.0 (#32755) - chore: disable Solana Testnet and Devnet cp-12.18.0 (#32678) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/32678?quickstart=1) Disable Solana Testnet and Devnet, this should be enabled back for version 12.20 on stable. Flask can still use this networks ## **Related issues** Fixes: None ## **Manual testing steps** 1. The network list should NOT display Solana Testnet nor Solana Devnet ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img src="https://github.com/user-attachments/assets/7accf7a0-7254-48bd-8eab-2d26526fa57e" width=250 /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [e07684a](e07684a) --------- Co-authored-by: Gustavo Antunes <[email protected]> Co-authored-by: dddddanica <[email protected]> Co-authored-by: MetaMask Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable Solana Testnet and Devnet, this should be enabled back for version 12.20 on stable. Flask can still use this networks
Related issues
Fixes: None
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist