Skip to content

fix: patch increase incoming trx polling cp-12.17.2 #32547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cryptotavares
Copy link
Contributor

@cryptotavares cryptotavares commented May 6, 2025

Description

Increase polling interval to 4min to balance increased load to our backend servers due to updating the incoming trx polling behaviour. Now all users will poll, for all networks, as long as they have basic functionality toggled on.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4832

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Increase polling interval to 4min to balance
increased load to our backend servers due to
updating the incoming trx polling behaviour.
Now all users will poll, for all networks, as long
as they have basic functionality toggled on
Copy link
Contributor

github-actions bot commented May 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label May 6, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [42d1b86]
UI Startup Metrics (1257 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1257113714646412951374
load110698413176111501229
domContentLoaded110097913086111461308
domInteractive191480101743
firstPaint685841314456203284
backgroundConnect7420278
firstReactRender20163242129
getState13537779
initialActions001001
loadScripts851746104359889944
setupStore8522379
WebpackHomeuiStartup21511783263117822762414
load17211301229117518072022
domContentLoaded17141293228717418032014
domInteractive171260101444
firstPaint152623055927691
backgroundConnect249112152852
firstReactRender12052353866397
getState11342769
initialActions317135
loadScripts17101290228517118011987
setupStore346397733979
FirefoxBrowserifyHomeuiStartup13851200191711414321635
load1238106815979912931405
domContentLoaded1238106815979912931405
domInteractive10436378389098
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21146782044
firstReactRender24198592533
getState8460689
initialActions005101
loadScripts1219105315819912741389
setupStore6433368
WebpackHomeuiStartup15841420214914116421874
load13721204196613214261608
domContentLoaded13711204196613214251608
domInteractive8938159188996
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22154972442
firstReactRender35296163846
getState9430589
initialActions002111
loadScripts13521188194913214051587
setupStore1253163189

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit d3b4dc9 into Version-v12.17.2 May 6, 2025
163 checks passed
@Gudahtt Gudahtt deleted the fix/increase-incoming-trx-polling-interval-to-4-min branch May 6, 2025 12:30
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2025
@DDDDDanica DDDDDanica changed the title fix: patch increase incoming trx polling fix: patch increase incoming trx polling cp-12.17.2 May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.2 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants