Skip to content

feat: use MetaMask build name for solana cp-12.18.0 (#32356) Cherry-pick #32439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DDDDDanica
Copy link
Contributor

@DDDDDanica DDDDDanica commented May 1, 2025

No matter the build, MetaMask Solana always announced itself with the same name.
Now we’re using the build name.

Description

Cherry-pick: #32356

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4770

Manual testing steps

  1. Build MetaMask Snap
  2. Go this page: https://metamask.github.io/test-dapp-solana/staging/
  3. Click on "Select Wallet"

Screenshots/Recordings

Before

Screenshot 2025-04-28 at 19 04 30 Screenshot 2025-04-28 at 19 28 16 Screenshot 2025-04-28 at 19 28 21 Screenshot 2025-04-28 at 19 29 12

After

Screenshot 2025-04-28 at 21 50 24 Screenshot 2025-04-28 at 21 55 59 Screenshot 2025-04-28 at 21 56 03 Screenshot 2025-04-28 at 21 56 28

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
No matter the build, MetaMask Solana always announced itself with the
same name.
Now we’re using the build name.

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32356?quickstart=1)

## **Related issues**

Fixes: MetaMask/MetaMask-planning#4770

## **Manual testing steps**

1. Build MetaMask Snap
2. Go this page: https://metamask.github.io/test-dapp-solana/staging/
3. Click on "Select Wallet"

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
<img width="431" alt="Screenshot 2025-04-28 at 19 04 30"
src="https://github.com/user-attachments/assets/7685f879-19c6-4b9b-90e8-2a76e8aa426d"
/>
<img width="508" alt="Screenshot 2025-04-28 at 19 28 16"
src="https://github.com/user-attachments/assets/6ee62ab8-f610-4c5f-b26c-1f623d4d6148"
/>
<img width="426" alt="Screenshot 2025-04-28 at 19 28 21"
src="https://github.com/user-attachments/assets/be7daf25-08ef-4ba0-97a2-72a030daa4dd"
/>
<img width="391" alt="Screenshot 2025-04-28 at 19 29 12"
src="https://github.com/user-attachments/assets/90fa8904-99e8-44b0-8ac1-a24585886f5e"
/>


<!-- [screenshots/recordings] -->

### **After**
<img width="442" alt="Screenshot 2025-04-28 at 21 50 24"
src="https://github.com/user-attachments/assets/238d185f-52c6-40e3-b05a-2e5407625236"
/>
<img width="386" alt="Screenshot 2025-04-28 at 21 55 59"
src="https://github.com/user-attachments/assets/af46b25b-e778-4fd2-931e-88e3239ffa4e"
/>
<img width="406" alt="Screenshot 2025-04-28 at 21 56 03"
src="https://github.com/user-attachments/assets/62652ddc-4763-44eb-bddc-aa308ca49df5"
/>
<img width="388" alt="Screenshot 2025-04-28 at 21 56 28"
src="https://github.com/user-attachments/assets/3a437db3-06e4-4ca9-8d0c-9f5648f85dff"
/>
<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Copy link
Contributor

github-actions bot commented May 1, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label May 1, 2025
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​solana-wallet-standard@​0.3.1 ⏵ 0.4.1811009596100

View full report

@DDDDDanica DDDDDanica changed the title feat: use MetaMask build name for solana cp-12.18.0 (#32356) Cherry-pick: feat: use MetaMask build name for solana cp-12.18.0 (#32356) May 1, 2025
@DDDDDanica DDDDDanica changed the title Cherry-pick: feat: use MetaMask build name for solana cp-12.18.0 (#32356) feat: use MetaMask build name for solana cp-12.18.0 (#32356) Cherry-pick May 1, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [20be75a]
UI Startup Metrics (1202 ± 55 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1202108414075512281291
load103894312405010651116
domContentLoaded103294012345010611110
domInteractive181365101629
firstPaint73470124640610601115
backgroundConnect74213811
firstReactRender20154642127
getState1353381929
initialActions001001
loadScripts79669995747825870
setupStore75172811
WebpackHomeuiStartup20981736260320322292373
load16181318212716617381858
domContentLoaded16111310212216517321851
domInteractive161164101343
firstPaint1656638762191300
backgroundConnect25979142958
firstReactRender21255430118337358
getState1143561222
initialActions316135
loadScripts16071307212016417281828
setupStore187174172035
FirefoxBrowserifyHomeuiStartup13331164173712013931560
load11971003159312512721421
domContentLoaded11971003159312512721421
domInteractive1024223029113155
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect1913102101930
firstReactRender22185552231
getState6421279
initialActions001001
loadScripts1179990157912312531391
setupStore63345620
WebpackHomeuiStartup15251359205912616021797
load13131190181911513721572
domContentLoaded13131189181811513711572
domInteractive81471732291126
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22136082342
firstReactRender35285963648
getState94527929
initialActions002111
loadScripts12931170179211513571552
setupStore95487825

@DDDDDanica DDDDDanica merged commit 71691ca into Version-v12.18.0 May 1, 2025
167 of 172 checks passed
@DDDDDanica DDDDDanica deleted the cherry-pick-9ce7f3f4d0ff997af338d0c8ffaf648a2d7bcd22 branch May 1, 2025 13:24
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants