chore(runway): cherry-pick fix(ledger-mv3-bridge): cp-12.18.0 return response.success when payload is undefined

[runway-github]

• fix(ledger-mv3-bridge): cp-12.18.0 return response.success when payload is undefined (fix(ledger-mv3-bridge): cp-12.18.0 return response.success when payload is undefined #32411)

Description

Ledger MV3 bridge consumers are expecting attemptMakeApp and
updateLedgerTransport to return true when the operation is
successful, even if no error was thrown. This PR changes the
#sendMessage method to return the response.success value if
response.payload is undefined.

Related issues

Fixes: #32319

Manual testing steps

1. Pair a Ledger account
2. Go to https://metamask.github.io/test-dapp/
3. Connect the wallet
4. Sign a typed message with the Ledger account
5. The "connect" button should be enabled

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor
  Docs and MetaMask
  Extension Coding
  Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format
  if applicable
• I’ve applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots. d7be1c5

[metamaskbot]

Builds ready [a8e0cb5]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1189 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1189	1085	1514	62	1227	1278
			load	1029	892	1290	56	1056	1124
			domContentLoaded	1023	886	1287	56	1047	1113
			domInteractive	18	14	64	10	16	27
			firstPaint	691	79	1125	402	1033	1094
			backgroundConnect	7	4	21	2	7	9
			firstReactRender	22	15	68	9	21	42
			getState	13	5	35	8	17	28
			initialActions	0	0	1	0	0	0
			loadScripts	788	664	1044	55	811	874
			setupStore	8	5	21	3	8	13
	Webpack	Home	uiStartup	2070	1697	2438	171	2175	2349
			load	1607	1290	1988	138	1721	1782
			domContentLoaded	1601	1283	1984	137	1715	1779
			domInteractive	15	11	49	9	13	42
			firstPaint	173	62	346	61	214	275
			backgroundConnect	27	9	335	34	26	63
			firstReactRender	191	55	419	120	327	356
			getState	13	4	252	25	11	29
			initialActions	3	1	6	1	3	5
			loadScripts	1596	1280	1960	137	1711	1777
			setupStore	16	7	45	7	20	30
Firefox	Browserify	Home	uiStartup	1337	1150	1715	119	1377	1619
			load	1197	1008	1592	122	1253	1488
			domContentLoaded	1197	1008	1592	122	1253	1488
			domInteractive	104	37	243	34	113	176
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	232	23	20	43
			firstReactRender	22	19	54	5	22	26
			getState	7	4	29	3	7	10
			initialActions	0	0	1	0	0	1
			loadScripts	1177	995	1580	121	1226	1465
			setupStore	6	3	32	4	6	11
	Webpack	Home	uiStartup	1550	1376	2135	168	1643	1891
			load	1331	1180	1908	147	1403	1659
			domContentLoaded	1330	1180	1907	147	1402	1659
			domInteractive	86	50	238	29	93	136
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	15	87	9	24	36
			firstReactRender	36	28	54	5	39	46
			getState	12	4	286	28	10	30
			initialActions	0	0	2	1	1	1
			loadScripts	1309	1162	1854	144	1384	1632
			setupStore	9	5	61	6	9	13

Benchmark value 1632 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 2ms
Sum of all benchmark exceeds: 2ms