Skip to content

fix: add try catch to _addSolanaAccount cp-12.18.0 #32421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 2, 2025

Conversation

montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Apr 30, 2025

Description

This adds a try catch to _addSolanaAccount to not block the onboarding flow if it fails.

Open in GitHub Codespaces

Related issues

Fixes: #32413

Manual testing steps

  1. Go through IMPORT onboarding flow (until Your Wallet is ready screen)
  2. Click Manager default privacy settings
  3. Click General
  4. Toggle off Basic Functionality
  5. Go back to main screen
  6. Click Done and continue to finish onboarding
  7. See that you are able to go to the wallet overview.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@montelaidev montelaidev marked this pull request as ready for review April 30, 2025 15:51
@montelaidev montelaidev requested a review from a team April 30, 2025 16:00
FrederikBolding
FrederikBolding previously approved these changes May 1, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [cbe146f]
UI Startup Metrics (1180 ± 57 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1180105413945712081278
load102393912025110531108
domContentLoaded101793411985010481105
domInteractive17136881627
firstPaint60679111740910231086
backgroundConnect74193715
firstReactRender21154962235
getState1254171726
initialActions001001
loadScripts78270593149813872
setupStore75172811
WebpackHomeuiStartup20421684246517621552285
load15751295191514316921794
domContentLoaded15691292189314216881783
domInteractive15114991243
firstPaint1706634963205295
backgroundConnect309360482556
firstReactRender18154408115300352
getState1045061219
initialActions315134
loadScripts15611291187014216831780
setupStore216309401927
FirefoxBrowserifyHomeuiStartup13331149167111213951580
load11901029155511512501442
domContentLoaded11891029155511512501442
domInteractive983519128108164
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113123151938
firstReactRender22194542234
getState942302279
initialActions001001
loadScripts11711010153211612361427
setupStore741681658
WebpackHomeuiStartup15391362188011816351757
load13291178164210514171517
domContentLoaded13291178164210514171516
domInteractive84401692395142
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21154562234
firstReactRender34284743642
getState94295926
initialActions101111
loadScripts13101164162410514021499
setupStore85566812
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 31.95 KiB (0.6%)
  • ui: -3.47 KiB (-0.05%)
  • common: 24.18 KiB (0.26%)

@montelaidev montelaidev added this pull request to the merge queue May 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2025
@darioAnongba darioAnongba added this pull request to the merge queue May 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2025
@montelaidev montelaidev added this pull request to the merge queue May 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2025
@DDDDDanica DDDDDanica added this pull request to the merge queue May 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2025
@montelaidev montelaidev added this pull request to the merge queue May 2, 2025
Merged via the queue into main with commit be7e29f May 2, 2025
170 checks passed
@montelaidev montelaidev deleted the fix/mmmultisrp-32413 branch May 2, 2025 14:51
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: error when Basic Functionality is turned off during onboarding flow due to snaps
4 participants