-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: cp-12.18.0 bridge activity log doesn't update and may show incorrect token amounts #32387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+20
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers
|
Builds ready [8d8176c]
UI Startup Metrics (1189 ± 62 ms)
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 36ms Sum of all benchmark exceeds: 36ms Bundle size diffs
|
Builds ready [08f6ed5]
UI Startup Metrics (1230 ± 72 ms)
Benchmark value 20 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1687 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1687 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Sum of mean exceeds: 5ms | Sum of p95 exceeds: 65ms Sum of all benchmark exceeds: 70ms Bundle size diffs [🚀 Bundle size reduced!]
|
ghgoodreau
approved these changes
May 5, 2025
GustavoRSSilva
approved these changes
May 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
Related issues
Fixes: #32390 , #32477, #32266
Manual testing steps
Screenshots/Recordings
Before / After
Pre-merge author checklist
Pre-merge reviewer checklist