fix: privacy policy in network settings cp-12.18.0 #32375

montelaidev · 2025-04-29T13:40:38Z

Description

This pr updates the content for Choose you network to reference solana accounts.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMMULTISRP-166?atlOrigin=eyJpIjoiNjMyMTI2ZTM5ZjIzNDNlYmI5NTI4MGQ2MmQ3ZjNiMzciLCJwIjoiaiJ9

Manual testing steps

Go to Security & privacy in settings
Scroll down to Choose your network
See a link for solana accounts.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-29T13:40:52Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-04-29T23:44:47Z

Builds ready [f72e538]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1181 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1181	1057	1410	58	1210	1285
			load	1023	929	1232	53	1049	1143
			domContentLoaded	1016	918	1219	53	1044	1133
			domInteractive	17	13	59	6	16	28
			firstPaint	755	161	1224	392	1048	1149
			backgroundConnect	7	4	95	9	7	9
			firstReactRender	21	16	75	8	22	36
			getState	14	5	48	8	19	29
			initialActions	0	0	1	0	0	1
			loadScripts	783	677	956	53	812	906
			setupStore	8	5	26	3	8	16
	Webpack	Home	uiStartup	2077	1568	2480	180	2195	2310
			load	1617	1225	1998	142	1718	1790
			domContentLoaded	1610	1222	1991	140	1711	1774
			domInteractive	15	11	53	8	13	39
			firstPaint	181	67	651	87	224	313
			backgroundConnect	30	9	307	37	27	65
			firstReactRender	179	54	393	115	306	356
			getState	10	4	36	5	11	19
			initialActions	3	1	6	1	3	4
			loadScripts	1602	1221	1969	142	1709	1771
			setupStore	26	6	292	49	21	30
Firefox	Browserify	Home	uiStartup	1339	1179	1849	132	1376	1675
			load	1198	1027	1704	135	1245	1491
			domContentLoaded	1197	1027	1704	135	1244	1490
			domInteractive	103	37	261	36	115	166
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	12	44	5	19	31
			firstReactRender	22	18	49	4	22	27
			getState	9	4	170	17	7	11
			initialActions	0	0	1	0	0	1
			loadScripts	1180	1011	1680	134	1226	1471
			setupStore	6	4	34	5	6	11
	Webpack	Home	uiStartup	1573	1382	2121	152	1669	1921
			load	1350	1200	1922	136	1434	1602
			domContentLoaded	1349	1200	1921	136	1433	1602
			domInteractive	85	42	277	38	85	136
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	80	11	25	41
			firstReactRender	36	30	54	4	38	46
			getState	10	5	48	6	9	25
			initialActions	1	0	1	0	1	1
			loadScripts	1328	1182	1846	134	1413	1577
			setupStore	8	5	28	4	9	19

Benchmark value 1675 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 15ms
Sum of all benchmark exceeds: 15ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 53.3 KiB (1.01%)
ui: 3.35 KiB (0.05%)
common: 91.72 KiB (0.99%)

app/_locales/en/messages.json

metamaskbot · 2025-04-30T13:16:13Z

Builds ready [1632795]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1197 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1197	1071	1524	65	1226	1315
			load	1039	955	1250	53	1062	1163
			domContentLoaded	1033	948	1238	52	1057	1154
			domInteractive	17	13	59	7	16	30
			firstPaint	701	67	1246	418	1057	1113
			backgroundConnect	7	4	23	2	7	10
			firstReactRender	21	15	43	6	21	39
			getState	13	6	38	8	17	34
			initialActions	0	0	1	0	0	0
			loadScripts	796	714	1000	51	819	905
			setupStore	8	5	29	4	8	13
	Webpack	Home	uiStartup	2248	1835	2770	187	2366	2537
			load	1745	1415	2120	148	1854	1948
			domContentLoaded	1737	1411	2083	146	1848	1934
			domInteractive	17	12	108	13	14	45
			firstPaint	179	70	555	74	214	326
			backgroundConnect	32	10	323	34	36	66
			firstReactRender	225	57	455	123	342	365
			getState	14	4	53	9	17	36
			initialActions	3	1	7	1	4	5
			loadScripts	1732	1410	2053	143	1846	1915
			setupStore	27	7	299	42	26	59
Firefox	Browserify	Home	uiStartup	1355	1166	1600	98	1403	1551
			load	1215	1015	1479	103	1272	1415
			domContentLoaded	1214	1015	1478	103	1272	1415
			domInteractive	105	39	269	39	114	190
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	12	101	9	19	28
			firstReactRender	23	19	52	5	22	30
			getState	7	3	26	3	8	11
			initialActions	0	0	2	0	0	1
			loadScripts	1197	1000	1464	102	1255	1392
			setupStore	5	4	15	1	6	7
	Webpack	Home	uiStartup	1531	1364	2064	137	1591	1821
			load	1316	1173	1831	121	1370	1566
			domContentLoaded	1315	1173	1831	121	1369	1566
			domInteractive	80	50	143	18	89	119
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	53	8	24	42
			firstReactRender	35	29	55	5	36	46
			getState	11	4	195	19	9	30
			initialActions	0	0	1	0	1	1
			loadScripts	1296	1157	1812	120	1350	1546
			setupStore	8	5	23	3	8	18

cc: @HowardBraham
Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 2248 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1745 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1738 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1733 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2538 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Sum of mean exceeds: 158ms | Sum of p95 exceeds: 85ms
Sum of all benchmark exceeds: 243ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 278 Bytes (0%)
common: 169 Bytes (0%)

fix: privacy policy in network settings

567210f

metamaskbot added the team-accounts label Apr 29, 2025

montelaidev added 2 commits April 30, 2025 07:08

fix: locales

3ec5ea8

fix: snapshot

f72e538

montelaidev requested a review from a team April 30, 2025 05:48

Merge branch 'main' into fix/mmmultisrp-166

f92dc10

ccharly reviewed Apr 30, 2025

View reviewed changes

app/_locales/en/messages.json Outdated Show resolved Hide resolved

montelaidev added 2 commits April 30, 2025 16:07

fix: $1 in chooseYourNetworkDescription

f072746

fix: update snapshot

00ab07c

montelaidev requested a review from ccharly April 30, 2025 10:38

Merge branch 'main' into fix/mmmultisrp-166

1632795

ccharly approved these changes Apr 30, 2025

View reviewed changes

montelaidev changed the title ~~fix: privacy policy in network settings~~ fix: privacy policy in network settings cp-12.18.0 Apr 30, 2025

gantunesr approved these changes Apr 30, 2025

View reviewed changes

montelaidev added this pull request to the merge queue Apr 30, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2025

montelaidev added this pull request to the merge queue Apr 30, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2025

montelaidev added this pull request to the merge queue Apr 30, 2025

Merged via the queue into main with commit 5c04902 Apr 30, 2025
170 of 172 checks passed

montelaidev deleted the fix/mmmultisrp-166 branch April 30, 2025 23:20

github-actions bot locked and limited conversation to collaborators Apr 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: privacy policy in network settings cp-12.18.0 #32375

fix: privacy policy in network settings cp-12.18.0 #32375

montelaidev commented Apr 29, 2025 •

edited

Loading

github-actions bot commented Apr 29, 2025

metamaskbot commented Apr 29, 2025

metamaskbot commented Apr 30, 2025

fix: privacy policy in network settings cp-12.18.0 #32375

fix: privacy policy in network settings cp-12.18.0 #32375

Conversation

montelaidev commented Apr 29, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 29, 2025

metamaskbot commented Apr 29, 2025

metamaskbot commented Apr 30, 2025

montelaidev commented Apr 29, 2025 •

edited

Loading