fix: Nonce editing cp-12.17.0

[pedronfigueiredo]

Description

On #31593, a new onTransactionConfirm callback was created that handles enriching the transaction metadata with the custom nonce before it gets sent to the transaction controller. That callback was missing the selected custom nonce in the dependency array.

Related issues

Fixes: #32029

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

• ui/pages/confirmations/hooks/transactions/useTransactionConfirm.ts

[metamaskbot]

Builds ready [8f39a48]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1238 ± 55 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1238	1131	1366	55	1278	1337
			load	1065	960	1183	48	1100	1153
			domContentLoaded	1059	957	1175	47	1094	1148
			domInteractive	18	13	64	7	18	29
			firstPaint	646	134	1186	433	1080	1144
			backgroundConnect	6	4	14	2	7	9
			firstReactRender	23	15	58	8	23	41
			getState	14	5	36	8	19	31
			initialActions	0	0	1	0	0	1
			loadScripts	818	729	916	46	851	899
			setupStore	8	5	26	3	9	14
	Webpack	Home	uiStartup	2068	1703	2479	176	2183	2320
			load	1591	1315	2025	132	1684	1775
			domContentLoaded	1584	1311	2018	131	1677	1767
			domInteractive	16	11	54	10	13	41
			firstPaint	180	61	610	73	226	280
			backgroundConnect	24	9	69	14	26	57
			firstReactRender	204	55	372	117	338	361
			getState	11	4	37	5	12	23
			initialActions	3	1	7	1	3	4
			loadScripts	1580	1310	1995	130	1675	1766
			setupStore	15	6	34	6	19	29
Firefox	Browserify	Home	uiStartup	1339	1143	1738	120	1382	1609
			load	1195	1018	1548	118	1241	1462
			domContentLoaded	1195	1018	1548	118	1241	1462
			domInteractive	100	37	317	37	117	148
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	12	226	23	21	47
			firstReactRender	22	18	57	4	22	26
			getState	9	4	168	16	7	11
			initialActions	0	0	1	0	0	1
			loadScripts	1175	1002	1529	114	1226	1419
			setupStore	6	3	40	5	6	11
	Webpack	Home	uiStartup	1504	1343	1917	128	1600	1754
			load	1283	1149	1618	109	1366	1504
			domContentLoaded	1283	1149	1618	109	1366	1504
			domInteractive	81	59	158	20	86	140
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	52	7	22	40
			firstReactRender	36	29	54	5	38	48
			getState	9	4	31	5	10	19
			initialActions	1	0	2	1	1	1
			loadScripts	1264	1133	1601	109	1350	1481
			setupStore	9	5	48	8	8	30

Benchmark value 1238 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 5ms | Sum of p95 exceeds: 2ms
Sum of all benchmark exceeds: 7ms

Bundle size diffs

• background: 0 Bytes (0%)
• ui: 2 Bytes (0%)
• common: 0 Bytes (0%)