chore: update security and privacy policy description cp-12.18.0 #32231

shane-t · 2025-04-24T09:50:24Z

Description

Update the copy for Security & Privacy for Solana. In particular, change it in the Choose your network section.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMMULTISRP-166

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-04-24T09:52:35Z

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

ui/pages/onboarding-flow/privacy-settings/privacy-settings.js

metamaskbot · 2025-04-24T10:34:55Z

Builds ready [74023ce]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1196 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1196	1083	1343	62	1234	1306
			load	1030	940	1152	53	1064	1125
			domContentLoaded	1024	936	1143	53	1060	1116
			domInteractive	16	13	30	4	16	28
			firstPaint	720	136	1151	404	1052	1126
			backgroundConnect	7	4	21	2	7	9
			firstReactRender	22	16	47	7	24	42
			getState	13	5	50	9	18	31
			initialActions	0	0	1	0	0	0
			loadScripts	788	710	904	51	819	883
			setupStore	8	4	23	3	8	16
	Webpack	Home	uiStartup	2088	1701	2541	173	2212	2340
			load	1622	1300	1943	140	1732	1835
			domContentLoaded	1615	1291	1921	139	1724	1827
			domInteractive	15	11	55	9	13	41
			firstPaint	181	78	716	82	203	334
			backgroundConnect	24	12	80	13	25	54
			firstReactRender	194	54	416	116	315	359
			getState	13	4	276	27	12	25
			initialActions	3	1	10	1	3	5
			loadScripts	1611	1288	1898	138	1720	1822
			setupStore	21	6	302	39	20	29
Firefox	Browserify	Home	uiStartup	1378	1168	1767	104	1431	1580
			load	1228	1040	1578	106	1288	1438
			domContentLoaded	1228	1040	1578	106	1288	1438
			domInteractive	109	36	291	40	125	188
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	12	123	20	21	79
			firstReactRender	23	19	47	4	23	29
			getState	7	4	39	4	8	12
			initialActions	0	0	1	0	0	1
			loadScripts	1206	1030	1502	107	1267	1423
			setupStore	9	4	206	21	6	18
	Webpack	Home	uiStartup	1490	1324	1864	114	1550	1762
			load	1275	1137	1576	96	1315	1511
			domContentLoaded	1274	1137	1576	96	1315	1511
			domInteractive	83	33	288	28	87	132
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	76	8	22	37
			firstReactRender	35	28	58	5	36	47
			getState	12	4	330	33	9	23
			initialActions	1	0	2	1	1	1
			loadScripts	1255	1118	1550	95	1291	1494
			setupStore	9	5	43	6	8	24

Benchmark value 335 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 79 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 10ms
Sum of all benchmark exceeds: 10ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 238 Bytes (0%)
common: 154 Bytes (0%)

metamaskbot · 2025-04-24T13:49:19Z

Builds ready [1236639]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1226 ± 61 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1226	1102	1395	61	1267	1349
			load	1057	951	1201	55	1091	1168
			domContentLoaded	1051	947	1196	54	1082	1163
			domInteractive	18	14	68	8	17	31
			firstPaint	650	133	1215	416	1057	1134
			backgroundConnect	7	4	20	2	7	9
			firstReactRender	21	16	45	5	21	33
			getState	12	5	34	7	16	26
			initialActions	0	0	1	0	0	1
			loadScripts	810	698	932	51	844	910
			setupStore	8	5	17	2	8	13
	Webpack	Home	uiStartup	2071	1713	2558	185	2201	2341
			load	1600	1323	1963	141	1717	1789
			domContentLoaded	1593	1319	1939	140	1710	1783
			domInteractive	16	11	78	12	13	45
			firstPaint	183	74	541	70	223	311
			backgroundConnect	23	10	87	14	24	58
			firstReactRender	203	55	386	122	322	368
			getState	13	4	249	24	12	23
			initialActions	3	1	6	1	3	4
			loadScripts	1588	1317	1916	138	1707	1782
			setupStore	20	6	291	39	18	28
Firefox	Browserify	Home	uiStartup	1340	1185	1723	104	1400	1550
			load	1196	1015	1487	104	1251	1391
			domContentLoaded	1195	1015	1487	104	1251	1390
			domInteractive	105	36	391	47	108	218
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	44	6	20	36
			firstReactRender	22	19	51	5	22	29
			getState	7	4	27	3	8	12
			initialActions	0	0	1	0	0	1
			loadScripts	1178	1000	1466	103	1238	1353
			setupStore	10	4	185	25	6	21
	Webpack	Home	uiStartup	1518	1351	1859	117	1583	1768
			load	1295	1168	1599	101	1342	1533
			domContentLoaded	1295	1168	1598	101	1342	1533
			domInteractive	84	41	302	28	88	125
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	37	4	23	30
			firstReactRender	35	28	58	5	37	45
			getState	9	4	37	6	9	24
			initialActions	0	0	2	1	1	1
			loadScripts	1275	1147	1579	100	1320	1518
			setupStore	8	5	25	3	8	14

Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 218 exceeds gate value 195 for firefox browserify home p95 domInteractive
Sum of mean exceeds: 1ms | Sum of p95 exceeds: 23ms
Sum of all benchmark exceeds: 24ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -107 Bytes (0%)
ui: 238 Bytes (0%)
common: 367 Bytes (0%)

metamaskbot · 2025-04-24T20:26:46Z

Builds ready [c4b26f6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1245 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1245	1107	1497	64	1284	1356
			load	1077	978	1297	59	1110	1198
			domContentLoaded	1071	974	1291	59	1104	1191
			domInteractive	19	14	68	8	18	29
			firstPaint	742	153	1246	420	1085	1141
			backgroundConnect	7	4	36	4	8	10
			firstReactRender	22	17	46	7	23	41
			getState	13	5	38	7	19	30
			initialActions	0	0	1	0	0	1
			loadScripts	827	729	1041	56	859	930
			setupStore	8	5	29	3	8	12
	Webpack	Home	uiStartup	2134	1751	2435	172	2276	2370
			load	1649	1361	1887	128	1762	1815
			domContentLoaded	1642	1357	1875	128	1752	1810
			domInteractive	16	11	60	10	14	46
			firstPaint	186	66	592	69	216	306
			backgroundConnect	25	9	78	13	29	56
			firstReactRender	215	56	414	118	341	361
			getState	13	4	173	17	15	26
			initialActions	3	1	7	1	4	6
			loadScripts	1637	1356	1865	127	1749	1808
			setupStore	17	6	53	8	22	32
Firefox	Browserify	Home	uiStartup	1457	1227	1833	117	1534	1705
			load	1292	1093	1644	120	1369	1539
			domContentLoaded	1292	1093	1643	120	1368	1539
			domInteractive	108	37	193	30	127	154
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	127	13	24	39
			firstReactRender	25	21	41	4	26	34
			getState	9	5	39	5	9	13
			initialActions	0	0	1	0	0	1
			loadScripts	1270	1074	1618	121	1347	1515
			setupStore	8	4	69	8	7	16
	Webpack	Home	uiStartup	1527	1329	1936	130	1595	1785
			load	1311	1142	1675	113	1381	1560
			domContentLoaded	1311	1142	1675	113	1380	1560
			domInteractive	85	56	155	20	98	123
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	90	11	22	40
			firstReactRender	35	28	54	5	37	44
			getState	8	4	37	5	8	18
			initialActions	1	0	2	1	1	1
			loadScripts	1292	1128	1657	112	1361	1543
			setupStore	9	5	52	8	8	24

cc: @HowardBraham
Benchmark value 1245 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1077 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1071 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1198 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1192 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1458 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1293 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1292 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 1271 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 1705 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1539 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1539 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 1515 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Sum of mean exceeds: 223ms | Sum of p95 exceeds: 193ms
Sum of all benchmark exceeds: 416ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 238 Bytes (0%)
common: 232 Bytes (0%)

…com:MetaMask/metamask-extension into MMMULTISRP-166-update-security-privacy-copy

metamaskbot · 2025-04-25T13:58:34Z

Builds ready [1309fd3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1214 ± 55 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1214	1112	1357	55	1253	1316
			load	1051	966	1189	48	1084	1129
			domContentLoaded	1045	962	1184	48	1077	1121
			domInteractive	19	13	83	11	17	50
			firstPaint	632	145	1138	415	1041	1117
			backgroundConnect	7	4	24	3	8	11
			firstReactRender	22	16	53	6	22	37
			getState	12	5	34	7	17	29
			initialActions	0	0	1	0	0	1
			loadScripts	805	727	917	46	838	886
			setupStore	8	5	25	4	9	15
	Webpack	Home	uiStartup	2176	1715	2761	168	2291	2430
			load	1690	1330	2176	134	1764	1892
			domContentLoaded	1684	1326	2159	133	1758	1888
			domInteractive	16	12	63	11	14	52
			firstPaint	193	75	1588	153	213	332
			backgroundConnect	31	9	373	48	26	59
			firstReactRender	208	56	370	119	335	358
			getState	11	3	40	7	14	25
			initialActions	3	1	8	1	3	5
			loadScripts	1679	1324	2135	132	1756	1886
			setupStore	21	7	185	25	22	44
Firefox	Browserify	Home	uiStartup	1355	1190	1749	117	1427	1609
			load	1209	1022	1601	125	1276	1474
			domContentLoaded	1209	1022	1601	125	1276	1474
			domInteractive	108	43	312	38	118	171
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	95	12	19	30
			firstReactRender	23	19	52	6	22	37
			getState	7	4	77	8	7	10
			initialActions	0	0	1	0	0	1
			loadScripts	1191	1008	1557	124	1261	1456
			setupStore	7	4	171	17	6	8
	Webpack	Home	uiStartup	1509	1358	1943	134	1594	1772
			load	1296	1165	1724	119	1378	1544
			domContentLoaded	1296	1165	1723	119	1378	1543
			domInteractive	83	42	309	29	88	128
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	55	6	24	33
			firstReactRender	35	29	54	4	37	44
			getState	9	4	31	5	9	21
			initialActions	1	0	2	1	1	1
			loadScripts	1276	1150	1707	119	1354	1523
			setupStore	9	5	53	7	8	29

Benchmark value 50 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 10ms
Sum of all benchmark exceeds: 10ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 283 Bytes (0%)
common: 232 Bytes (0%)

chore: update security and privacy policy description

17556e7

metamaskbot added the team-identity label Apr 24, 2025

chore: update changelog

74023ce

shane-t added 2 commits April 24, 2025 11:49

chore: fix en/en_GB

f58e969

chore: fix privacy CTA text

1236639

Merge branch 'main' into MMMULTISRP-166-update-security-privacy-copy

c4b26f6

shane-t marked this pull request as ready for review April 24, 2025 17:33

shane-t requested a review from a team as a code owner April 24, 2025 17:33

Merge branch 'main' into MMMULTISRP-166-update-security-privacy-copy

f373266

shane-t changed the title ~~chore: update security and privacy policy description~~ chore: update security and privacy policy description cp-12.18.0 Apr 25, 2025

shane-t added 4 commits April 25, 2025 12:47

chore: fix lint

0ee5052

Merge branch 'MMMULTISRP-166-update-security-privacy-copy' of github.…

759aed7

…com:MetaMask/metamask-extension into MMMULTISRP-166-update-security-privacy-copy

chore: use onboardingAdvancedPrivacyNetworkDescriptionCallToAction

b6d24ae

Merge branch 'main' into MMMULTISRP-166-update-security-privacy-copy

1309fd3

NidhiKJha approved these changes Apr 25, 2025

View reviewed changes

montelaidev approved these changes Apr 25, 2025

View reviewed changes

shane-t added this pull request to the merge queue Apr 25, 2025

Merged via the queue into main with commit 5a6a315 Apr 25, 2025
169 checks passed

shane-t deleted the MMMULTISRP-166-update-security-privacy-copy branch April 25, 2025 16:11

github-actions bot locked and limited conversation to collaborators Apr 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update security and privacy policy description cp-12.18.0 #32231

chore: update security and privacy policy description cp-12.18.0 #32231

shane-t commented Apr 24, 2025 •

edited

Loading

metamaskbot commented Apr 24, 2025

metamaskbot commented Apr 24, 2025

metamaskbot commented Apr 24, 2025

metamaskbot commented Apr 24, 2025

metamaskbot commented Apr 25, 2025

chore: update security and privacy policy description cp-12.18.0 #32231

chore: update security and privacy policy description cp-12.18.0 #32231

Conversation

shane-t commented Apr 24, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

metamaskbot commented Apr 24, 2025

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Apr 24, 2025

metamaskbot commented Apr 24, 2025

metamaskbot commented Apr 24, 2025

metamaskbot commented Apr 25, 2025

shane-t commented Apr 24, 2025 •

edited

Loading