Skip to content

feat: Adds Remote Mode settings screen logic #32214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2025
Merged

Conversation

kevinbluer
Copy link
Member

@kevinbluer kevinbluer commented Apr 23, 2025

Description

  • Adds Remote Mode settings screen logic (link to screens for reference)
  • Note that it stores dummy swap allowances / withdrawal limit data in localStorage which is designed to be replaced with state from the DelegationController in a future PR
  • Also includes the following miscellaneous updates:
    • Updates to Swap Allowance and Withdrawal Limit cards (style and making the remove button optiona)
    • Binance and Wrapped BTC icons

Open in GitHub Codespaces

Related issues

Fixes: #32150

  1. Create the build (yarn webpack)
  2. Go to #remote/setup-swaps and #remote/setup-daily-allowance go through the respective setup flows
  3. Go to #remote and validate the settings screen
  4. Revoke both the Remote Swaps and Withdrawal Limit (note this just removes the temporary entries from localStorage)
  5. Designs for reference
  • Note to override the vaultRemoteMode feature flag (which will implicitly default to disabled), the configuration steps are available here. Example.manifest-overrides.json:
{
  "_flags": {
    "remoteFeatureFlags": {
      "vaultRemoteMode": true
    }
  }
}

Screenshots/Recordings

Before

NA

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@kevinbluer kevinbluer force-pushed the feat/remote-mode-settings branch from ea86b2e to 0eee6ab Compare April 23, 2025 21:13
@kevinbluer kevinbluer marked this pull request as ready for review April 23, 2025 21:13
@kevinbluer kevinbluer added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-vault MetaMask Vault Team labels Apr 23, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 23, 2025
@kevinbluer kevinbluer force-pushed the feat/remote-mode-settings branch from 0eee6ab to 3ab37a0 Compare April 23, 2025 21:35
Copy link
Contributor

@caieu caieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbluer kevinbluer force-pushed the feat/remote-mode-settings branch from 3ab37a0 to b0f9946 Compare April 24, 2025 00:39
@metamaskbot
Copy link
Collaborator

Builds ready [b0f9946]
UI Startup Metrics (1206 ± 56 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1206110214065612341304
load104295311855210681146
domContentLoaded103694911755110621139
domInteractive17146471727
firstPaint664128116341610531119
backgroundConnect74162810
firstReactRender20154252131
getState1354791930
initialActions001001
loadScripts79871693650822894
setupStore75162812
WebpackHomeuiStartup20921697253917022022351
load16181317197413217191831
domContentLoaded16121314195813117141826
domInteractive15115091342
firstPaint1787256574214296
backgroundConnect23973132557
firstReactRender20954375122342359
getState133257251324
initialActions317145
loadScripts16071312193512917111822
setupStore187257251929
FirefoxBrowserifyHomeuiStartup13551160171310214211516
load12121027154810512791390
domContentLoaded12121027154810512791389
domInteractive1023623433113161
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19124862136
firstReactRender22195142327
getState73304811
initialActions001001
loadScripts11941013152810612621370
setupStore6440567
WebpackHomeuiStartup15071332197511915661750
load1282113916259713301505
domContentLoaded1282113816249713301504
domInteractive83541662197125
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24167582540
firstReactRender35295443743
getState13428328932
initialActions007111
loadScripts1260112415969613071476
setupStore85253815
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 9.12 KiB (0.13%)
  • common: 0 Bytes (0%)

@kevinbluer kevinbluer added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit 449dea1 Apr 24, 2025
169 checks passed
@kevinbluer kevinbluer deleted the feat/remote-mode-settings branch April 24, 2025 02:14
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-vault MetaMask Vault Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen - Settings
4 participants