-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat: Adds Remote Mode settings screen logic #32214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+522
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea86b2e
to
0eee6ab
Compare
0eee6ab
to
3ab37a0
Compare
caieu
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
matallui
approved these changes
Apr 24, 2025
3ab37a0
to
b0f9946
Compare
Builds ready [b0f9946]
UI Startup Metrics (1206 ± 56 ms)
Bundle size diffs
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
no-changelog
no-changelog Indicates no external facing user changes, therefore no changelog documentation needed
team-vault
MetaMask Vault Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DelegationController
in a future PRRelated issues
Fixes: #32150
#remote/setup-swaps
and#remote/setup-daily-allowance
go through the respective setup flows#remote
and validate the settings screenScreenshots/Recordings
Before
NA
After
Pre-merge author checklist
Pre-merge reviewer checklist