Skip to content

fix: Show Connection Toast when at least one account is connected to Dapp #32199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Apr 23, 2025

This PR ensures that the connection toast is shown when at least one account is connected to the Dapp. If no account is connected, then the Toast to connect accounts should not be displayed

Related issues

Fixes: #32045

Manual testing steps

  1. Run extension
  2. Open the Dapp, and MM in popup view. No toast should show
  3. Connect MM to Dapp
  4. Switch to the second account
  5. Toast should appear

Screenshots/Recordings

Before

Screenshot 2025-04-23 at 3 49 29 PM

After

When Dapp is not connected

Screen.Recording.2025-04-23.at.3.46.19.PM.mov

When Dapp is connected

Screen.Recording.2025-04-23.at.3.47.13.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner April 23, 2025 14:48
@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template team-wallet-ux labels Apr 23, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [2087ca6]
UI Startup Metrics (1245 ± 69 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1245106714116912991365
load107894912396711321200
domContentLoaded107294512346711201195
domInteractive191372101730
firstPaint757134124441810951186
backgroundConnect74182712
firstReactRender22165562135
getState13465101929
initialActions001000
loadScripts83471799264881949
setupStore85162813
WebpackHomeuiStartup21931745267317222742438
load17021347212014418231913
domContentLoaded16961344210814318151909
domInteractive171172111442
firstPaint1976868788250330
backgroundConnect2910227282864
firstReactRender21955395125344372
getState144176181629
initialActions318146
loadScripts16911342208314218121907
setupStore227224282341
FirefoxBrowserifyHomeuiStartup13871205169810514541625
load12331055156510912971468
domContentLoaded12331054156510912961468
domInteractive1054031836117153
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2314137162342
firstReactRender24195562432
getState84415813
initialActions001001
loadScripts12121040154710812731387
setupStore6431469
WebpackHomeuiStartup15171343212713515891800
load12971146177211713751514
domContentLoaded12971145177111713741514
domInteractive82431622196122
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2314100122342
firstReactRender362896103849
getState94305921
initialActions006111
loadScripts12761129175411713491494
setupStore85617816
cc: @HowardBraham
Benchmark value 1246 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1079 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1073 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 834 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1200 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1195 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1186 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 949 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2193 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 372 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Sum of mean exceeds: 38ms | Sum of p95 exceeds: 42ms
Sum of all benchmark exceeds: 80ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 12 Bytes (0%)
  • common: 0 Bytes (0%)

@NidhiKJha NidhiKJha added this pull request to the merge queue Apr 23, 2025
Merged via the queue into main with commit d526459 Apr 23, 2025
169 checks passed
@NidhiKJha NidhiKJha deleted the 32045-solana-toast-b branch April 23, 2025 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing toast when switching to a Solana account that is not connected to the current dapp
4 participants