Skip to content

chore: Bump @metamask/snaps-controllers to ^11.2.2 cp-12.17.0 #32196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Apr 23, 2025

Description

This bumps @metamask/snaps-controllers to ^11.2.2, which contains a fix for a rate limit issue when starting a Snap.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​snaps-controllers@​11.2.1 ⏵ 11.2.294 +110074100 +1100

View full report

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Apr 23, 2025
@Mrtenz Mrtenz changed the title Bump @metamask/snaps-controllers to ^11.2.2 chore: Bump @metamask/snaps-controllers to ^11.2.2 Apr 23, 2025
@Mrtenz Mrtenz marked this pull request as ready for review April 23, 2025 14:49
@Mrtenz Mrtenz enabled auto-merge April 23, 2025 14:53
@metamaskbot
Copy link
Collaborator

Builds ready [771f802]
UI Startup Metrics (1212 ± 53 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1212111413935312411306
load104895512195210821149
domContentLoaded104295112085210761140
domInteractive18136391729
firstPaint648151118841410551137
backgroundConnect74253810
firstReactRender21153952134
getState1253571629
initialActions002001
loadScripts80572694548836892
setupStore85213813
WebpackHomeuiStartup21521767268218922512444
load16671373215216017881954
domContentLoaded16601367214815917751943
domInteractive161264101344
firstPaint203631389142238333
backgroundConnect2811281292759
firstReactRender20856446127342372
getState134126141430
initialActions318135
loadScripts16551366214715817731919
setupStore1775482137
FirefoxBrowserifyHomeuiStartup13651138174212114121660
load12171015161312512711524
domContentLoaded12161015161212412711524
domInteractive1033924130116168
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect201397122043
firstReactRender23197382334
getState74112810
initialActions001001
loadScripts11981004159812512511509
setupStore6454567
WebpackHomeuiStartup15541347222616316731903
load13241154204314913801628
domContentLoaded13241153204314913791627
domInteractive83402573089144
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect261581112654
firstReactRender36305453945
getState124308301030
initialActions101011
loadScripts13021137197814613471605
setupStore95536918
cc: @HowardBraham
Benchmark value 204 exceeds gate value 199 for chrome webpack home mean firstPaint
Benchmark value 372 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1524 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1524 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 1509 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Benchmark value 54 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Sum of mean exceeds: 5ms | Sum of p95 exceeds: 99ms
Sum of all benchmark exceeds: 104ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@Mrtenz Mrtenz added this pull request to the merge queue Apr 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2025
@Mrtenz Mrtenz added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit 95d1774 Apr 24, 2025
177 of 179 checks passed
@Mrtenz Mrtenz deleted the mrtenz/[email protected] branch April 24, 2025 09:08
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2025
@micaelae micaelae changed the title chore: Bump @metamask/snaps-controllers to ^11.2.2 chore: Bump @metamask/snaps-controllers to ^11.2.2 cp-12.17.0 Apr 24, 2025
@DDDDDanica DDDDDanica added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants