Skip to content

fix: update padding for the gas fee pill component #32170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2025
+24 −23
Merged

fix: update padding for the gas fee pill component #32170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d27b737
fix: update padding gas fee pill
vinistevam Apr 22, 2025
98d9a5a
Merge branch 'main' into fix/update-padding-gas-fee-pill
vinistevam Apr 23, 2025
0950967
Merge branch 'main' into fix/update-padding-gas-fee-pill
vinistevam Apr 23, 2025
d64b46b
Merge branch 'main' into fix/update-padding-gas-fee-pill
vinistevam Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ui/pages/confirmations/components/confirm/info/__snapshots__/info.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,9 +280,9 @@ exports[`Info renders info section for approve request 1`] = `
$0.08
</p>
<div
class="mm-box mm-box--padding-inline-2 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
class="mm-box mm-box--padding-inline-start-1 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
data-testid="selected-gas-fee-token"
style="cursor: default;"
style="cursor: default; padding-inline-end: 6px;"
>
<div
class="mm-box"
Expand Down Expand Up @@ -619,9 +619,9 @@ exports[`Info renders info section for contract interaction request 1`] = `
$0.04
</p>
<div
class="mm-box mm-box--padding-inline-2 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
class="mm-box mm-box--padding-inline-start-1 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
data-testid="selected-gas-fee-token"
style="cursor: default;"
style="cursor: default; padding-inline-end: 6px;"
>
<div
class="mm-box"
Expand Down Expand Up @@ -1082,9 +1082,9 @@ exports[`Info renders info section for setApprovalForAll request 1`] = `
$0.08
</p>
<div
class="mm-box mm-box--padding-inline-2 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
class="mm-box mm-box--padding-inline-start-1 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
data-testid="selected-gas-fee-token"
style="cursor: default;"
style="cursor: default; padding-inline-end: 6px;"
>
<div
class="mm-box"
Expand Down
4 changes: 2 additions & 2 deletions ui/pages/confirmations/components/confirm/info/approve/__snapshots__/approve.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,9 +346,9 @@ exports[`<ApproveInfo /> renders component for approve request 1`] = `
0.0001
</p>
<div
class="mm-box mm-box--padding-inline-2 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
class="mm-box mm-box--padding-inline-start-1 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
data-testid="selected-gas-fee-token"
style="cursor: default;"
style="cursor: default; padding-inline-end: 6px;"
>
<div
class="mm-box"
Expand Down
4 changes: 2 additions & 2 deletions ...ents/confirm/info/base-transaction-info/__snapshots__/base-transaction-info.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,9 @@ exports[`<BaseTransactionInfo /> renders component for contract interaction requ
$0.04
</p>
<div
class="mm-box mm-box--padding-inline-2 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
class="mm-box mm-box--padding-inline-start-1 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
data-testid="selected-gas-fee-token"
style="cursor: default;"
style="cursor: default; padding-inline-end: 6px;"
>
<div
class="mm-box"
Expand Down
4 changes: 2 additions & 2 deletions ...tions/components/confirm/info/native-transfer/__snapshots__/native-transfer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,9 +412,9 @@ exports[`NativeTransferInfo renders correctly 1`] = `
$0.08
</p>
<div
class="mm-box mm-box--padding-inline-2 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
class="mm-box mm-box--padding-inline-start-1 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
data-testid="selected-gas-fee-token"
style="cursor: default;"
style="cursor: default; padding-inline-end: 6px;"
>
<div
class="mm-box"
Expand Down
4 changes: 2 additions & 2 deletions ...components/confirm/info/nft-token-transfer/__snapshots__/nft-token-transfer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,9 +442,9 @@ exports[`NFTTokenTransferInfo renders correctly 1`] = `
$0.08
</p>
<div
class="mm-box mm-box--padding-inline-2 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
class="mm-box mm-box--padding-inline-start-1 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
data-testid="selected-gas-fee-token"
style="cursor: default;"
style="cursor: default; padding-inline-end: 6px;"
>
<div
class="mm-box"
Expand Down
4 changes: 2 additions & 2 deletions ...firm/info/set-approval-for-all-info/__snapshots__/set-approval-for-all-info.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,9 +282,9 @@ exports[`<SetApprovalForAllInfo /> renders component for approve request 1`] = `
$0.08
</p>
<div
class="mm-box mm-box--padding-inline-2 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
class="mm-box mm-box--padding-inline-start-1 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
data-testid="selected-gas-fee-token"
style="cursor: default;"
style="cursor: default; padding-inline-end: 6px;"
>
<div
class="mm-box"
Expand Down
4 changes: 2 additions & 2 deletions ...nents/confirm/info/shared/edit-gas-fees-row/__snapshots__/edit-gas-fees-row.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ exports[`<EditGasFeesRow /> renders component 1`] = `
</div>
</div>
<div
class="mm-box mm-box--padding-inline-2 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
class="mm-box mm-box--padding-inline-start-1 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
data-testid="selected-gas-fee-token"
style="cursor: default;"
style="cursor: default; padding-inline-end: 6px;"
>
<div
class="mm-box"
Expand Down
4 changes: 2 additions & 2 deletions ...ponents/confirm/info/shared/gas-fees-section/__snapshots__/gas-fees-section.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ exports[`<GasFeesSection /> renders component for gas fees section 1`] = `
$0.04
</p>
<div
class="mm-box mm-box--padding-inline-2 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
class="mm-box mm-box--padding-inline-start-1 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
data-testid="selected-gas-fee-token"
style="cursor: default;"
style="cursor: default; padding-inline-end: 6px;"
>
<div
class="mm-box"
Expand Down
3 changes: 2 additions & 1 deletion ...rmations/components/confirm/info/shared/selected-gas-fee-token/selected-gas-fee-token.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,11 @@ export function SelectedGasFeeToken() {
borderRadius={BorderRadius.pill}
display={Display.InlineFlex}
alignItems={AlignItems.center}
paddingInline={2}
paddingInlineStart={1}
gap={1}
style={{
cursor: hasGasFeeTokens ? 'pointer' : 'default',
paddingInlineEnd: '6px',
}}
>
<GasFeeTokenIcon
Expand Down
4 changes: 2 additions & 2 deletions ...mations/components/confirm/info/token-transfer/__snapshots__/token-transfer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,9 +423,9 @@ exports[`TokenTransferInfo renders correctly 1`] = `
$0.08
</p>
<div
class="mm-box mm-box--padding-inline-2 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
class="mm-box mm-box--padding-inline-start-1 mm-box--display-inline-flex mm-box--gap-1 mm-box--align-items-center mm-box--background-color-background-alternative mm-box--rounded-pill"
data-testid="selected-gas-fee-token"
style="cursor: default;"
style="cursor: default; padding-inline-end: 6px;"
>
<div
class="mm-box"
Expand Down
Loading