fix: cp-12.17.0 mms-2255 double high cost alert #32158

GustavoRSSilva · 2025-04-21T22:35:48Z

Description

Fixs double alert cost

Related issues

Fixes: 31909

Manual testing steps

Go to Bridge page
Create a bridge with a small amount
see the double error

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-21T22:36:02Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-04-21T22:37:41Z

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers

ui/pages/bridge/prepare/prepare-bridge-page.tsx

metamaskbot · 2025-04-21T23:12:38Z

Builds ready [b1525e7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1192 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1192	1085	1429	58	1223	1300
			load	1031	922	1227	58	1061	1156
			domContentLoaded	1025	915	1214	58	1053	1150
			domInteractive	17	13	79	9	16	29
			firstPaint	700	72	1223	408	1049	1097
			backgroundConnect	8	4	27	4	8	21
			firstReactRender	20	15	58	7	21	33
			getState	13	5	34	7	17	27
			initialActions	0	0	1	0	0	1
			loadScripts	789	692	965	55	820	890
			setupStore	7	4	17	2	8	13
	Webpack	Home	uiStartup	2152	1762	2636	189	2283	2407
			load	1661	1346	2068	148	1770	1847
			domContentLoaded	1654	1342	2040	145	1760	1842
			domInteractive	16	11	55	10	13	48
			firstPaint	188	62	548	85	225	359
			backgroundConnect	27	10	218	24	27	64
			firstReactRender	229	57	383	120	334	364
			getState	15	4	288	28	15	23
			initialActions	3	1	7	1	4	5
			loadScripts	1649	1341	2015	144	1755	1840
			setupStore	23	7	303	40	21	33
Firefox	Browserify	Home	uiStartup	1338	1139	1677	114	1399	1586
			load	1191	1022	1558	113	1252	1425
			domContentLoaded	1191	1022	1558	113	1252	1425
			domInteractive	109	36	369	49	118	185
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	49	7	20	38
			firstReactRender	22	18	44	4	23	31
			getState	7	4	26	2	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1173	1007	1542	113	1237	1407
			setupStore	7	4	164	16	6	7
	Webpack	Home	uiStartup	1548	1363	2082	142	1621	1860
			load	1324	1177	1893	128	1392	1589
			domContentLoaded	1324	1176	1892	128	1391	1589
			domInteractive	82	37	241	25	93	121
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	71	7	24	37
			firstReactRender	36	29	52	5	37	48
			getState	9	4	33	5	10	27
			initialActions	1	0	2	1	1	1
			loadScripts	1304	1155	1823	126	1375	1569
			setupStore	8	5	30	3	8	12

Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 359 exceeds gate value 334 for chrome webpack home p95 firstPaint
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 29ms
Sum of all benchmark exceeds: 29ms

Bundle size diffs

background: 0 Bytes (0%)
ui: -317 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-22T12:40:16Z

Builds ready [e20134d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1223 ± 70 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1223	1116	1715	70	1256	1308
			load	1054	954	1373	56	1078	1140
			domContentLoaded	1048	951	1369	56	1072	1135
			domInteractive	17	14	63	7	16	27
			firstPaint	743	118	1373	413	1067	1132
			backgroundConnect	8	4	37	5	8	15
			firstReactRender	20	15	34	4	21	28
			getState	13	4	117	13	18	31
			initialActions	0	0	1	0	0	1
			loadScripts	810	719	1105	53	834	891
			setupStore	8	4	25	3	8	13
	Webpack	Home	uiStartup	2095	1743	2492	177	2232	2339
			load	1628	1362	1924	122	1705	1808
			domContentLoaded	1622	1359	1907	121	1700	1798
			domInteractive	16	11	63	10	13	49
			firstPaint	183	69	413	61	228	292
			backgroundConnect	31	9	362	48	27	63
			firstReactRender	190	56	383	125	338	360
			getState	12	4	35	7	13	27
			initialActions	3	1	5	1	3	4
			loadScripts	1617	1357	1885	121	1696	1795
			setupStore	22	7	290	39	21	36
Firefox	Browserify	Home	uiStartup	1422	1223	1866	110	1481	1640
			load	1265	1051	1695	108	1344	1446
			domContentLoaded	1265	1051	1694	108	1344	1445
			domInteractive	115	37	357	49	128	219
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	51	6	22	37
			firstReactRender	23	19	30	2	24	28
			getState	9	4	162	16	8	15
			initialActions	0	0	1	0	0	1
			loadScripts	1246	1039	1675	107	1320	1431
			setupStore	7	4	36	5	7	11
	Webpack	Home	uiStartup	1559	1345	2294	155	1613	1855
			load	1334	1172	2104	143	1388	1602
			domContentLoaded	1333	1171	2104	143	1387	1601
			domInteractive	80	40	125	17	91	115
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	15	133	14	26	43
			firstReactRender	35	29	53	4	37	44
			getState	12	4	220	22	10	31
			initialActions	0	0	2	1	1	1
			loadScripts	1311	1157	1973	137	1372	1577
			setupStore	9	5	46	6	9	21

cc: @HowardBraham
Benchmark value 1423 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1266 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1265 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 1247 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 219 exceeds gate value 195 for firefox browserify home p95 domInteractive
Sum of mean exceeds: 88ms | Sum of p95 exceeds: 24ms
Sum of all benchmark exceeds: 112ms

Bundle size diffs

background: 0 Bytes (0%)
ui: -317 Bytes (0%)
common: 0 Bytes (0%)

micaelae · 2025-04-23T14:50:35Z

@GustavoRSSilva if you change the pr title to start with "fix: cp-12.17.0" a cherry pick is automatically created

metamaskbot · 2025-04-23T18:00:49Z

Builds ready [d5d6c46]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1387 ± 105 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1387	1193	1684	105	1439	1580
			load	1185	993	1501	105	1239	1410
			domContentLoaded	1174	987	1491	100	1234	1376
			domInteractive	21	13	81	9	23	32
			firstPaint	702	103	1506	486	1189	1372
			backgroundConnect	12	4	196	26	9	19
			firstReactRender	28	17	157	18	27	60
			getState	15	5	42	8	20	30
			initialActions	0	0	1	0	0	1
			loadScripts	900	747	1147	89	950	1089
			setupStore	10	5	27	4	11	18
	Webpack	Home	uiStartup	2122	1739	2614	185	2245	2376
			load	1633	1370	2020	140	1734	1821
			domContentLoaded	1625	1366	1998	137	1726	1807
			domInteractive	15	11	63	10	13	47
			firstPaint	198	74	411	71	257	339
			backgroundConnect	26	10	90	15	30	65
			firstReactRender	224	55	382	115	331	361
			getState	14	4	255	25	14	29
			initialActions	3	1	7	1	3	5
			loadScripts	1620	1365	1975	135	1724	1804
			setupStore	17	6	44	7	20	33
Firefox	Browserify	Home	uiStartup	1363	1153	1920	133	1425	1580
			load	1215	1009	1759	129	1280	1442
			domContentLoaded	1214	1009	1758	129	1280	1442
			domInteractive	111	38	347	48	125	207
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	123	13	20	35
			firstReactRender	22	19	50	4	22	27
			getState	9	4	170	17	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1195	996	1745	128	1261	1406
			setupStore	6	4	26	3	6	8
	Webpack	Home	uiStartup	1511	1332	1891	128	1585	1804
			load	1289	1152	1627	110	1336	1527
			domContentLoaded	1288	1152	1626	110	1336	1526
			domInteractive	82	41	224	25	96	127
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	15	294	30	25	58
			firstReactRender	35	28	71	6	36	47
			getState	9	4	31	5	9	20
			initialActions	1	0	1	0	1	1
			loadScripts	1264	1137	1579	104	1315	1475
			setupStore	13	5	294	30	9	31

cc: @HowardBraham
Benchmark value 1387 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1186 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1175 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 21 exceeds gate value 20 for chrome browserify home mean domInteractive
Benchmark value 13 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 901 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1581 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1411 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1376 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1372 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 20 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 60 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 1089 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 339 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 207 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 58 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 469ms | Sum of p95 exceeds: 1021ms
Sum of all benchmark exceeds: 1490ms

Bundle size diffs

background: 0 Bytes (0%)
ui: -317 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-23T18:24:18Z

Builds ready [5c9c1d4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1214 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1214	1098	1503	62	1247	1329
			load	1051	957	1279	56	1084	1157
			domContentLoaded	1045	952	1272	55	1079	1151
			domInteractive	17	13	60	6	17	28
			firstPaint	661	79	1198	423	1055	1132
			backgroundConnect	7	4	22	3	7	11
			firstReactRender	20	15	50	6	21	33
			getState	13	5	39	8	20	30
			initialActions	0	0	1	0	0	1
			loadScripts	806	703	1030	53	835	922
			setupStore	7	5	13	2	8	12
	Webpack	Home	uiStartup	2090	1692	2518	156	2185	2295
			load	1618	1319	2006	125	1714	1793
			domContentLoaded	1612	1316	1982	124	1711	1786
			domInteractive	16	11	60	12	13	52
			firstPaint	182	76	336	64	230	318
			backgroundConnect	25	11	234	24	25	60
			firstReactRender	207	54	366	120	332	359
			getState	10	4	29	5	12	18
			initialActions	3	1	6	1	3	4
			loadScripts	1604	1314	1959	125	1707	1783
			setupStore	17	6	153	15	18	25
Firefox	Browserify	Home	uiStartup	1392	1221	1712	99	1450	1593
			load	1239	1037	1562	100	1306	1452
			domContentLoaded	1239	1037	1561	100	1305	1452
			domInteractive	106	37	275	38	123	180
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	105	13	20	39
			firstReactRender	23	20	36	3	23	29
			getState	7	4	25	3	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1219	1022	1547	99	1288	1399
			setupStore	6	4	31	3	6	8
	Webpack	Home	uiStartup	1527	1359	2111	129	1587	1820
			load	1307	1161	1900	118	1353	1566
			domContentLoaded	1306	1161	1900	118	1353	1566
			domInteractive	85	59	195	23	90	137
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	107	13	23	45
			firstReactRender	36	29	99	8	38	45
			getState	9	5	47	7	9	29
			initialActions	1	0	1	0	1	1
			loadScripts	1286	1142	1813	114	1327	1540
			setupStore	9	5	61	9	8	36

Benchmark value 36 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 8ms
Sum of all benchmark exceeds: 8ms

Bundle size diffs

background: 0 Bytes (0%)
ui: -317 Bytes (0%)
common: 0 Bytes (0%)

fix: mms-2255 double high cost alert

b1525e7

metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label Apr 21, 2025

GustavoRSSilva marked this pull request as ready for review April 21, 2025 22:36

GustavoRSSilva requested a review from a team as a code owner April 21, 2025 22:36

GustavoRSSilva added 2 commits April 22, 2025 08:17

Merge branch 'main' into mms-2255-double-high-cost-alert

7fcf118

Merge branch 'main' into mms-2255-double-high-cost-alert

e20134d

GustavoRSSilva mentioned this pull request Apr 22, 2025

[Bug]: High cost alert is shown twice when bridging #31909

Closed

Merge branch 'main' into mms-2255-double-high-cost-alert

c23874d

bfullam approved these changes Apr 23, 2025

View reviewed changes

micaelae approved these changes Apr 23, 2025

View reviewed changes

Merge branch 'main' into mms-2255-double-high-cost-alert

fb9f4cc

GustavoRSSilva enabled auto-merge April 23, 2025 16:59

GustavoRSSilva added 2 commits April 23, 2025 17:59

Merge branch 'main' into mms-2255-double-high-cost-alert

d5d6c46

Merge branch 'main' into mms-2255-double-high-cost-alert

5c9c1d4

GustavoRSSilva changed the title ~~fix: mms-2255 double high cost alert~~ fix: cp-12.17.0 mms-2255 double high cost alert Apr 23, 2025

GustavoRSSilva added this pull request to the merge queue Apr 23, 2025

DDDDDanica added the extension-delivery label Apr 23, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2025

GustavoRSSilva added this pull request to the merge queue Apr 24, 2025

Merged via the queue into main with commit 25b0bfc Apr 24, 2025
174 checks passed

GustavoRSSilva deleted the mms-2255-double-high-cost-alert branch April 24, 2025 07:53

github-actions bot locked and limited conversation to collaborators Apr 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: cp-12.17.0 mms-2255 double high cost alert #32158

fix: cp-12.17.0 mms-2255 double high cost alert #32158

GustavoRSSilva commented Apr 21, 2025 •

edited

Loading

github-actions bot commented Apr 21, 2025

metamaskbot commented Apr 21, 2025

metamaskbot commented Apr 21, 2025

metamaskbot commented Apr 22, 2025

micaelae commented Apr 23, 2025

metamaskbot commented Apr 23, 2025

metamaskbot commented Apr 23, 2025

fix: cp-12.17.0 mms-2255 double high cost alert #32158

fix: cp-12.17.0 mms-2255 double high cost alert #32158

Conversation

GustavoRSSilva commented Apr 21, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 21, 2025

metamaskbot commented Apr 21, 2025

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Apr 21, 2025

metamaskbot commented Apr 22, 2025

micaelae commented Apr 23, 2025

metamaskbot commented Apr 23, 2025

metamaskbot commented Apr 23, 2025

GustavoRSSilva commented Apr 21, 2025 •

edited

Loading