chore: Remove support link on the home page #32157

amandaye0h · 2025-04-21T22:11:29Z

Description

This removes the support link across Tokens, NFTs and the Activity tabs. It improves the IA of the home page, ensuring users can focus on their assets.

Part of MaWaSB updates.

Related issues

Fixes:

Manual testing steps

Open MetaMask
Scroll down on the Tokens page
Navigate to the NFTs and Activity tab

Screenshots/Recordings

Before

Screen.Recording.2025-04-23.at.3.14.29.AM.mov

After

Screen.Recording.2025-04-22.at.6.14.07.AM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-21T22:11:46Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-04-21T22:13:29Z

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

ui/components/multichain/account-overview/account-overview-tabs.tsx

metamaskbot · 2025-04-21T22:49:26Z

Builds ready [110841d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1184 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1184	1074	1461	67	1216	1308
			load	1022	932	1186	58	1053	1144
			domContentLoaded	1017	929	1182	57	1047	1139
			domInteractive	16	13	29	4	16	26
			firstPaint	600	79	1182	412	1015	1110
			backgroundConnect	6	4	18	2	7	8
			firstReactRender	21	15	44	6	22	33
			getState	14	5	106	14	18	34
			initialActions	0	0	1	0	0	1
			loadScripts	782	676	946	56	807	896
			setupStore	8	4	18	2	8	13
	Webpack	Home	uiStartup	2099	1699	2484	181	2236	2352
			load	1626	1251	1915	134	1730	1846
			domContentLoaded	1620	1247	1897	133	1724	1840
			domInteractive	16	11	63	10	13	41
			firstPaint	189	62	638	91	224	355
			backgroundConnect	26	9	332	33	26	55
			firstReactRender	191	55	393	121	320	364
			getState	13	4	269	26	12	28
			initialActions	3	1	6	1	3	5
			loadScripts	1615	1246	1874	132	1721	1817
			setupStore	22	6	311	40	21	35
Firefox	Browserify	Home	uiStartup	1345	1144	1799	131	1424	1593
			load	1200	1027	1638	132	1275	1474
			domContentLoaded	1199	1026	1637	132	1274	1474
			domInteractive	102	40	181	28	115	166
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	209	20	20	36
			firstReactRender	22	19	55	5	22	33
			getState	9	4	160	16	8	16
			initialActions	0	0	1	0	0	1
			loadScripts	1179	1010	1616	129	1253	1459
			setupStore	9	4	182	24	6	21
	Webpack	Home	uiStartup	1518	1342	1813	109	1608	1732
			load	1299	1152	1557	96	1350	1496
			domContentLoaded	1298	1150	1557	96	1349	1496
			domInteractive	82	57	144	20	91	130
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	16	86	13	26	63
			firstReactRender	36	29	62	5	38	47
			getState	10	4	38	6	10	28
			initialActions	0	0	2	1	1	1
			loadScripts	1276	1135	1514	94	1325	1471
			setupStore	8	5	23	2	8	11

cc: @HowardBraham
Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 355 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 63 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Sum of mean exceeds: 1ms | Sum of p95 exceeds: 36ms
Sum of all benchmark exceeds: 37ms

Bundle size diffs

background: 0 Bytes (0%)
ui: -710 Bytes (-0.01%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-22T00:20:36Z

Builds ready [c1d8c06]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1210 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1210	1104	1423	65	1257	1335
			load	1050	942	1200	60	1093	1163
			domContentLoaded	1044	938	1190	59	1084	1157
			domInteractive	17	13	60	6	17	27
			firstPaint	720	84	1199	416	1070	1145
			backgroundConnect	7	4	20	2	8	9
			firstReactRender	20	15	48	5	20	31
			getState	13	5	33	8	20	30
			initialActions	0	0	1	0	0	1
			loadScripts	807	700	946	58	847	919
			setupStore	8	4	22	2	8	13
	Webpack	Home	uiStartup	2162	1769	2525	172	2280	2435
			load	1664	1371	1952	134	1775	1861
			domContentLoaded	1657	1367	1941	133	1769	1855
			domInteractive	16	11	68	11	13	49
			firstPaint	187	71	378	67	230	329
			backgroundConnect	26	10	95	15	26	58
			firstReactRender	230	56	410	120	343	368
			getState	12	4	58	8	15	27
			initialActions	3	1	7	1	4	5
			loadScripts	1652	1366	1926	133	1765	1853
			setupStore	23	7	285	36	21	38
Firefox	Browserify	Home	uiStartup	1353	1198	1822	113	1413	1586
			load	1208	1023	1665	118	1275	1451
			domContentLoaded	1208	1022	1664	118	1275	1451
			domInteractive	103	42	218	32	116	172
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	100	13	20	40
			firstReactRender	22	20	32	2	22	26
			getState	9	4	167	16	8	16
			initialActions	0	0	1	0	0	1
			loadScripts	1188	1005	1646	119	1255	1437
			setupStore	6	4	34	3	6	8
	Webpack	Home	uiStartup	1494	1313	1839	117	1569	1731
			load	1280	1137	1644	103	1334	1481
			domContentLoaded	1280	1136	1644	103	1334	1481
			domInteractive	82	40	161	23	91	135
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	73	8	23	42
			firstReactRender	35	29	54	4	36	44
			getState	8	4	57	6	9	18
			initialActions	0	0	1	0	1	1
			loadScripts	1261	1120	1630	103	1311	1463
			setupStore	8	5	58	6	8	17

Bundle size diffs

background: 0 Bytes (0%)
ui: -731 Bytes (-0.01%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-23T18:11:54Z

Builds ready [4bba4fd]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1227 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1227	1114	1368	60	1262	1357
			load	1057	959	1194	53	1083	1173
			domContentLoaded	1051	955	1188	52	1078	1168
			domInteractive	18	13	63	7	17	31
			firstPaint	716	143	1199	417	1072	1126
			backgroundConnect	7	4	18	2	7	12
			firstReactRender	23	16	43	6	24	36
			getState	14	5	41	9	20	31
			initialActions	0	0	1	0	0	1
			loadScripts	810	722	934	49	837	915
			setupStore	8	4	18	3	8	13
	Webpack	Home	uiStartup	2124	1743	2689	181	2249	2388
			load	1629	1302	2104	138	1735	1852
			domContentLoaded	1622	1297	2093	136	1726	1840
			domInteractive	16	11	57	11	14	49
			firstPaint	200	72	1605	161	248	349
			backgroundConnect	29	9	236	31	28	74
			firstReactRender	216	54	392	123	341	363
			getState	18	4	295	42	14	33
			initialActions	3	1	8	1	3	6
			loadScripts	1617	1293	2069	135	1723	1816
			setupStore	19	7	294	28	21	33
Firefox	Browserify	Home	uiStartup	1358	1162	1716	111	1430	1596
			load	1207	1001	1501	110	1298	1405
			domContentLoaded	1207	1001	1501	110	1298	1404
			domInteractive	109	42	283	37	121	176
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	65	8	21	38
			firstReactRender	22	19	33	3	22	27
			getState	9	4	224	22	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1189	988	1479	109	1280	1384
			setupStore	7	4	34	5	6	21
	Webpack	Home	uiStartup	1467	1310	1774	96	1535	1674
			load	1258	1129	1556	85	1312	1428
			domContentLoaded	1257	1129	1556	85	1311	1428
			domInteractive	86	37	249	35	96	159
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	45	6	22	37
			firstReactRender	35	28	85	7	37	43
			getState	10	4	32	7	9	29
			initialActions	0	0	1	0	1	1
			loadScripts	1238	1114	1539	84	1294	1407
			setupStore	8	5	40	5	8	22

Benchmark value 201 exceeds gate value 199 for chrome webpack home mean firstPaint
Benchmark value 349 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 159 exceeds gate value 156 for firefox webpack home p95 domInteractive
Sum of mean exceeds: 2ms | Sum of p95 exceeds: 18ms
Sum of all benchmark exceeds: 20ms

Bundle size diffs

background: 0 Bytes (0%)
ui: -731 Bytes (-0.01%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-23T19:47:11Z

Builds ready [2055d7e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1229 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1229	1135	1496	67	1264	1345
			load	1060	961	1233	58	1092	1173
			domContentLoaded	1054	956	1227	57	1085	1168
			domInteractive	18	13	62	7	17	29
			firstPaint	706	93	1184	418	1077	1141
			backgroundConnect	7	4	21	3	8	11
			firstReactRender	20	16	56	4	21	24
			getState	13	5	43	8	19	30
			initialActions	0	0	1	0	0	1
			loadScripts	813	725	953	54	842	915
			setupStore	8	4	18	2	8	12
	Webpack	Home	uiStartup	2137	1723	2457	163	2269	2342
			load	1655	1343	1954	129	1764	1828
			domContentLoaded	1648	1339	1944	128	1754	1821
			domInteractive	16	12	56	10	13	46
			firstPaint	185	59	370	65	227	308
			backgroundConnect	27	10	280	29	31	60
			firstReactRender	224	55	380	119	333	358
			getState	13	4	65	9	15	34
			initialActions	3	1	7	1	4	5
			loadScripts	1643	1338	1942	129	1751	1820
			setupStore	22	7	289	38	21	34
Firefox	Browserify	Home	uiStartup	1380	1208	1731	114	1440	1617
			load	1228	1043	1599	116	1281	1486
			domContentLoaded	1228	1042	1599	116	1281	1486
			domInteractive	105	41	234	29	117	149
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	45	5	23	31
			firstReactRender	23	19	53	4	23	27
			getState	8	4	64	7	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1210	1030	1580	116	1264	1462
			setupStore	6	4	24	2	6	8
	Webpack	Home	uiStartup	1510	1309	1905	119	1585	1759
			load	1296	1139	1654	103	1351	1532
			domContentLoaded	1296	1139	1654	103	1351	1532
			domInteractive	91	33	344	43	99	182
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	14	55	6	22	28
			firstReactRender	35	29	66	5	36	45
			getState	7	4	30	3	8	12
			initialActions	0	0	1	0	1	1
			loadScripts	1277	1125	1637	102	1331	1512
			setupStore	9	5	52	7	8	21

Benchmark value 182 exceeds gate value 156 for firefox webpack home p95 domInteractive
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 26ms
Sum of all benchmark exceeds: 26ms

Bundle size diffs

background: 0 Bytes (0%)
ui: -731 Bytes (-0.01%)
common: 0 Bytes (0%)

vinnyhoward

Less cluttered. I like it LGTM

amandaye0h · 2025-04-23T22:07:40Z

Thanks for the speedy review!!

chore: Remove support link on home page

110841d

metamaskbot added the team-assets label Apr 21, 2025

amandaye0h added 2 commits April 22, 2025 07:33

Remove unused imports

dafb75c

Fix linting issues

c1d8c06

Merge branch 'main' into support-link-removal

78a441d

amandaye0h changed the title ~~chore: Remove support link on home page~~ chore: Remove support link on the home page Apr 22, 2025

Merge branch 'main' into support-link-removal

4bba4fd

Merge branch 'main' into support-link-removal

2055d7e

amandaye0h added area-design Design bug (previously known as papercuts - ask Hilary for more detail) type-enhancement labels Apr 23, 2025

amandaye0h marked this pull request as ready for review April 23, 2025 18:56

amandaye0h requested a review from a team as a code owner April 23, 2025 18:56

darkwing approved these changes Apr 23, 2025

View reviewed changes

vinnyhoward approved these changes Apr 23, 2025

View reviewed changes

amandaye0h added this pull request to the merge queue Apr 23, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2025

georgewrmarshall added this pull request to the merge queue Apr 23, 2025

Merged via the queue into main with commit a72d529 Apr 24, 2025
177 checks passed

georgewrmarshall deleted the support-link-removal branch April 24, 2025 00:37

github-actions bot locked and limited conversation to collaborators Apr 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Remove support link on the home page #32157

chore: Remove support link on the home page #32157

amandaye0h commented Apr 21, 2025 •

edited

Loading

github-actions bot commented Apr 21, 2025

metamaskbot commented Apr 21, 2025

metamaskbot commented Apr 21, 2025

metamaskbot commented Apr 22, 2025

metamaskbot commented Apr 23, 2025

metamaskbot commented Apr 23, 2025

vinnyhoward left a comment

amandaye0h commented Apr 23, 2025

chore: Remove support link on the home page #32157

chore: Remove support link on the home page #32157

Conversation

amandaye0h commented Apr 21, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 21, 2025

metamaskbot commented Apr 21, 2025

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Apr 21, 2025

metamaskbot commented Apr 22, 2025

metamaskbot commented Apr 23, 2025

metamaskbot commented Apr 23, 2025

vinnyhoward left a comment

Choose a reason for hiding this comment

amandaye0h commented Apr 23, 2025

amandaye0h commented Apr 21, 2025 •

edited

Loading