-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat: Design parity improvements (splash screen and swap setup) #32134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds ready [5dd1a48]
UI Startup Metrics (1191 ± 58 ms)
Benchmark value 51 exceeds gate value 45 for firefox webpack home p95 backgroundConnect Sum of mean exceeds: 8ms | Sum of p95 exceeds: 6ms Sum of all benchmark exceeds: 14ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5aaa24d
to
a0d8db0
Compare
Builds ready [a0d8db0]
UI Startup Metrics (1211 ± 65 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a0d8db0
to
4a01bfd
Compare
4a01bfd
to
44a946b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
44a946b
to
4b8c6df
Compare
Builds ready [4b8c6df]
UI Startup Metrics (1213 ± 52 ms)
Benchmark value 53 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Sum of mean exceeds: 0ms | Sum of p95 exceeds: 17ms Sum of all benchmark exceeds: 17ms Bundle size diffs
|
Description
Related issues
Fixes: #32133
Manual testing steps
#remote
and#remote/setup-swaps
and go through the setup flowScreenshots/Recordings
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist