Skip to content

feat: Design parity improvements (splash screen and swap setup) #32134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

kevinbluer
Copy link
Member

@kevinbluer kevinbluer commented Apr 18, 2025

Description

  • Increases parity with designs for both the splash screen and swap setup flow
  • Includes a number of minor refactors

image

image

Open in GitHub Codespaces

Related issues

Fixes: #32133

Manual testing steps

  1. Create the build (yarn webpack)
  2. Go to #remote and #remote/setup-swaps and go through the setup flow
  3. Designs for reference
  • Note to override the vaultRemoteMode feature flag (which will implicitly default to disabled), the configuration steps are available here. Example.manifest-overrides.json:
{
  "_flags": {
    "remoteFeatureFlags": {
      "vaultRemoteMode": true
    }
  }
}

Screenshots/Recordings

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-vault MetaMask Vault Team label Apr 18, 2025
@kevinbluer kevinbluer marked this pull request as ready for review April 18, 2025 22:19
@kevinbluer kevinbluer added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 18, 2025
matallui
matallui previously approved these changes Apr 18, 2025
Copy link
Contributor

@matallui matallui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [5dd1a48]
UI Startup Metrics (1191 ± 58 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1191108413915812241301
load103094712194910581131
domContentLoaded102494212154910491124
domInteractive17136181629
firstPaint661134122540910431109
backgroundConnect74222711
firstReactRender20164452028
getState1344381928
initialActions001001
loadScripts79071096547819877
setupStore75273812
WebpackHomeuiStartup21251744249016722472363
load16431353192312317571795
domContentLoaded16361349189912217511788
domInteractive161166121347
firstPaint1836833660232300
backgroundConnect261082132957
firstReactRender21556376121337359
getState144289281423
initialActions316145
loadScripts16311347187612317481786
setupStore256275432134
FirefoxBrowserifyHomeuiStartup13411170170012313891636
load1199992156512412501476
domContentLoaded1199992156412412501476
domInteractive1053926636114187
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213187211938
firstReactRender22184952233
getState74263811
initialActions001001
loadScripts1179978154812412291458
setupStore5431367
WebpackHomeuiStartup15001366183410915691746
load1277116415399013241506
domContentLoaded1277116415399013241505
domInteractive77471581980124
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2414111132451
firstReactRender35286553642
getState95305921
initialActions102111
loadScripts1256113615189113031489
setupStore85566815
Benchmark value 183 exceeds gate value 175 for chrome webpack home mean firstPaint
Benchmark value 51 exceeds gate value 45 for firefox webpack home p95 backgroundConnect
Sum of mean exceeds: 8ms | Sum of p95 exceeds: 6ms
Sum of all benchmark exceeds: 14ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -32 Bytes (0%)
  • ui: 5.58 KiB (0.08%)
  • common: 276 Bytes (0%)

caieu
caieu previously approved these changes Apr 21, 2025
Copy link
Contributor

@caieu caieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbluer kevinbluer added this pull request to the merge queue Apr 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 21, 2025
@kevinbluer kevinbluer added this pull request to the merge queue Apr 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 21, 2025
@kevinbluer kevinbluer dismissed stale reviews from caieu and matallui via 5aaa24d April 21, 2025 19:58
@kevinbluer kevinbluer force-pushed the feat/splash-swap-setup-design-parity branch 2 times, most recently from 5aaa24d to a0d8db0 Compare April 21, 2025 21:35
@metamaskbot
Copy link
Collaborator

Builds ready [a0d8db0]
UI Startup Metrics (1211 ± 65 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1211110214206512521343
load104795312395910801163
domContentLoaded104294812325810731157
domInteractive17136461628
firstPaint686132124842010541114
backgroundConnect6410178
firstReactRender22164772239
getState1343382029
initialActions004001
loadScripts80671698256841923
setupStore75242811
WebpackHomeuiStartup21051731261016622062369
load16321346203712917171822
domContentLoaded16251342202612817141819
domInteractive151167101341
firstPaint1877233057228300
backgroundConnect24975152566
firstReactRender19956380125330367
getState124169161319
initialActions318135
loadScripts16201341200212717121817
setupStore247290471939
FirefoxBrowserifyHomeuiStartup13541171177511214151607
load12111036164912012721466
domContentLoaded12111035164912012721465
domInteractive1083925139125191
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113112132044
firstReactRender22195642327
getState74263811
initialActions002001
loadScripts11921024163212012561449
setupStore6428368
WebpackHomeuiStartup14981296181010715601719
load1283112415389513521479
domContentLoaded1283112415389513511479
domInteractive80371462186127
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2114102102132
firstReactRender34294643642
getState84326829
initialActions002111
loadScripts1264110915239513361462
setupStore95779821
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 1.82 KiB (0.03%)
  • common: 0 Bytes (0%)

Copy link
Contributor

@caieu caieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matallui matallui added this pull request to the merge queue Apr 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2025
@kevinbluer kevinbluer added this pull request to the merge queue Apr 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2025
@kevinbluer kevinbluer added this pull request to the merge queue Apr 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2025
@kevinbluer kevinbluer added this pull request to the merge queue Apr 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2025
@kevinbluer kevinbluer added this pull request to the merge queue Apr 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2025
@kevinbluer kevinbluer force-pushed the feat/splash-swap-setup-design-parity branch from a0d8db0 to 4a01bfd Compare April 23, 2025 01:11
@kevinbluer kevinbluer enabled auto-merge April 23, 2025 01:13
@kevinbluer kevinbluer force-pushed the feat/splash-swap-setup-design-parity branch from 4a01bfd to 44a946b Compare April 23, 2025 13:23
Copy link
Contributor

@caieu caieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbluer kevinbluer force-pushed the feat/splash-swap-setup-design-parity branch from 44a946b to 4b8c6df Compare April 23, 2025 14:49
@metamaskbot
Copy link
Collaborator

Builds ready [4b8c6df]
UI Startup Metrics (1213 ± 52 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1213112313885212441326
load104291611885010751138
domContentLoaded103691111814910711133
domInteractive18136391733
firstPaint668137115741310511101
backgroundConnect7412179
firstReactRender22159192139
getState1443371926
initialActions001001
loadScripts79967495148831895
setupStore85233815
WebpackHomeuiStartup20501711257918421592304
load15931329199513616981775
domContentLoaded15871325198413516911765
domInteractive161168111349
firstPaint1836844061233292
backgroundConnect23965122753
firstReactRender18754467123328364
getState124153161329
initialActions317134
loadScripts15821324196013416881759
setupStore1564471930
FirefoxBrowserifyHomeuiStartup13381170169411713971586
load11931010157212112511439
domContentLoaded11931010157212112501439
domInteractive1103625741121208
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect211397122040
firstReactRender23195262332
getState9416416719
initialActions001001
loadScripts1174997155712112361423
setupStore841931969
WebpackHomeuiStartup15511348189513216471822
load13251176162411114171569
domContentLoaded13251175162411114171568
domInteractive84341842486132
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect241386112453
firstReactRender35305043745
getState12428228928
initialActions001011
loadScripts13041162160810913981526
setupStore1057710823
Benchmark value 208 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 53 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 17ms
Sum of all benchmark exceeds: 17ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 1.82 KiB (0.03%)
  • common: 0 Bytes (0%)

@kevinbluer kevinbluer added this pull request to the merge queue Apr 23, 2025
Merged via the queue into main with commit b6498e9 Apr 23, 2025
168 of 169 checks passed
@kevinbluer kevinbluer deleted the feat/splash-swap-setup-design-parity branch April 23, 2025 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-vault MetaMask Vault Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screens - Swap Setup Design Parity
4 participants