fix: cp-12.16.1 fix display nft full image #31967

sahar-fehri · 2025-04-15T07:57:04Z

Description

Fixes display full nft image on a different network.

Related issues

Fixes: #31965

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2025-04-15.at.13.24.07.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-15T07:57:18Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-04-15T08:33:45Z

Builds ready [00a2a9b]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1216 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1216	1085	1455	66	1259	1332
			load	1052	955	1225	57	1084	1158
			domContentLoaded	1047	951	1203	56	1078	1153
			domInteractive	19	13	95	11	17	35
			firstPaint	715	137	1210	419	1064	1150
			backgroundConnect	6	4	15	2	7	10
			firstReactRender	20	16	38	4	20	27
			getState	13	5	41	8	19	25
			initialActions	0	0	2	0	0	1
			loadScripts	809	727	960	55	842	915
			setupStore	8	5	25	3	8	13
	Webpack	Home	uiStartup	2156	1762	2651	162	2255	2443
			load	1651	1354	2049	124	1736	1822
			domContentLoaded	1644	1350	2031	123	1728	1816
			domInteractive	15	11	69	10	12	42
			firstPaint	176	61	403	65	190	340
			backgroundConnect	26	9	174	20	27	58
			firstReactRender	238	55	379	119	340	361
			getState	15	3	283	28	15	37
			initialActions	3	1	7	1	3	5
			loadScripts	1639	1349	2007	122	1725	1814
			setupStore	17	7	54	7	19	30
Firefox	Browserify	Home	uiStartup	1347	1178	1730	104	1403	1544
			load	1203	1021	1608	113	1267	1416
			domContentLoaded	1203	1021	1607	112	1267	1416
			domInteractive	98	39	215	28	111	144
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	14	110	10	19	26
			firstReactRender	22	19	57	5	22	32
			getState	7	4	27	2	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1185	1008	1591	113	1251	1402
			setupStore	6	4	25	3	6	10
	Webpack	Home	uiStartup	1521	1348	1940	134	1578	1846
			load	1294	1153	1718	115	1361	1536
			domContentLoaded	1294	1153	1717	115	1361	1536
			domInteractive	82	31	149	26	92	139
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	79	8	22	29
			firstReactRender	35	28	59	5	38	45
			getState	13	4	311	31	9	30
			initialActions	0	0	1	0	1	1
			loadScripts	1276	1138	1702	115	1343	1521
			setupStore	13	5	284	37	8	20

Bundle size diffs

background: 0 Bytes (0%)
ui: 439 Bytes (0.01%)
common: 0 Bytes (0%)

sahar-fehri · 2025-04-15T09:19:30Z

test/e2e/tests/tokens/nft/view-nft-full-image.spec.ts

+import NFTDetailsPage from '../../../page-objects/pages/nft-details-page';
+
+describe('NFT full', function () {
+  it('displays NFT full image when NFT is on a network different from the current network', async function () {


added this e2e test that fails on main

metamaskbot · 2025-04-15T09:22:25Z

Builds ready [6142d59]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1217 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1217	1090	1425	65	1253	1338
			load	1050	960	1245	59	1080	1159
			domContentLoaded	1044	954	1241	58	1074	1151
			domInteractive	17	13	60	7	16	29
			firstPaint	671	101	1250	426	1051	1162
			backgroundConnect	6	4	13	2	7	10
			firstReactRender	20	16	45	4	21	26
			getState	12	5	38	8	17	29
			initialActions	0	0	1	0	0	1
			loadScripts	807	724	1004	56	837	915
			setupStore	7	4	33	3	7	14
	Webpack	Home	uiStartup	2201	1776	2573	176	2316	2490
			load	1694	1361	2039	146	1807	1918
			domContentLoaded	1686	1357	2025	145	1800	1910
			domInteractive	17	11	65	10	14	44
			firstPaint	183	74	414	68	212	360
			backgroundConnect	33	11	361	44	31	69
			firstReactRender	204	56	376	122	320	357
			getState	19	4	322	42	16	40
			initialActions	3	1	6	1	4	5
			loadScripts	1681	1356	2000	144	1798	1899
			setupStore	24	6	302	37	23	45
Firefox	Browserify	Home	uiStartup	1350	1163	1690	116	1414	1596
			load	1197	1038	1545	114	1276	1418
			domContentLoaded	1197	1038	1545	114	1276	1418
			domInteractive	101	35	224	31	113	156
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	13	87	13	24	49
			firstReactRender	22	19	37	2	23	27
			getState	7	4	38	4	7	11
			initialActions	0	0	1	0	0	1
			loadScripts	1177	996	1528	116	1260	1403
			setupStore	6	4	84	8	6	8
	Webpack	Home	uiStartup	1543	1337	1993	141	1635	1818
			load	1311	1158	1740	126	1371	1572
			domContentLoaded	1311	1158	1740	126	1370	1572
			domInteractive	82	30	312	37	86	147
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	15	95	11	24	42
			firstReactRender	36	30	60	5	40	45
			getState	11	4	37	8	10	31
			initialActions	0	0	2	1	1	1
			loadScripts	1290	1142	1721	125	1352	1533
			setupStore	9	5	41	5	8	18

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 108 Bytes (0%)
ui: 439 Bytes (0.01%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-15T11:22:43Z

Builds ready [6a5302f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1205 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1205	1109	1644	67	1234	1322
			load	1039	955	1408	59	1064	1136
			domContentLoaded	1033	951	1397	58	1059	1131
			domInteractive	18	13	62	9	16	39
			firstPaint	745	111	1409	403	1051	1112
			backgroundConnect	6	4	15	2	7	9
			firstReactRender	19	15	31	2	20	24
			getState	12	5	39	8	17	30
			initialActions	0	0	1	0	0	1
			loadScripts	793	720	1080	52	816	883
			setupStore	8	4	19	2	8	13
	Webpack	Home	uiStartup	2130	1760	2630	166	2254	2381
			load	1629	1354	2014	128	1731	1805
			domContentLoaded	1622	1346	2004	127	1726	1798
			domInteractive	15	11	62	10	13	48
			firstPaint	184	83	392	62	221	325
			backgroundConnect	24	9	83	13	28	56
			firstReactRender	200	54	375	118	318	356
			getState	15	4	295	29	16	27
			initialActions	3	1	7	1	3	5
			loadScripts	1617	1345	1980	127	1723	1795
			setupStore	26	7	325	47	21	53
Firefox	Browserify	Home	uiStartup	1327	1148	1676	105	1403	1520
			load	1185	998	1558	114	1280	1401
			domContentLoaded	1185	998	1558	114	1280	1401
			domInteractive	102	38	228	34	118	181
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	12	105	13	19	35
			firstReactRender	22	18	54	4	22	27
			getState	7	4	35	4	7	10
			initialActions	0	0	1	0	0	1
			loadScripts	1167	984	1543	116	1261	1386
			setupStore	5	4	27	3	6	7
	Webpack	Home	uiStartup	1483	1313	1943	106	1540	1690
			load	1269	1133	1607	93	1325	1464
			domContentLoaded	1269	1132	1607	93	1325	1464
			domInteractive	79	49	241	26	88	132
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	55	7	23	40
			firstReactRender	35	28	54	5	37	46
			getState	8	5	29	4	9	12
			initialActions	0	0	1	0	1	1
			loadScripts	1250	1117	1586	93	1308	1449
			setupStore	8	5	68	7	8	20

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 800 Bytes (0.02%)
ui: 456 Bytes (0.01%)
common: 339 Bytes (0%)

fix: fix display nft full image

00a2a9b

metamaskbot added the team-assets label Apr 15, 2025

fix: add e2e

6142d59

sahar-fehri commented Apr 15, 2025

View reviewed changes

fix: fix test

6a5302f

sahar-fehri marked this pull request as ready for review April 15, 2025 10:47

sahar-fehri changed the title ~~fix: fix display nft full image~~ fix: cp-12.17.0 fix display nft full image Apr 15, 2025

salimtb approved these changes Apr 15, 2025

View reviewed changes

sahar-fehri changed the title ~~fix: cp-12.17.0 fix display nft full image~~ fix: cp-12.16.1 fix display nft full image Apr 15, 2025

kubolman mentioned this pull request Apr 15, 2025

feat: convert ui/components/ui/jazzicon/index.js to typescript #31971

Open

7 tasks

Prithpal-Sooriya approved these changes Apr 15, 2025

View reviewed changes

sahar-fehri added this pull request to the merge queue Apr 15, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2025

dbrans added this pull request to the merge queue Apr 15, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2025

sahar-fehri added this pull request to the merge queue Apr 15, 2025

Merged via the queue into main with commit 88edae5 Apr 15, 2025
178 checks passed

sahar-fehri deleted the fix/display-nft-fullImage branch April 15, 2025 13:33

github-actions bot locked and limited conversation to collaborators Apr 15, 2025

metamaskbot added the release-12.18.0 Issue or pull request that will be included in release 12.18.0 label Apr 15, 2025

vpintorico added the release-12.16.1 label Apr 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: cp-12.16.1 fix display nft full image #31967

fix: cp-12.16.1 fix display nft full image #31967

sahar-fehri commented Apr 15, 2025 •

edited

Loading

github-actions bot commented Apr 15, 2025

metamaskbot commented Apr 15, 2025

sahar-fehri Apr 15, 2025

metamaskbot commented Apr 15, 2025

metamaskbot commented Apr 15, 2025

fix: cp-12.16.1 fix display nft full image #31967

fix: cp-12.16.1 fix display nft full image #31967

Conversation

sahar-fehri commented Apr 15, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 15, 2025

metamaskbot commented Apr 15, 2025

sahar-fehri Apr 15, 2025

Choose a reason for hiding this comment

metamaskbot commented Apr 15, 2025

metamaskbot commented Apr 15, 2025

sahar-fehri commented Apr 15, 2025 •

edited

Loading