style: Update Send network avatar styling and search spacing #31955
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux
|
Builds ready [220b2d9]
UI Startup Metrics (1189 ± 62 ms)
Benchmark value 1661 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1514 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1514 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 1499 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 0ms | Sum of p95 exceeds: 64ms Sum of all benchmark exceeds: 64ms Bundle size diffs
|
vinnyhoward
approved these changes
Apr 22, 2025
micaelae
approved these changes
Apr 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This updates the network badge styling so that it looks consistent on the home page and in the Send flow. [](https://codespaces.new/MetaMask/metamask-extension/pull/31955?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Open MetaMask 2. Send 3. Click on the NFT tab 4. Send an NFT ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/user-attachments/assets/1e76c03e-360c-4b09-9f55-74f9d4faa841 ### **After** https://github.com/user-attachments/assets/eefba921-f4c1-4920-966b-1072ef1777b5 ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Builds ready [9259616]
UI Startup Metrics (1222 ± 63 ms)
Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Sum of mean exceeds: 0ms | Sum of p95 exceeds: 18ms Sum of all benchmark exceeds: 18ms Bundle size diffs
|
](https://codespaces.new/MetaMask/metamask-extension/pull/31955?quickstart=1){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the network badge styling so that it looks consistent on the home page and in the Send flow.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-04-15.at.9.02.01.AM.mov
After
Screen.Recording.2025-04-15.at.8.58.43.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist