Skip to content

fix: cp-12.17.0 fix clean up fiat conversion logic #31938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 14, 2025

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Apr 14, 2025

Description

fiat conversion should be displayed for new created wallet, the native balance should show 0$ as well

Open in GitHub Codespaces

Related issues

Fixes: #31920

Manual testing steps

  1. Create new Metamask wallet ( import SRP )
  2. Go to assets list
  3. fiat conversion should be displayed for erc20
  4. fiat conversion should be displayed for 0 balance native balance

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb changed the title fix: clean up fiat conversion logic fix: cp-12.17.0 fix clean up fiat conversion logic Apr 14, 2025
@salimtb salimtb marked this pull request as ready for review April 14, 2025 12:09
@metamaskbot
Copy link
Collaborator

Builds ready [c4128b8]
UI Startup Metrics (1207 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1207109214306212411329
load10529561232571139986
domContentLoaded10469521229561163988
domInteractive17134061729
firstPaint708741195415246965
backgroundConnect7433478
firstReactRender20166252025
getState12535779
initialActions001001
loadScripts80770595355834926
setupStore7516278
WebpackHomeuiStartup21411637256218922762469
load16521298193814117381886
domContentLoaded16421294191913917291875
domInteractive161159121352
firstPaint1797451262220350
backgroundConnect35103405325655
firstReactRender205543731195795
getState1842553979
initialActions317135
loadScripts16381292189513817261864
setupStore25630046308
FirefoxBrowserifyHomeuiStartup13541195181011114101600
load12121047166811712811469
domContentLoaded12121047166811712811468
domInteractive10238242318896
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect201367102039
firstReactRender23195552329
getState6416278
initialActions001001
loadScripts11931030164911812631451
setupStore547167
WebpackHomeuiStartup15051316194811915581793
load12871136161010113421524
domContentLoaded12861136161010113421524
domInteractive8237217287792
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21144972239
firstReactRender36296663847
getState8531589
initialActions001011
loadScripts12681122159110113261503
setupStore1052142178

@metamaskbot
Copy link
Collaborator

Builds ready [8e3d08c]
UI Startup Metrics (1220 ± 59 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1220108914065912551335
load10639541222551118990
domContentLoaded10579511215551123992
domInteractive18137091631
firstPaint7341401223412230957
backgroundConnect7418279
firstReactRender22156472242
getState13536878
initialActions001001
loadScripts81672497853844941
setupStore8520378
WebpackHomeuiStartup21921796262017823182504
load16811356202714817931939
domContentLoaded16741351200014617851935
domInteractive161163111346
firstPaint20172160215121972
backgroundConnect3010374383164
firstReactRender228574001185791
getState1542482569
initialActions319146
loadScripts16691349197614417831912
setupStore25723834308
FirefoxBrowserifyHomeuiStartup13571201172411514251616
load12091047152911712821484
domContentLoaded12091047152911712821484
domInteractive10840189328696
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect221492122340
firstReactRender23193232328
getState8430478
initialActions001001
loadScripts11891031150811612641465
setupStore5412167
WebpackHomeuiStartup15561370207114416401882
load13261163183013114041594
domContentLoaded13251162182913114041593
domInteractive8041229287186
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect251593132550
firstReactRender37296464049
getState9533489
initialActions002111
loadScripts13031146180612913881573
setupStore10637689

@salimtb salimtb added this pull request to the merge queue Apr 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 14, 2025
@salimtb salimtb added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit a408e6c Apr 14, 2025
166 checks passed
@salimtb salimtb deleted the fix/fix-token-list-fiat-assets branch April 14, 2025 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2025
@metamaskbot metamaskbot added the release-12.18.0 Issue or pull request that will be included in release 12.18.0 label Apr 14, 2025
@DDDDDanica DDDDDanica added release-12.17.0 Issue or pull request that will be included in release 12.17.0 and removed release-12.18.0 Issue or pull request that will be included in release 12.18.0 labels Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Aggregated balance not displayed
5 participants