Skip to content

fix: Swap to ethereum string #31715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 10, 2025
Merged

fix: Swap to ethereum string #31715

merged 10 commits into from
Apr 10, 2025

Conversation

GustavoRSSilva
Copy link
Contributor

@GustavoRSSilva GustavoRSSilva commented Apr 8, 2025

Description

Fix swap to Ethereum

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Do a bridge in Ethereum
  2. Check activity

Screenshots/Recordings

Before

Screenshot 2025-04-08 at 16 12 53

After

Screenshot 2025-04-08 at 16 21 04

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GustavoRSSilva GustavoRSSilva requested a review from a team as a code owner April 8, 2025 15:23
Copy link
Contributor

github-actions bot commented Apr 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label Apr 8, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

  • ui/pages/confirmations/confirmation/alerts/TemplateAlertContext.tsx

ghgoodreau
ghgoodreau previously approved these changes Apr 8, 2025
OGPoyraz
OGPoyraz previously approved these changes Apr 8, 2025
@GustavoRSSilva GustavoRSSilva dismissed stale reviews from OGPoyraz and ghgoodreau via 452ddcd April 8, 2025 17:39
@metamaskbot
Copy link
Collaborator

Builds ready [ab4fd7a]
UI Startup Metrics (1262 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1262113214146613071390
load11049561266671169986
domContentLoaded10979481261671157979
domInteractive17137591630
firstPaint809801256424198958
backgroundConnect10631399
firstReactRender2215232222027
getState13448878
initialActions001001
loadScripts84670199164894961
setupStore8529379
WebpackHomeuiStartup21741751260717522922393
load16991357204115217931980
domContentLoaded16931354203115117901972
domInteractive171266121453
firstPaint17164139713824485
backgroundConnect3411228333662
firstReactRender182543891145993
getState1532332579
initialActions316145
loadScripts16851351200914817861947
setupStore21718124309
FirefoxBrowserifyHomeuiStartup13501176179611913961625
load12131051164411512561462
domContentLoaded12131051164411512561462
domInteractive9839235298898
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect251693112451
firstReactRender23195152229
getState8381979
initialActions001001
loadScripts11891034161911412371443
setupStore6432367
WebpackHomeuiStartup15211349186810915921757
load13131145162510113731496
domContentLoaded13131145162510113721496
domInteractive9939279309095
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect25195062537
firstReactRender35285353848
getState10431789
initialActions102111
loadScripts12901126160010013511466
setupStore8542589

@GustavoRSSilva GustavoRSSilva added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit 58c4b1a Apr 10, 2025
166 checks passed
@GustavoRSSilva GustavoRSSilva deleted the fix/swap-to-ethreum branch April 10, 2025 08:49
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-swaps-and-bridge For issues with Swaps or Bridging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants