chore: Bump network-controller to v23 #31711

mcmire · 2025-04-08T14:22:20Z

Description

We are splitting this off from the RPC failover PR to unblock other controller upgrades.

Additionally, we are pinning controller-utils to 11.7.0

Related issues

N/A

Manual testing steps

There should be no functional changes, everything should work as-is.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

We are splitting this off from the RPC failover PR to unblock other controller upgrades. Additionally, we are pinning `controller-utils` to 11.6.0 across the board because newer versions add MegaETH to key constants and it seems to be breaking functionality. Once we fully integrate the MegaETH then we should be able to upgrade `controller-utils` completely.

github-actions · 2025-04-08T14:22:34Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-04-08T14:22:48Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub ↗.

	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	[email protected] ⏵ 1.0.30001707	⁺¹		⁺¹
	@metamask/[email protected] ⏵ 10.1.1	⁺¹⁷			⁺²

View full report ↗

mcmire · 2025-04-08T14:23:23Z

@metamaskbot update-policies

metamaskbot · 2025-04-08T14:35:07Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-04-08T14:37:17Z

✨ Files requiring CODEOWNER review ✨

🧩 @MetaMask/extension-devs

lavamoat/browserify/beta/policy.json
lavamoat/browserify/flask/policy.json
lavamoat/browserify/main/policy.json
lavamoat/browserify/mmi/policy.json

📜 @MetaMask/policy-reviewers

lavamoat/browserify/beta/policy.json
lavamoat/browserify/flask/policy.json
lavamoat/browserify/main/policy.json
lavamoat/browserify/mmi/policy.json

🔗 @MetaMask/supply-chain

lavamoat/browserify/beta/policy.json
lavamoat/browserify/flask/policy.json
lavamoat/browserify/main/policy.json
lavamoat/browserify/mmi/policy.json

package.json

mcmire · 2025-04-08T14:53:15Z

@metamaskbot update-policies

metamaskbot · 2025-04-08T15:17:21Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

mcmire · 2025-04-08T20:05:30Z

@metamaskbot update-policies

metamaskbot · 2025-04-08T20:21:31Z

No policy changes

mcmire · 2025-04-08T22:31:03Z

@metamaskbot update-policies

metamaskbot · 2025-04-08T22:43:55Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

mcmire · 2025-04-09T04:58:53Z

Still some e2e failures, but far less than before. I also notice e2e failures on main, so maybe some of these are not the fault of this PR. I'll investigate this more tomorrow.

mcmire · 2025-04-09T21:48:10Z

Looks like I wasn't quite able to get this merged today. I'm out until Monday 4/14, so whoever wants to take this over and get this merged please feel free.

stanleyyconsensys · 2025-04-10T01:39:32Z

Looks like I wasn't quite able to get this merged today. I'm out until Monday 4/14, so whoever wants to take this over and get this merged please feel free.

will help to continue the work

metamaskbot · 2025-04-10T02:18:53Z

Builds ready [5ed4f8e]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1206 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1206	1089	1448	59	1240	1284
			load	1056	968	1234	47	1106	991
			domContentLoaded	1050	958	1225	46	1107	992
			domInteractive	17	13	57	6	17	28
			firstPaint	712	71	1124	419	221	90
			backgroundConnect	7	4	29	3	7	8
			firstReactRender	20	15	51	7	19	40
			getState	12	4	31	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	813	726	981	45	836	878
			setupStore	7	5	14	2	7	8
	Webpack	Home	uiStartup	2157	1739	2457	188	2310	2385
			load	1714	1354	2137	152	1781	1970
			domContentLoaded	1706	1350	2132	150	1777	1954
			domInteractive	17	12	62	11	14	52
			firstPaint	160	64	378	62	245	83
			backgroundConnect	31	9	245	30	36	62
			firstReactRender	145	53	380	103	62	93
			getState	18	4	277	36	7	9
			initialActions	3	1	7	1	3	5
			loadScripts	1700	1349	2129	147	1774	1925
			setupStore	23	6	274	38	7	9
Firefox	Browserify	Home	uiStartup	1367	1187	1762	125	1423	1620
			load	1222	1051	1642	119	1280	1461
			domContentLoaded	1222	1051	1640	119	1279	1460
			domInteractive	98	39	270	30	89	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	80	9	20	38
			firstReactRender	23	19	55	6	24	34
			getState	11	4	201	23	7	9
			initialActions	0	0	2	0	0	1
			loadScripts	1204	1036	1627	119	1260	1440
			setupStore	7	4	38	6	6	7
	Webpack	Home	uiStartup	1506	1340	1848	107	1570	1675
			load	1297	1162	1648	97	1355	1467
			domContentLoaded	1296	1162	1648	97	1354	1467
			domInteractive	93	37	212	27	86	95
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	46	7	24	40
			firstReactRender	34	28	51	5	36	44
			getState	8	4	29	5	8	9
			initialActions	0	0	1	0	1	1
			loadScripts	1277	1148	1628	96	1338	1450
			setupStore	9	5	47	6	8	8

stanleyyconsensys

LGTM

metamaskbot added the team-wallet-framework label Apr 8, 2025

mcmire mentioned this pull request Apr 8, 2025

chore: clean up MegaETH tech debt #31644

Closed

7 tasks

mcmire changed the title ~~Bump network-controller to v23~~ chore: Bump network-controller to v23 Apr 8, 2025

Update LavaMoat policies

426c899

mcmire commented Apr 8, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

yarn dedupe

8e285bd

Update LavaMoat policies

2cb7145

mcmire added 3 commits April 8, 2025 15:17

Merge branch 'main' into bump-network-controller-to-v23

8695bd6

Fix unit tests

0e8948d

Don't pin controller-utils

139357c

Update LavaMoat policies

ef79b0d

mcmire added 4 commits April 8, 2025 21:30

Update patch file

44beeaf

Fix state snapshots

d5ff19d

Fix API specs

e38259f

Fix patch

0ec1722

mcmire added 2 commits April 9, 2025 06:42

Merge branch 'main' into bump-network-controller-to-v23

a3026b3

Revert this file

6cb2982

mcmire dismissed stale reviews from dbrans and MajorLift via d3a8063 April 9, 2025 21:46

mcmire mentioned this pull request Apr 9, 2025

feat: Auto-failover to Quicknode when Infura is down #31089

Open

7 tasks

mcmire and others added 2 commits April 9, 2025 16:19

yarn dedupe

bacc72b

Merge branch 'main' into bump-network-controller-to-v23

8752de4

Merge branch 'main' into bump-network-controller-to-v23

5ed4f8e

stanleyyconsensys approved these changes Apr 10, 2025

View reviewed changes

stanleyyconsensys requested review from dbrans, DDDDDanica and MajorLift April 10, 2025 03:54

stanleyyconsensys enabled auto-merge April 10, 2025 04:04

MajorLift approved these changes Apr 10, 2025

View reviewed changes

stanleyyconsensys added this pull request to the merge queue Apr 10, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2025

stanleyyconsensys added this pull request to the merge queue Apr 10, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2025

stanleyyconsensys added this pull request to the merge queue Apr 10, 2025

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 10, 2025

davidmurdoch approved these changes Apr 10, 2025

View reviewed changes

gantunesr added this pull request to the merge queue Apr 10, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2025

gantunesr added this pull request to the merge queue Apr 10, 2025

Merged via the queue into main with commit aa2b493 Apr 10, 2025
169 checks passed

gantunesr deleted the bump-network-controller-to-v23 branch April 10, 2025 19:48

github-actions bot locked and limited conversation to collaborators Apr 10, 2025

metamaskbot added the release-12.18.0 Issue or pull request that will be included in release 12.18.0 label Apr 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Bump network-controller to v23 #31711

chore: Bump network-controller to v23 #31711

mcmire commented Apr 8, 2025 •

edited by stanleyyconsensys

Loading

github-actions bot commented Apr 8, 2025

socket-security bot commented Apr 8, 2025 •

edited

Loading

mcmire commented Apr 8, 2025

metamaskbot commented Apr 8, 2025

metamaskbot commented Apr 8, 2025

mcmire commented Apr 8, 2025

metamaskbot commented Apr 8, 2025

mcmire commented Apr 8, 2025

metamaskbot commented Apr 8, 2025

mcmire commented Apr 8, 2025

metamaskbot commented Apr 8, 2025

mcmire commented Apr 9, 2025

mcmire commented Apr 9, 2025

stanleyyconsensys commented Apr 10, 2025

metamaskbot commented Apr 10, 2025

stanleyyconsensys left a comment

chore: Bump network-controller to v23 #31711

chore: Bump network-controller to v23 #31711

Conversation

mcmire commented Apr 8, 2025 • edited by stanleyyconsensys Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 8, 2025

socket-security bot commented Apr 8, 2025 • edited Loading

mcmire commented Apr 8, 2025

metamaskbot commented Apr 8, 2025

metamaskbot commented Apr 8, 2025

✨ Files requiring CODEOWNER review ✨

mcmire commented Apr 8, 2025

metamaskbot commented Apr 8, 2025

mcmire commented Apr 8, 2025

metamaskbot commented Apr 8, 2025

mcmire commented Apr 8, 2025

metamaskbot commented Apr 8, 2025

mcmire commented Apr 9, 2025

mcmire commented Apr 9, 2025

stanleyyconsensys commented Apr 10, 2025

metamaskbot commented Apr 10, 2025

stanleyyconsensys left a comment

Choose a reason for hiding this comment

mcmire commented Apr 8, 2025 •

edited by stanleyyconsensys

Loading

socket-security bot commented Apr 8, 2025 •

edited

Loading