Skip to content

feat: fix srp list padding #31697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

feat: fix srp list padding #31697

merged 1 commit into from
Apr 8, 2025

Conversation

PatrykLucka
Copy link
Contributor

Description

Updates the srp-list padding.

Related issues

Fixes:

Manual testing steps

  1. Open account menu
  2. Make sure you have at least 2 SRPs (import new one if there is only one)
  3. Click Ethereum account
  4. Click selected SRP
  5. SRP list should be displayed

Screenshots/Recordings

Before

Screenshot 2025-04-08 at 12 39 18 Screenshot 2025-04-08 at 12 39 24

After

Screenshot 2025-04-08 at 12 38 23 Screenshot 2025-04-08 at 12 40 11

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@PatrykLucka PatrykLucka self-assigned this Apr 8, 2025
Copy link
Contributor

github-actions bot commented Apr 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mmi PRs from the MMI team label Apr 8, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

  • ui/components/multichain/multi-srp/srp-list/srp-list.tsx

@metamaskbot
Copy link
Collaborator

Builds ready [c0f224a]
UI Startup Metrics (1230 ± 59 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1230111013995912671344
load10789701208551138990
domContentLoaded10719651202551141991
domInteractive16133341629
firstPaint7061351208433229992
backgroundConnect106688910
firstReactRender19143742026
getState145841079
initialActions001001
loadScripts81872495154838931
setupStore8424378
WebpackHomeuiStartup21291689248618222642377
load16651290202516117621937
domContentLoaded16561284201615917551918
domInteractive171264111450
firstPaint165663756728396
backgroundConnect3110395393551
firstReactRender174533611085891
getState12358989
initialActions318145
loadScripts16481278199215617431894
setupStore176489348
FirefoxBrowserifyHomeuiStartup13601156189516113851826
load12151037174915212341653
domContentLoaded12141037174915212341653
domInteractive9843267289098
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24165582550
firstReactRender23194442333
getState1132372989
initialActions001001
loadScripts11921019172915212061632
setupStore6327368
WebpackHomeuiStartup15321347213815715891874
load13141143187814213521667
domContentLoaded13141143187814213521667
domInteractive9846256289198
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect26175762843
firstReactRender37295564047
getState1242762789
initialActions002111
loadScripts12911120185414113301642
setupStore1153233289
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: -14 Bytes (0%)
  • common: 0 Bytes (0%)

@PatrykLucka PatrykLucka marked this pull request as ready for review April 8, 2025 11:25
@PatrykLucka PatrykLucka requested a review from a team as a code owner April 8, 2025 11:25
@PatrykLucka PatrykLucka enabled auto-merge April 8, 2025 16:27
@PatrykLucka PatrykLucka added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit 46b63ae Apr 8, 2025
170 checks passed
@PatrykLucka PatrykLucka deleted the change-srp-list-padding branch April 8, 2025 19:12
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants